Skip to contentSkip to conversation

hwmon: (thmc50) Stop using

PATCH In review Jean Delvare 2 participants 3 messages Oct 9, 2009 – Oct 11, 2009 Hardware monitoring

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 hwmon: (thmc50) Stop using

From: Jean Delvare <[email protected]>
Subject: hwmon: (thmc50) Stop using I2C_CLIENT_MODULE_PARM

The thmc50 driver is the last user of I2C_CLIENT_MODULE_PARM, and I would like to get rid of that macro.

Cc Krzysztof Helt <[email protected]>

---
Krzysztof, can you please test this patch?

 drivers/hwmon/thmc50.c |    6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)
drivers/hwmon/thmc50.c +5 -1
@@ -36,7 +36,11 @@ static const unsigned short normal_i2c[]
 
 /* Insmod parameters */
 I2C_CLIENT_INSMOD_2(thmc50, adm1022);
-I2C_CLIENT_MODULE_PARM(adm1022_temp3, "List of adapter,address pairs "
+
+static unsigned short adm1022_temp3[16];
+static unsigned int adm1022_temp3_num;
+module_param_array(adm1022_temp3, ushort, &adm1022_temp3_num, 0);
+MODULE_PARM_DESC(adm1022_temp3, "List of adapter,address pairs "
 			"to enable 3rd temperature (ADM1022 only)");
 
 /* Many THMC50 constants specified below */
Signature · 6 lines
Jean Delvare

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
Tested-by on v1 1/1
#1 lore raw
Quoted 9 lines · On Fri, 9 Oct 2009 13:27:29 +0200 Jean Delvare <[email protected]> wrote:

From: Jean Delvare <[email protected]>
Subject: hwmon: (thmc50) Stop using I2C_CLIENT_MODULE_PARM

The thmc50 driver is the last user of I2C_CLIENT_MODULE_PARM, and I would like to get rid of that macro.

Cc Krzysztof Helt <[email protected]>

---

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

#2 lore raw
In reply to Jean Delvare
Quoted 6 lines · Krzysztof Helt
Quoted 3 lines · On Fri, 9 Oct 2009 13:27:29 +0200 Jean Delvare <[email protected]> wrote:

From: Jean Delvare <[email protected]>
Subject: hwmon: (thmc50) Stop using I2C_CLIENT_MODULE_PARM

Quoted 8 lines
Quoted 6 lines

The thmc50 driver is the last user of I2C_CLIENT_MODULE_PARM, and I would like to get rid of that macro.

Cc Krzysztof Helt <[email protected]>

---

Excellent, thank you!

Signature · 6 lines
Jean Delvare

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors