Skip to contentSkip to conversation

Clone range ioctl

DISCUSSION Alberto Bertogli 2 participants 3 messages Sep 26, 2009 – Oct 10, 2009 Btrfs file system

lore
Share & tools
lore
#0 lore raw

Hi!

Out of curiosity for btrfs, I'm modifying a project of mine
(http://blitiri.com.ar/p/libjio) to use the clone range ioctl, and I've got a couple of questions. I thought this would be the place to ask them, I hope you don't mind:

- Once the ioctl() returns successfully, is data supposed to be on the disk, or should I sync it manually (fdatasync()/sync_file_range())? From a quick peek at the code it seems the former, but it'd be nice to get confirmation.
- I've hit a couple of bugs (2.6.31's fs/btrfs/file.c:528, for example); should I take a look and report them, or this code is not expected to work yet?
- Are there any special considerations an application should take when using it?
- Since I need to use block-aligned offsets, how can I find out the appropriate block size for a given file without being root? I've hardcoded it to 4k for the time being, but I couldn't find out how to ask the filesystem except for the BLKGETBSZ, which requires being root. I'm obviously ok with a btrfs-only solution.

If anyone could answer any of these (or point me to the relevant code), I'd really appreciate it.

Thanks a lot,
Alberto

#1 lore raw
Quoted 11 lines · Alberto Bertogli

Hi!

Out of curiosity for btrfs, I'm modifying a project of mine
(http://blitiri.com.ar/p/libjio) to use the clone range ioctl, and I've got a couple of questions. I thought this would be the place to ask them, I hope you don't mind:

- Once the ioctl() returns successfully, is data supposed to be on the disk, or should I sync it manually (fdatasync()/sync_file_range())? From a quick peek at the code it seems the former, but it'd be nice to get confirmation.

Yes, when the ioctl is done the file is on disk. This is more of an accident of the implementation than a requirement, but it isn't going to change.

Quoted 3 lines

- I've hit a couple of bugs (2.6.31's fs/btrfs/file.c:528, for example); should I take a look and report them, or this code is not expected to work yet?

I think this one was fixed by Sage, if you pull from the btrfs-unstable git tree's master branch it should be resolved.

Quoted 2 lines

- Are there any special considerations an application should take when using it?

Since cloning reuses existing blocks, it may cause more seeking on reads than a pure copy.

Quoted 5 lines

- Since I need to use block-aligned offsets, how can I find out the appropriate block size for a given file without being root? I've hardcoded it to 4k for the time being, but I couldn't find out how to ask the filesystem except for the BLKGETBSZ, which requires being root. I'm obviously ok with a btrfs-only solution.

For btrfs you'll be safe using the page size.

Quoted 3 lines

If anyone could answer any of these (or point me to the relevant code), I'd really appreciate it.

Thanks for giving things a try.

-chris

#2 lore raw
Quoted 17 lines · Chris Mason
Quoted 11 lines · Alberto Bertogli

Hi!

Out of curiosity for btrfs, I'm modifying a project of mine
(http://blitiri.com.ar/p/libjio) to use the clone range ioctl, and I've got a couple of questions. I thought this would be the place to ask them, I hope you don't mind:

- Once the ioctl() returns successfully, is data supposed to be on the disk, or should I sync it manually (fdatasync()/sync_file_range())? From a quick peek at the code it seems the former, but it'd be nice to get confirmation.

Yes, when the ioctl is done the file is on disk. This is more of an accident of the implementation than a requirement, but it isn't going to change.

Quoted 6 lines
Quoted 3 lines

- I've hit a couple of bugs (2.6.31's fs/btrfs/file.c:528, for example); should I take a look and report them, or this code is not expected to work yet?

I think this one was fixed by Sage, if you pull from the btrfs-unstable git tree's master branch it should be resolved.

Just did, and the two bugs that I was hitting are now fixed.

Thanks a lot,
Alberto