x86: Relegate CONFIG_PAT to EMBEDDED
PATCH 1/1 x86: Relegate CONFIG_PAT to EMBEDDED
Quoted 1 line
From
3385e0ae9596dc0538023166c800b0f8d2accce2Mon Sep 17 00:00:00 2001
From: Arjan van de Ven <[email protected]>
Date: Sun, 11 Oct 2009 08:40:15 -0700
Subject: [PATCH] x86: Relegate CONFIG_PAT to EMBEDDED
PAT support (which got added to CPUs over 10 years ago) is no longer really optional in that more and more things are depending on PAT just working, including newer versions of X. Having this as a regular config option just no longer makes sense.
This patch relegates CONFIG_PAT to the EMBEDDED category, in the hope to eventually completely retire it.
--- arch/x86/Kconfig | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-)
arch/x86/Kconfig +2 -1
@@ -1393,7 +1393,8 @@ config MTRR_SANITIZER_SPARE_REG_NR_DEFAULT config X86_PAT bool - prompt "x86 PAT support" + default y + prompt "x86 PAT support" if EMBEDDED depends on MTRR ---help--- Use PAT attributes to setup page level cache control.
Signature · 8 lines
1.6.2.5 -- Arjan van de Ven Intel Open Source Technology Centre For development, discussion and tips for power savings, visit http://www.lesswatts.org
Makes sense, but given that X86_PAT depends on MTRR
config X86_PAT
bool
- prompt "x86 PAT support"
+ default y
+ prompt "x86 PAT support" if EMBEDDED
depends on MTRR
should we give the same treatment to the MTRR option too? (As far as I can tell, MTRR defaults to n in the current Kconfig too)
- R.
Quoted 11 lines · Roland Dreier
Makes sense, but given that
X86_PATdepends on MTRRconfig
X86_PAT
boolarch/x86/Kconfig +2
-1- prompt "x86 PAT support" + default y + prompt "x86 PAT support" if EMBEDDED depends on MTRRshould we give the same treatment to the MTRR option too? (As far as I can tell, MTRR defaults to n in the current
Kconfigtoo)
I think so, you'd have to be fairly insane to want to disable MTRR support..
Quoted 9 lines · On Sun, 11 Oct 2009 10:04:10 -0700 Roland Dreier <[email protected]> wrote:
Makes sense, but given that
X86_PATdepends on MTRRconfig
X86_PAT(quoted diff) +2
-1bool - prompt "x86 PAT support" + default y + prompt "x86 PAT support" if EMBEDDED depends on MTRR
Quoted 3 lines
should we give the same treatment to the MTRR option too? (As far as I can tell, MTRR defaults to n in the current
Kconfigtoo)
good point
Quoted 1 line
From
db3a4eb2b16907c0651ed5d4bcdfbd395a0a7ad4Mon Sep 17 00:00:00 2001
From: Arjan van de Ven <[email protected]>
Date: Sun, 11 Oct 2009 08:40:15 -0700
Subject: [PATCH] x86: Relegate CONFIG_X86_PAT and CONFIG_MTRR to EMBEDDED
MTRR and PAT support (which got added to CPUs over 10 years ago) are no longer really optional in that more and more things are depending on PAT just working, including various drivers and newer versions of X. (to not even speak of MTRR)
Having this as a regular config option just no longer makes sense.
This patch relegates CONFIG_X86_PAT to the EMBEDDED category, in the hope to eventually completely retire it.
--- arch/x86/Kconfig | 7 +++++-- 1 files changed, 5 insertions(+), 2 deletions(-)
arch/x86/Kconfig +5 -2
@@ -1327,7 +1327,9 @@ config MATH_EMULATION kernel, it won't hurt. config MTRR - bool "MTRR (Memory Type Range Register) support" + bool + default y + prompt "MTRR (Memory Type Range Register) support" if EMBEDDED ---help--- On Intel P6 family processors (Pentium Pro, Pentium II and later) the Memory Type Range Registers (MTRRs) may be used to control
@@ -1393,7 +1395,8 @@ config MTRR_SANITIZER_SPARE_REG_NR_DEFAULT config X86_PAT bool - prompt "x86 PAT support" + default y + prompt "x86 PAT support" if EMBEDDED depends on MTRR ---help--- Use PAT attributes to setup page level cache control.
Signature · 9 lines
1.6.2.5 -- Arjan van de Ven Intel Open Source Technology Centre For development, discussion and tips for power savings, visit http://www.lesswatts.org
Quoted 4 lines · Arjan van de Ven
MTRR and PAT support (which got added to CPUs over 10 years ago) are no longer really optional in that more and more things are depending on PAT just working, including various drivers and newer versions of X. (to not even speak of MTRR)
Please take a look at early_init_intel() in arch/x86/kernel/cpu/intel.c. it disables PAT for what must amount to more than a *million* of machines. It certainly includes all Centrino laptops, for example(!).
FYI, these computers will be with us for at least 10 years, still. I still have users of Mobile Pentium II reporting bugs on thinkpad-acpi, and I know of a *huge* number of active Pentium II and Pentium III desktops in Brazil. My 5-year-old ThinkPad T43 (Centrino, Pentium M) cheerfully reports "PAT not supported by CPU" at boot if I decide to waste memory by enabling CONFIG_X86_PAT.
So, unless that blacklist can be drastically reduced somehow, can we *please* fix anything that depends on PAT "just working"? Because as far as the kernel is concerned right now, way too many machines can't even dream of using PAT.
Signature · 4 lines
"One disk to rule them all, One disk to find them. One disk to bring them all and in the darkness grind them. In the Land of Redmond where the shadows lie." -- The Silicon Valley Tarot Henrique Holschuh
[tip:x86/pat] x86: Relegate CONFIG_PAT and CONFIG_MTRR configurability to EMBEDDED
In reply to Arjan van de VenCommit-ID: c03cb3149daed3e411657e3212d05ae27cf1a874 Gitweb: http://git.kernel.org/tip/c03cb3149daed3e411657e3212d05ae27cf1a874 Author: Arjan van de Ven <[email protected]> AuthorDate: Sun, 11 Oct 2009 10:33:02 -0700 Committer: Ingo Molnar <[email protected]> CommitDate: Mon, 12 Oct 2009 13:06:57 +0200
x86: Relegate CONFIG_PAT and CONFIG_MTRR configurability to EMBEDDED
MTRR and PAT support (which got added to CPUs over 10 years ago) are no longer really optional in that more and more things are depending on PAT just working, including various drivers and newer versions of X. (to not even speak of MTRR)
Having this as a regular config option just no longer makes sense.
This patch relegates CONFIG_X86_PAT to the EMBEDDED category so ultra-embedded can still disable it if they really need to.
LKML-Reference: <[email protected]>
--- arch/x86/Kconfig | 7 +++++-- 1 files changed, 5 insertions(+), 2 deletions(-)
arch/x86/Kconfig +5 -2
@@ -1321,7 +1321,9 @@ config MATH_EMULATION kernel, it won't hurt. config MTRR - bool "MTRR (Memory Type Range Register) support" + bool + default y + prompt "MTRR (Memory Type Range Register) support" if EMBEDDED ---help--- On Intel P6 family processors (Pentium Pro, Pentium II and later) the Memory Type Range Registers (MTRRs) may be used to control
@@ -1387,7 +1389,8 @@ config MTRR_SANITIZER_SPARE_REG_NR_DEFAULT config X86_PAT bool - prompt "x86 PAT support" + default y + prompt "x86 PAT support" if EMBEDDED depends on MTRR ---help--- Use PAT attributes to setup page level cache control.
H. Peter Anvin
reviewerRe: [tip:x86/pat] x86: Relegate CONFIG_PAT and CONFIG_MTRR configurability to EMBEDDED
Quoted 14 lines · tip-bot for Arjan van de Ven
Commit-ID: c03cb3149daed3e411657e3212d05ae27cf1a874 Gitweb: http://git.kernel.org/tip/c03cb3149daed3e411657e3212d05ae27cf1a874 Author: Arjan van de Ven <[email protected]> AuthorDate: Sun, 11 Oct 2009 10:33:02 -0700 Committer: Ingo Molnar <[email protected]> CommitDate: Mon, 12 Oct 2009 13:06:57 +0200x86: Relegate
CONFIG_PATandCONFIG_MTRRconfigurability to EMBEDDEDMTRR and PAT support (which got added to CPUs over 10 years ago) are no longer really optional in that more and more things are depending on PAT just working, including various drivers and newer versions of X. (to not even speak of MTRR)
Quoted 5 lines
Having this as a regular config option just no longer makes sense.
This patch relegates
CONFIG_X86_PATto the EMBEDDED category so ultra-embedded can still disable it if they really need to.
Should we combine this with removing the whitelist (which is largely vestigial at this point) and replace it with a blacklist (possibly empty)? I still haven't seen any evidence that there are any CPUs which have problems, and PAT support go back all the way to Pentium III -- and page table attributes can be used all the way back to 386, it just excludes the WC type.
-hpa
Re: [tip:x86/pat] x86: Relegate CONFIG_PAT and CONFIG_MTRR configurability to EMBEDDED
Quoted 21 lines · H. Peter Anvin
Quoted 14 lines · tip-bot for Arjan van de Ven
Commit-ID: c03cb3149daed3e411657e3212d05ae27cf1a874 Gitweb: http://git.kernel.org/tip/c03cb3149daed3e411657e3212d05ae27cf1a874 Author: Arjan van de Ven <[email protected]> AuthorDate: Sun, 11 Oct 2009 10:33:02 -0700 Committer: Ingo Molnar <[email protected]> CommitDate: Mon, 12 Oct 2009 13:06:57 +0200x86: Relegate
CONFIG_PATandCONFIG_MTRRconfigurability to EMBEDDEDMTRR and PAT support (which got added to CPUs over 10 years ago) are no longer really optional in that more and more things are depending on PAT just working, including various drivers and newer versions of X. (to not even speak of MTRR)
Quoted 5 lines
Having this as a regular config option just no longer makes sense.
This patch relegates
CONFIG_X86_PATto the EMBEDDED category so ultra-embedded can still disable it if they really need to.
Quoted 6 lines
Should we combine this with removing the whitelist (which is largely vestigial at this point) and replace it with a blacklist (possibly empty)? I still haven't seen any evidence that there are any CPUs which have problems, and PAT support go back all the way to Pentium III -- and page table attributes can be used all the way back to 386, it just excludes the WC type.
I would be in favor of that; other operating systems have been using pat everywhere since the pII days anyway.
Re: [tip:x86/pat] x86: Relegate CONFIG_PAT and CONFIG_MTRR configurability to EMBEDDED
Quoted 29 lines · Arjan van de Ven
Quoted 21 lines · H. Peter Anvin
Quoted 14 lines · tip-bot for Arjan van de Ven
Commit-ID: c03cb3149daed3e411657e3212d05ae27cf1a874 Gitweb: http://git.kernel.org/tip/c03cb3149daed3e411657e3212d05ae27cf1a874 Author: Arjan van de Ven <[email protected]> AuthorDate: Sun, 11 Oct 2009 10:33:02 -0700 Committer: Ingo Molnar <[email protected]> CommitDate: Mon, 12 Oct 2009 13:06:57 +0200x86: Relegate
CONFIG_PATandCONFIG_MTRRconfigurability to EMBEDDEDMTRR and PAT support (which got added to CPUs over 10 years ago) are no longer really optional in that more and more things are depending on PAT just working, including various drivers and newer versions of X. (to not even speak of MTRR)
Quoted 5 lines
Having this as a regular config option just no longer makes sense.
This patch relegates
CONFIG_X86_PATto the EMBEDDED category so ultra-embedded can still disable it if they really need to.Quoted 6 lines
Should we combine this with removing the whitelist (which is largely vestigial at this point) and replace it with a blacklist (possibly empty)? I still haven't seen any evidence that there are any CPUs which have problems, and PAT support go back all the way to Pentium III -- and page table attributes can be used all the way back to 386, it just excludes the WC type.
Quoted 2 lines
I would be in favor of that; other operating systems have been using pat everywhere since the pII days anyway.
Fine to me too. We only made it a whitelist to reduce the degrees of freedom early in the implementation - it stuck around needlessly long.
Ingo