Skip to contentSkip to conversation

spi: controller driver for Designware SPI core and PCI interface

PATCH In review Feng Tang 2 participants 5 messages Oct 12, 2009 – Oct 13, 2009 2 messages not in the archive SPI

lore
Share & tools
lore

Feng Tang

author
#0 lore raw

v3 cover spi: controller driver for Designware SPI core and PCI interface

Hi all,

This patch series adds driver for Designware SPI core + PCI interface, and they are generated against kernel 2.6.32-rc4

0001: driver for the DW SPI core
0002: driver for PCI interface
0003: add DMA support

This driver has been verified on Intel Moorestown platform, with Maxim's Max3110 UART device and Option's 3G modem GTM501L, both PIO and DMA works fine, and these 2 slave devcies can work simultaneously.

0003 is RFC only, as it has dependency over DMA controller driver's acceptance to mainline.

User can use "dw_apb_ssi_db.pdf" from Synopsys as HW datasheet

please help to review them.

---------------
change history:
v3
* address some review comments from Andrew Morton

v2
* divide the original one driver to "core+interface" framework according to David's comments

v1
* initial submission

Thanks,
Feng

------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference

#1 lore raw
Quoted 7 lines · On Mon, 12 Oct 2009 14:17:16 +0800 Feng Tang…

This patch series adds driver for Designware SPI core + PCI interface, and they are generated against kernel 2.6.32-rc4

0001: driver for the DW SPI core
0002: driver for PCI interface
0003: add DMA support

Quoted 6 lines

This driver has been verified on Intel Moorestown platform, with Maxim's Max3110 UART device and Option's 3G modem GTM501L, both PIO and DMA works fine, and these 2 slave devcies can work simultaneously.

0003 is RFC only, as it has dependency over DMA controller driver's acceptance to mainline.

What is "DMA controller driver"? Some other patch? What is the status of that patch and where is it?

------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference

A message that is not in the archive (sent off-list or not yet received): 20091012152553.c95d8055.akpm-de/[email protected]

author
#3 lore raw
Quoted 15 lines · On Tue, 13 Oct 2009 06:25:53 +0800 Andrew Morton…
Quoted 12 lines · On Mon, 12 Oct 2009 14:17:16 +0800 Feng Tang…

This patch series adds driver for Designware SPI core + PCI interface, and they are generated against kernel 2.6.32-rc4

0001: driver for the DW SPI core
0002: driver for PCI interface
0003: add DMA support

This driver has been verified on Intel Moorestown platform, with Maxim's Max3110 UART device and Option's 3G modem GTM501L, both PIO and DMA works fine, and these 2 slave devcies can work simultaneously.

Quoted 6 lines
Quoted 2 lines

0003 is RFC only, as it has dependency over DMA controller driver's acceptance to mainline.

What is "DMA controller driver"? Some other patch? What is the status of that patch and where is it?

Yes, it's another driver patch for DMA controller of Moorestown, which is developed by another guy. I don't know if he has submitted the patch to community (I guess not), though we did test the SPIC+DMAC+3G-Modem.

Thanks,
Feng

------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference

#4 lore raw
Quoted 21 lines · On Tue, 13 Oct 2009 09:36:49 +0800 Feng Tang…
Quoted 18 lines · On Tue, 13 Oct 2009 06:25:53 +0800 Andrew Morton…
Quoted 14 lines · On Mon, 12 Oct 2009 14:17:16 +0800 Feng Tang…

This patch series adds driver for Designware SPI core + PCI interface, and they are generated against kernel 2.6.32-rc4

0001: driver for the DW SPI core
0002: driver for PCI interface
0003: add DMA support

This driver has been verified on Intel Moorestown platform, with Maxim's Max3110 UART device and Option's 3G modem GTM501L, both PIO and DMA works fine, and these 2 slave devcies can work simultaneously.

0003 is RFC only, as it has dependency over DMA controller driver's acceptance to mainline.

Quoted 6 lines
Quoted 3 lines

What is "DMA controller driver"? Some other patch? What is the status of that patch and where is it?

Yes, it's another driver patch for DMA controller of Moorestown, which is developed by another guy. I don't know if he has submitted the patch to community (I guess not), though we did test the SPIC+DMAC+3G-Modem.

So am I correct in believing that your "0003: add DMA support" doesn't actually work? That it depends on some other patch which is unavailable to testers and reviewers and patch integrators?

Strange.

------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference

A message that is not in the archive (sent off-list or not yet received): 20091012185327.db69d78e.akpm-de/[email protected]

author
#6 lore raw
Quoted 7 lines · On Tue, 13 Oct 2009 09:53:27 +0800 Andrew Morton…
Quoted 7 lines
Quoted 7 lines
Quoted 3 lines

0003 is RFC only, as it has dependency over DMA controller driver's acceptance to mainline.

What is "DMA controller driver"? Some other patch? What is the status of that patch and where is it?

Quoted 8 lines
Quoted 4 lines

Yes, it's another driver patch for DMA controller of Moorestown, which is developed by another guy. I don't know if he has submitted the patch to community (I guess not), though we did test the SPIC+DMAC+3G-Modem.

So am I correct in believing that your "0003: add DMA support" doesn't actually work? That it depends on some other patch which is unavailable to testers and reviewers and patch integrators?

Yes, it's fair enough to not trust the 0003 patch and remove it from mm tree :) That's why I added a [RFC] for it.

Also many thanks for reviewing the patches, they have been not receiving any comments for a while.

Thanks,
Feng

Quoted 2 lines

Strange.

------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference