cfg80211: remove warning in deauth case
PATCH 1/1 cfg80211: remove warning in deauth case
It might be the case that __cfg80211_disconnected() has already cleaned up wdev->current_bss() for us. The old code didn't catch that situation and didn't warn needlessly.
Signed-off-by Holger Schurig <[email protected]>
---
For more info, see mail "cfg80211 / libertas: an unusual race" in the linux-wireless mailing list.
net/wireless/mlme.c +0 -6
@@ -130,7 +130,6 @@struct ieee80211_mgmt *mgmt = (struct ieee80211_mgmt *)buf;const u8 *bssid = mgmt->bssid;int i; -bool done = false;ASSERT_WDEV_LOCK (wdev);
@@ -138,7 +137,6 @@if (wdev->current_bss &&memcmp (wdev->current_bss->pub.bssid, bssid,ETH_ALEN ) ==0 ) { - done = true;cfg80211_unhold_bss (wdev->current_bss);cfg80211_put_bss (&wdev->current_bss->pub); wdev->current_bss =NULL ;
@@ -148,7 +146,6 @@cfg80211_unhold_bss (wdev->auth_bsses[i]);cfg80211_put_bss (&wdev->auth_bsses[i]->pub); wdev->auth_bsses[i] =NULL ; - done = true;break ; } if (wdev->authtry_bsses[i] &&
@@ -156,13 +153,10 @@cfg80211_unhold_bss (wdev->authtry_bsses[i]);cfg80211_put_bss (&wdev->authtry_bsses[i]->pub); wdev->authtry_bsses[i] =NULL ; - done = true;break ; } } -WARN_ON (!done); -if (wdev->sme_state ==CFG80211_SME_CONNECTED ) {u16 reason_code;bool from_ap;
Signature · 1 line
http://www.holgerschurig.de
Johannes Berg
maintainerQuoted 3 lines · Holger Schurig
It might be the case that
__cfg80211_disconnected()has already cleaned upwdev->current_bss()for us. The old code didn't catch that situation and didn't warn needlessly.
Care to explain how that can happen?
Quoted 6 lines
Signed-off-by Holger Schurig <[email protected]>---
For more info, see mail "cfg80211 / libertas: an unusual race" in the linux-wireless mailing list.
Oh ok, I suppose that explains it?
johannes