Skip to contentSkip to conversation

NCR5380: bit MR_DMA_MODE set twice in NCR5380_transfer_dma()

PATCH In review Roel Kluin 2 participants 2 messages Oct 6, 2009 – Oct 13, 2009

Subsystems (2)
SCSI Ncr 5380 SCSI drivers
lore
Share & tools
lore

Roel Kluin

author
#0 lore raw

PATCH 1/1 NCR5380: bit MR_DMA_MODE set twice in NCR5380_transfer_dma()

Besides keeping the line short, the second setting of the MR_DMA_MODE bit was removed.

Signed-off-by Roel Kluin <[email protected]>

---
Please review, maybe some other bit should be set?

drivers/scsi/NCR5380.c +3 -1
index f92da9f..5d2f148 100644
@@ -1857,7 +1857,9 @@ static int NCR5380_transfer_dma(struct Scsi_Host *instance, unsigned char *phase
 #endif
 	/* KLL May need eop and parity in 53c400 */
 	if (hostdata->flags & FLAG_NCR53C400)
-		NCR5380_write(MODE_REG, MR_BASE | MR_DMA_MODE | MR_ENABLE_PAR_CHECK | MR_ENABLE_PAR_INTR | MR_ENABLE_EOP_INTR | MR_DMA_MODE | MR_MONITOR_BSY);
+		NCR5380_write(MODE_REG, MR_BASE | MR_DMA_MODE |
+				MR_ENABLE_PAR_CHECK | MR_ENABLE_PAR_INTR |
+				MR_ENABLE_EOP_INTR | MR_MONITOR_BSY);
 	else
 		NCR5380_write(MODE_REG, MR_BASE | MR_DMA_MODE);
 #endif				/* def REAL_DMA */
#1 lore raw
Quoted 6 lines · On Tue, 06 Oct 2009 22:17:43 +0200 Roel Kluin <[email protected]> wrote:

Besides keeping the line short, the second setting of the MR_DMA_MODE bit was removed.

Signed-off-by Roel Kluin <[email protected]>

---
Please review, maybe some other bit should be set?

The only ones left are MR_BLOCK_DMA_MODE and MR_ARBITRATE.

No, I don't know if they hould have been set either. Let that sleeping dog lie, I suspect.

Quoted 15 lines
drivers/scsi/NCR5380.c +3 -1
index f92da9f..5d2f148 100644
@@ -1857,7 +1857,9 @@ static int NCR5380_transfer_dma(struct Scsi_Host *instance, unsigned char *phase
 #endif
 	/* KLL May need eop and parity in 53c400 */
 	if (hostdata->flags & FLAG_NCR53C400)
-		NCR5380_write(MODE_REG, MR_BASE | MR_DMA_MODE | MR_ENABLE_PAR_CHECK | MR_ENABLE_PAR_INTR | MR_ENABLE_EOP_INTR | MR_DMA_MODE | MR_MONITOR_BSY);
+		NCR5380_write(MODE_REG, MR_BASE | MR_DMA_MODE |
+				MR_ENABLE_PAR_CHECK | MR_ENABLE_PAR_INTR |
+				MR_ENABLE_EOP_INTR | MR_MONITOR_BSY);
 	else
 		NCR5380_write(MODE_REG, MR_BASE | MR_DMA_MODE);
 #endif				/* def REAL_DMA */