Skip to contentSkip to conversation

sctp: allow setting path_maxrxt independent of SPP_PMTUD_ENABLE

PATCH Applied Andrei Pelinescu-Onciul 2 participants 2 messages Oct 13, 2009 – Oct 14, 2009

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 sctp: allow setting path_maxrxt independent of SPP_PMTUD_ENABLE

Since draft-ietf-tsvwg-sctpsocket-15.txt, setting the SPP_MTUD_ENABLE flag when changing pathmaxrxt via the SCTP_PEER_ADDR_PARAMS setsockopt is not required any longer.

---
 net/sctp/socket.c |    7 +++----
 1 files changed, 3 insertions(+), 4 deletions(-)
net/sctp/socket.c +3 -4
index 2a21d50..1b04ade 100644
@@ -2300,11 +2300,10 @@ static int sctp_apply_peer_addr_params(struct sctp_paddrparams *params,
 		}
 	}
 
-	/* Note that unless the spp_flag is set to SPP_PMTUD_ENABLE the value
-	 * of this field is ignored.  Note also that a value of zero
-	 * indicates the current setting should be left unchanged.
+	/* Note that a value of zero indicates the current setting should be
+	   left unchanged.
 	 */
-	if ((params->spp_flags & SPP_PMTUD_ENABLE) && params->spp_pathmaxrxt) {
+	if (params->spp_pathmaxrxt) {
 		if (trans) {
 			trans->pathmaxrxt = params->spp_pathmaxrxt;
 		} else if (asoc) {
Signature · 1 line
1.6.4.3
#1 lore raw
Quoted 5 lines · Andrei Pelinescu-Onciul

Since draft-ietf-tsvwg-sctpsocket-15.txt, setting the SPP_MTUD_ENABLE flag when changing pathmaxrxt via the SCTP_PEER_ADDR_PARAMS setsockopt is not required any longer.

applied, thanks

-vlad

Quoted 24 lines
---
 net/sctp/socket.c |    7 +++----
 1 files changed, 3 insertions(+), 4 deletions(-)
net/sctp/socket.c +3 -4
index 2a21d50..1b04ade 100644
@@ -2300,11 +2300,10 @@ static int sctp_apply_peer_addr_params(struct sctp_paddrparams *params,
 		}
 	}
 
-	/* Note that unless the spp_flag is set to SPP_PMTUD_ENABLE the value
-	 * of this field is ignored.  Note also that a value of zero
-	 * indicates the current setting should be left unchanged.
+	/* Note that a value of zero indicates the current setting should be
+	   left unchanged.
 	 */
-	if ((params->spp_flags & SPP_PMTUD_ENABLE) && params->spp_pathmaxrxt) {
+	if (params->spp_pathmaxrxt) {
 		if (trans) {
 			trans->pathmaxrxt = params->spp_pathmaxrxt;
 		} else if (asoc) {