compile fails for libcpuset.c on SLES-11 s390x with ltp-full-20090930

Quoted 34 lines · Mark Ver

Trying to build ltp-full-20090930 on SLES-11. The "make all" gets the following:

...
make[5]: Entering directory `/root/ltp-full-20090930/testcases/kernel/controllers/cpuset/cpuset_lib' gcc -g -O2 -Wall -g -Wextra -I../../../../include -c -o cpuinfo.o cpuinfo.c gcc -g -O2 -Wall -g -Wextra -I../../../../include -c -o libbitmask.o libbitmask.c
gcc -g -O2 -Wall -g -Wextra -I../../../../include -c -o libcpuset.o libcpuset.c
libcpuset.c: In function ���get_mempolicy���:
libcpuset.c:3092: error: ���__NR_get_mempolicy��� undeclared (first use in this function)
libcpuset.c:3092: error: (Each undeclared identifier is reported only once libcpuset.c:3092: error: for each function it appears in.) libcpuset.c: In function ���set_mempolicy���:
libcpuset.c:3097: error: ���__NR_set_mempolicy��� undeclared (first use in this function)
make[5]: *** [libcpuset.o] Error 1
make[5]: Leaving directory `/root/ltp-full-20090930/testcases/kernel/controllers/cpuset/cpuset_lib' make[4]: *** [all] Error 2
make[4]: Leaving directory `/root/ltp-full-20090930/testcases/kernel/controllers/cpuset' make[3]: *** [all] Error 2
make[3]: Leaving directory `/root/ltp-full-20090930/testcases/kernel/controllers'
make[2]: *** [all] Error 2
make[2]: Leaving directory `/root/ltp-full-20090930/testcases/kernel' make[1]: *** [all] Error 2
make[1]: Leaving directory `/root/ltp-full-20090930/testcases'
make: *** [all] Error 2

Quoted 5 lines

As far as I can tell the architecture does not support get_mempolicy and set_mem_policy.

Here are the configure logs and stuff from the build attempt:
(See attached file: ltp-full-20090930-s390x-builderr.tar.gz)

The constant is defined for the platform, but not with the correct name:

/usr/src/linux/arch/s390/kernel/syscalls.S:NI_SYSCALL

                                 /* 269 sys_get_mempolicy */

/usr/src/linux/arch/s390/include/asm/unistd.h:/* Number 269 is reserved for new sys_get_mempolicy */ /usr/src/linux/arch/s390/include/asm/unistd.h:#define __IGNORE_get_mempolicy

This needs to be added to testcases/kernel/include/generate.sh for linux_syscall_numbers.h, or an arch specific #ifdef should be added for that test / to an autoconf test that would automatically determine whether or not your platform had a usable get_mempolicy syscall.

Hope that helps describe what needs to take place next...

This logic is covered in include/mk/testcases.mk as follows:

include $(top_srcdir)/include/mk/env_pre.mk

# For linux_syscall_numbers.h
CPPFLAGS += -I$(abs_top_builddir)/testcases/kernel/include

INSTALL_DIR := testcases/bin

LDLIBS += -lltp

There's no reason why we have to go back to the hackish Makefile's
-- we can just include testcases.mk if it's not included already (I admit, a smallhandful of testcases/... Makefile's didn't do this, but I did this on need-to-have basis).

This can be corrected by adding this logic to a common Makefile if
you like, so that way it does get picked up from one common source. This makes more sense from a design perspective.

Quoted 5 lines

Quoted 4 lines

Hmm, may be we should really move testcases/kernel/include into $(topdir)/include or better move them them to subdir in $(topdir)/include and put the generated header into $(topdir)/include, it would save us some more complexity when creating makefiles.

Quoted 7 lines

Cyril,
   Files generated at build time should _never_ live in the source directory. Otherwise tidiness becomes a serious issue, esp with source control.
   This can be corrected by adding this logic to a common Makefile if you like, so that way it does get picked up from one common source. This makes more sense from a design perspective.

Ugh, I'm tired... yes, what you proposed above was correct, but
not complete from a submake perspective, but then again making Makefiles aren't correct. I will implement the complete part this weekend.