Skip to contentSkip to conversation

kallsyms: remove deprecated print_fn_descriptor_symbol()

PATCH In review Amerigo Wang 2 participants 2 messages Oct 15, 2009 Documentation

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 kallsyms: remove deprecated print_fn_descriptor_symbol()

According to feature-removal-schedule.txt, it is the time to remove print_fn_descriptor_symbol().

And a quick grep shows that it no longer has any callers.

Cc Bjorn Helgaas <[email protected]>

---

Documentation/feature-removal-schedule.txt +0 -9
index 04e6c81..42ba573 100644
@@ -283,15 +283,6 @@ Who:	Glauber Costa <[email protected]>
 
 ---------------------------
 
-What: print_fn_descriptor_symbol()
-When: October 2009
-Why:  The %pF vsprintf format provides the same functionality in a
-      simpler way.  print_fn_descriptor_symbol() is deprecated but
-      still present to give out-of-tree modules time to change.
-Who:  Bjorn Helgaas <[email protected]>
-
----------------------------
-
 What:	/sys/o2cb symlink
 When:	January 2010
 Why:	/sys/fs/o2cb is the proper location for this information - /sys/o2cb
include/linux/kallsyms.h +0 -12
index 7922742..d8e9b3d 100644
@@ -107,18 +107,6 @@ static inline void print_symbol(const char *fmt, unsigned long addr)
 		       __builtin_extract_return_addr((void *)addr));
 }
 
-/*
- * Pretty-print a function pointer.  This function is deprecated.
- * Please use the "%pF" vsprintf format instead.
- */
-static inline void __deprecated print_fn_descriptor_symbol(const char *fmt, void *addr)
-{
-#if defined(CONFIG_IA64) || defined(CONFIG_PPC64)
-	addr = *(void **)addr;
-#endif
-	print_symbol(fmt, (unsigned long)addr);
-}
-
 static inline void print_ip_sym(unsigned long ip)
 {
 	printk("[<%p>] %pS\n", (void *) ip, (void *) ip);
Acked-by on v1 1/1
#1 lore raw
Quoted 8 lines · Amerigo Wang

According to feature-removal-schedule.txt, it is the time to remove print_fn_descriptor_symbol().

And a quick grep shows that it no longer has any callers.

Cc Bjorn Helgaas <[email protected]>

Thanks!

Quoted 45 lines

---

Documentation/feature-removal-schedule.txt +0 -9
index 04e6c81..42ba573 100644
@@ -283,15 +283,6 @@ Who:	Glauber Costa <[email protected]>
 
 ---------------------------
 
-What: print_fn_descriptor_symbol()
-When: October 2009
-Why:  The %pF vsprintf format provides the same functionality in a
-      simpler way.  print_fn_descriptor_symbol() is deprecated but
-      still present to give out-of-tree modules time to change.
-Who:  Bjorn Helgaas <[email protected]>
-
----------------------------
-
 What:	/sys/o2cb symlink
 When:	January 2010
 Why:	/sys/fs/o2cb is the proper location for this information - /sys/o2cb
include/linux/kallsyms.h +0 -12
index 7922742..d8e9b3d 100644
@@ -107,18 +107,6 @@ static inline void print_symbol(const char *fmt, unsigned long addr)
 		       __builtin_extract_return_addr((void *)addr));
 }
 
-/*
- * Pretty-print a function pointer.  This function is deprecated.
- * Please use the "%pF" vsprintf format instead.
- */
-static inline void __deprecated print_fn_descriptor_symbol(const char *fmt, void *addr)
-{
-#if defined(CONFIG_IA64) || defined(CONFIG_PPC64)
-	addr = *(void **)addr;
-#endif
-	print_symbol(fmt, (unsigned long)addr);
-}
-
 static inline void print_ip_sym(unsigned long ip)
 {
 	printk("[<%p>] %pS\n", (void *) ip, (void *) ip);