Skip to contentSkip to conversation

lcd: Fix wrong sizeof

PATCH Applied Jean Delvare 2 participants 4 messages Oct 2, 2009 – Nov 10, 2009

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 lcd: Fix wrong sizeof

Which is why I have always preferred sizeof(struct foo) over sizeof(var).

Cc Richard Purdie <[email protected]>

---
Stable team, this one applies to 2.6.31, 2.6.30 and 2.6.27.

 drivers/video/backlight/lcd.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/video/backlight/lcd.c +1 -1
@@ -56,7 +56,7 @@ static int fb_notifier_callback(struct n
 
 static int lcd_register_fb(struct lcd_device *ld)
 {
-	memset(&ld->fb_notif, 0, sizeof(&ld->fb_notif));
+	memset(&ld->fb_notif, 0, sizeof(ld->fb_notif));
 	ld->fb_notif.notifier_call = fb_notifier_callback;
 	return fb_register_client(&ld->fb_notif);
 }
Signature · 1 line
Jean Delvare
#1 lore raw
Quoted 7 lines · Jean Delvare

Which is why I have always preferred sizeof(struct foo) over sizeof(var).

Cc Richard Purdie <[email protected]>

---
Stable team, this one applies to 2.6.31, 2.6.30 and 2.6.27.

Queued in the backlight tree. I'll wait to see if any other fixes appear for backlights send to Linus in a few days.

Cheers,

Richard

Signature · 2 lines
Richard Purdie
Intel Open Source Technology Centre
#2 lore raw
Quoted 11 lines · Richard Purdie
Quoted 7 lines · Jean Delvare

Which is why I have always preferred sizeof(struct foo) over sizeof(var).

Cc Richard Purdie <[email protected]>

---
Stable team, this one applies to 2.6.31, 2.6.30 and 2.6.27.

Queued in the backlight tree. I'll wait to see if any other fixes appear for backlights send to Linus in a few days.

Please don't wait too much before sending this for to Linus.

Signature · 1 line
Jean Delvare
#3 lore raw
Quoted 10 lines · Jean Delvare
Quoted 9 lines · Richard Purdie
Quoted 7 lines · Jean Delvare

Which is why I have always preferred sizeof(struct foo) over sizeof(var).

Cc Richard Purdie <[email protected]>

---
Stable team, this one applies to 2.6.31, 2.6.30 and 2.6.27.

Quoted 4 lines
Quoted 2 lines

Queued in the backlight tree. I'll wait to see if any other fixes appear for backlights send to Linus in a few days.

Please don't wait too much before sending this for to Linus.

Richard, I still don't see this fix upstream? Would be nice to have it in 2.6.32.

Thanks,

Signature · 1 line
Jean Delvare