Cleanup: use constant
PATCH 1/1 Cleanup: use constant
Signed-off-by Niklaus Giger <[email protected]>
--- common/miiphyutil.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
common/miiphyutil.c +1 -1
@@ -299,7 +299,7 @@ int miiphy_reset (char *devname, unsigned char addr)debug ("PHY status read failed\n" );return (-1 ); } -if (miiphy_write (devname, addr,PHY_BMCR , reg |0x8000 ) !=0 ) { +if (miiphy_write (devname, addr,PHY_BMCR , reg |PHY_BMCR_RESET ) !=0 ) {debug ("PHY reset failed\n" );return (-1 ); }
Signature · 1 line
1.6.3.3
Wolfgang Denk
AppliedPATCH 1/1 Cleanup: use constant
Dear Niklaus Giger,
Quoted 10 lines · In message <[email protected]> you…
Signed-off-by Niklaus Giger <[email protected]>--- common/miiphyutil.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)common/miiphyutil.c +0
-0
common/miiphyutil.c int miiphy_reset (char *devname, unsigned char addr) · line 305
Quoted 8 lines
common/miiphyutil.c +1
-1@@ -299,7 +299,7 @@ int miiphy_reset (char *devname, unsigned char addr)debug ("PHY status read failed\n" );return (-1 ); } -if (miiphy_write (devname, addr,PHY_BMCR , reg |0x8000 ) !=0 ) { +if (miiphy_write (devname, addr,PHY_BMCR , reg |PHY_BMCR_RESET ) !=0 ) {debug ("PHY reset failed\n" );return (-1 ); }
Applied, thanks.
Ben, hope this is OK with you.
Best regards,
Wolfgang Denk
Signature · 5 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Faith may be defined briefly as an illogical belief in the occurence of the improbable. - H. L. Mencken
PATCH 1/1 Cleanup: use constant
Wolfgang,
Quoted 26 lines · Wolfgang Denk
Dear Niklaus Giger,
In message <[email protected]>
Quoted 10 lines · you
Signed-off-by Niklaus Giger <[email protected]>--- common/miiphyutil.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)common/miiphyutil.c +0
-0common/miiphyutil.c int miiphy_reset (char *devname, unsigned char addr) · line 302
Quoted 5 lines
common/miiphyutil.c +1
-1@@ -299,7 +299,7 @@ int miiphy_reset (char *devname, unsigned char addr)debug ("PHY status read failed\n" );return (-1 ); } -if (miiphy_write (devname, addr,PHY_BMCR , reg |0x8000 ) !=0 ) { + if (miiphy_write (devname, addr, PHY_BMCR, reg | PHY_BMCR_RESET) !=0) {
common/miiphyutil.c int miiphy_reset (char *devname, unsigned char addr) · line 305
Quoted 3 lines
common/miiphyutil.c +0
-0debug ("PHY reset failed\n" );return (-1 ); }Applied, thanks.
Quoted 8 lines
Ben, hope this is OK with you.
Yeah, totally OK. A more descriptive title might have been noticed.
Best regards,
Wolfgang Denk
regards,
Ben