at91: support for eco920
PATCH 1/1 at91: support for eco920
---
Hello,
I didn't find a suitable defconfig to add this machine to. It seems each machine has its own defconfig?!
Best regards
Uwe
arch/arm/mach-at91/Kconfig | 5 + arch/arm/mach-at91/Makefile | 1 + arch/arm/mach-at91/board-eco920.c | 158 +++++++++++++++++++++++++++++++++++++ 3 files changed, 164 insertions(+), 0 deletions(-) create mode 100644 arch/arm/mach-at91/board-eco920.c
arch/arm/mach-at91/Kconfig +5 -0
@@ -163,6 +163,11 @@ config MACH_CPUAT91 Select this if you are using the Eukrea Electromatique's CPUAT91 board <http://www.eukrea.com/>. +config MACH_ECO920 + bool "eco920" + help + Select this if you are using the eco920 board + endif # ----------------------------------------------------------
arch/arm/mach-at91/Makefile +1 -0
@@ -35,6 +35,7 @@ obj-$(CONFIG_MACH_PICOTUX2XX) += board-picotux200.o obj-$(CONFIG_MACH_ECBAT91) += board-ecbat91.o obj-$(CONFIG_MACH_YL9200) += board-yl-9200.o obj-$(CONFIG_MACH_CPUAT91) += board-cpuat91.o +obj-$(CONFIG_MACH_ECO920) += board-eco920.o # AT91SAM9260 board-specific support obj-$(CONFIG_MACH_AT91SAM9260EK) += board-sam9260ek.o
arch/arm/mach-at91/board-eco920.c new file +158 -0
158 lines not on this page · raw message
Signature · 1 line
1.6.4.3
PATCH 1/1 at91: support for eco920
hi,
Quoted 2 lines
Signed-off-by Uwe Kleine-K?nig <[email protected]>Cc Sascha Hauer <[email protected]>
Quoted 2 lines
I didn't find a suitable defconfig to add this machine to. ?It seems each machine has its own defconfig?!
Yes, each AT91-based board usually has its own defconfig.
Regards,
Andrew Victor
PATCH 1/1 at91: support for eco920
Hello,
Quoted 4 lines · Andrew Victor
Quoted 2 lines
Signed-off-by Uwe Kleine-K?nig <[email protected]>Cc Sascha Hauer <[email protected]>Acked-by Andrew Victor <[email protected]>
Fine, thanks.
Quoted 4 lines
Quoted 2 lines
I didn't find a suitable defconfig to add this machine to. ?It seems each machine has its own defconfig?!
Yes, each AT91-based board usually has its own defconfig.
Should I add one for that board? I'd like to have it enabled in a defconfig, but I'd prefer to simply enable it in an already existing one and so don't increase the number of defconfigs.
Thoughts?
Uwe
Signature · 2 lines
Pengutronix e.K. | Uwe Kleine-K?nig | Industrial Linux Solutions | http://www.pengutronix.de/ |
PATCH 1/1 at91: support for eco920
hi,
Quoted 6 lines
Quoted 1 line
Yes, each AT91-based board usually has its own defconfig.
Should I add one for that board? ?I'd like to have it enabled in a defconfig, but I'd prefer to simply enable it in an already existing one and so don't increase the number of defconfigs.
Thoughts?
Well, the config file says what external peripherals are available on the board (and therefore what drivers to enable). So it is kind of unique to the board.
But if you really don't want to add another defconfig (but want it included in a defconfig), you can probably add it to the AT91RM9200-DK one. (I don't think many people are still using that board, but I still always compile-test that one).
Regards,
Andrew Victor
PATCH 1/1 at91: support for eco920
CONFIG_MACH_ECO920 is enabled in at91rm9200dk_defconfig. The name is wrong, but this is better than adding another defconfig or don't get compile coverage at all.
---
Hello,
I just added CONFIG_MACH_ECO920=y, all devices but mmc are already enabled. And for my environment I need NFS and IP_PNP_DHCP. But as I only target for build coverage, it's enough this way.
Best regards
Uwe
arch/arm/configs/at91rm9200dk_defconfig | 1 + arch/arm/mach-at91/Kconfig | 5 + arch/arm/mach-at91/Makefile | 1 + arch/arm/mach-at91/board-eco920.c | 158 +++++++++++++++++++++++++++++++ 4 files changed, 165 insertions(+), 0 deletions(-) create mode 100644 arch/arm/mach-at91/board-eco920.c
arch/arm/configs/at91rm9200dk_defconfig +1 -0
@@ -120,6 +120,7 @@ CONFIG_ARCH_AT91RM9200DK=y # CONFIG_MACH_CARMEVA is not set # CONFIG_MACH_KB9200 is not set # CONFIG_MACH_ATEB9200 is not set +CONFIG_MACH_ECO920=y # # AT91RM9200 Feature Selections
arch/arm/mach-at91/Kconfig +5 -0
@@ -163,6 +163,11 @@ config MACH_CPUAT91 Select this if you are using the Eukrea Electromatique's CPUAT91 board <http://www.eukrea.com/>. +config MACH_ECO920 + bool "eco920" + help + Select this if you are using the eco920 board + endif # ----------------------------------------------------------
arch/arm/mach-at91/Makefile +1 -0
@@ -35,6 +35,7 @@ obj-$(CONFIG_MACH_PICOTUX2XX) += board-picotux200.o obj-$(CONFIG_MACH_ECBAT91) += board-ecbat91.o obj-$(CONFIG_MACH_YL9200) += board-yl-9200.o obj-$(CONFIG_MACH_CPUAT91) += board-cpuat91.o +obj-$(CONFIG_MACH_ECO920) += board-eco920.o # AT91SAM9260 board-specific support obj-$(CONFIG_MACH_AT91SAM9260EK) += board-sam9260ek.o
arch/arm/mach-at91/board-eco920.c new file +158 -0
158 lines not on this page · raw message
Signature · 1 line
1.6.5
PATCH 1/1 at91: support for eco920
Quoted 1 line · Uwe Kleine-K?nig
+#include <
mach/gpio.h>
linux/gpio.h
PATCH 1/1 at91: support for eco920
CONFIG_MACH_ECO920 is enabled in at91rm9200dk_defconfig. The name is wrong, but this is better than adding another defconfig or don't get compile coverage at all.
---
Hello,
as pointed by Russell I included linux/gpio.h instead of mach/gpio.h.
Best regards
Uwe
arch/arm/configs/at91rm9200dk_defconfig | 1 + arch/arm/mach-at91/Kconfig | 5 + arch/arm/mach-at91/Makefile | 1 + arch/arm/mach-at91/board-eco920.c | 158 +++++++++++++++++++++++++++++++ 4 files changed, 165 insertions(+), 0 deletions(-) create mode 100644 arch/arm/mach-at91/board-eco920.c
arch/arm/configs/at91rm9200dk_defconfig +1 -0
@@ -120,6 +120,7 @@ CONFIG_ARCH_AT91RM9200DK=y # CONFIG_MACH_CARMEVA is not set # CONFIG_MACH_KB9200 is not set # CONFIG_MACH_ATEB9200 is not set +CONFIG_MACH_ECO920=y # # AT91RM9200 Feature Selections
arch/arm/mach-at91/Kconfig +5 -0
@@ -163,6 +163,11 @@ config MACH_CPUAT91 Select this if you are using the Eukrea Electromatique's CPUAT91 board <http://www.eukrea.com/>. +config MACH_ECO920 + bool "eco920" + help + Select this if you are using the eco920 board + endif # ----------------------------------------------------------
arch/arm/mach-at91/Makefile +1 -0
@@ -35,6 +35,7 @@ obj-$(CONFIG_MACH_PICOTUX2XX) += board-picotux200.o obj-$(CONFIG_MACH_ECBAT91) += board-ecbat91.o obj-$(CONFIG_MACH_YL9200) += board-yl-9200.o obj-$(CONFIG_MACH_CPUAT91) += board-cpuat91.o +obj-$(CONFIG_MACH_ECO920) += board-eco920.o # AT91SAM9260 board-specific support obj-$(CONFIG_MACH_AT91SAM9260EK) += board-sam9260ek.o
arch/arm/mach-at91/board-eco920.c new file +158 -0
158 lines not on this page · raw message
Signature · 1 line
1.6.5
PATCH 1/1 at91: support for eco920
Quoted 3 lines · Uwe Kleine-K?nig
CONFIG_MACH_ECO920is enabled inat91rm9200dk_defconfig. The name is wrong, but this is better than adding another defconfig or don't get compile coverage at all./
in this case it will be better to have a generic rm9200 defconfig
Best Regards,
J.
PATCH 1/1 at91: support for eco920
Quoted 5 lines · Jean-Christophe PLAGNIOL-VILLARD
Quoted 3 lines · Uwe Kleine-K?nig
CONFIG_MACH_ECO920is enabled inat91rm9200dk_defconfig. The name is wrong, but this is better than adding another defconfig or don't get compile coverage at all./in this case it will be better to have a generic rm9200 defconfig
right, but imho this shouldn't stop my patch.
Best regards
Uwe
Signature · 2 lines
Pengutronix e.K. | Uwe Kleine-K?nig | Industrial Linux Solutions | http://www.pengutronix.de/ |
PATCH 1/1 at91: support for eco920
Quoted 7 lines · Uwe Kleine-K?nig
Quoted 5 lines · Jean-Christophe PLAGNIOL-VILLARD
Quoted 3 lines · Uwe Kleine-K?nig
CONFIG_MACH_ECO920is enabled inat91rm9200dk_defconfig. The name is wrong, but this is better than adding another defconfig or don't get compile coverage at all./in this case it will be better to have a generic rm9200 defconfig
right, but imho this shouldn't stop my patch.
rename at91rm9200dk_defconfig to at91rm9200_defconfig will make the patch better and will avoid this comment about wrong name defconfig
Best Regards,
J.
PATCH 1/1 at91: support for eco920
Quoted 10 lines · Jean-Christophe PLAGNIOL-VILLARD
Quoted 7 lines · Uwe Kleine-K?nig
Quoted 5 lines · Jean-Christophe PLAGNIOL-VILLARD
Quoted 3 lines · Uwe Kleine-K?nig
CONFIG_MACH_ECO920is enabled inat91rm9200dk_defconfig. The name is wrong, but this is better than adding another defconfig or don't get compile coverage at all./in this case it will be better to have a generic rm9200 defconfig
right, but imho this shouldn't stop my patch.
rename
at91rm9200dk_defconfigtoat91rm9200_defconfigwill make the patch better and will avoid this comment about wrong name defconfig
Hm, this is only slightly better:
linux-2.6$ grep CONFIG_ARCH_AT91RM9200=y arch/arm/configs/* | wc -l 12
Andrew, thoughts? Are you interested at all in reducing the number of defconfigs for at91?
Best regards
Uwe
Signature · 2 lines
Pengutronix e.K. | Uwe Kleine-K?nig | Industrial Linux Solutions | http://www.pengutronix.de/ |
PATCH 1/1 at91: support for eco920
Quoted 11 lines · Uwe Kleine-K?nig
Quoted 10 lines · Jean-Christophe PLAGNIOL-VILLARD
Quoted 7 lines · Uwe Kleine-K?nig
Quoted 5 lines · Jean-Christophe PLAGNIOL-VILLARD
Quoted 3 lines · Uwe Kleine-K?nig
CONFIG_MACH_ECO920is enabled inat91rm9200dk_defconfig. The name is wrong, but this is better than adding another defconfig or don't get compile coverage at all./in this case it will be better to have a generic rm9200 defconfig
right, but imho this shouldn't stop my patch.
rename
at91rm9200dk_defconfigtoat91rm9200_defconfigwill make the patch better and will avoid this comment about wrong name defconfig
Quoted 7 lines
Hm, this is only slightly better:
linux-2.6$ grep CONFIG_ARCH_AT91RM9200=y arch/arm/configs/* | wc -l 12Andrew, thoughts? Are you interested at all in reducing the number of defconfigs for at91?
Reducing the number of defconfig is not a good idea as each defconfig is optimized for each board
but have a generic one will be a good idea to be able to build a generic kernel for all rm9200 and maybe sameway for the ather at91 socs
Best Regards,
J.
PATCH 1/1 at91: support for eco920
In reply to Uwe Kleine-Könighi,
Quoted 7 lines
Hm, this is only slightly better:
? ? ? ?linux-2.6$ grep
CONFIG_ARCH_AT91RM9200=yarch/arm/configs/*| wc -l ? ? ? ?12Andrew, thoughts? ?Are you interested at all in reducing the number of defconfigs for at91?
Not really.
A specific board usually has a specific set of peripherals, so requires its own configuration file to enable those peripherals. I'm not sure how useful a "generic" defconfig would be.....
[I see from the Makefile there are 13 AT91RM9200-based boards currently supported in mainline, so there is already 1 which doesn't have a defconfig]
Regards,
Andrew Victor
PATCH 1/1 at91: support for eco920
In reply to Uwe Kleine-KönigHello,
Quoted 10 lines · Uwe Kleine-K?nig
CONFIG_MACH_ECO920is enabled inat91rm9200dk_defconfig. The name is wrong, but this is better than adding another defconfig or don't get compile coverage at all.Signed-off-by Uwe Kleine-K?nig <[email protected]>Cc Sascha Hauer <[email protected]>---
Hello,as pointed by Russell I included
linux/gpio.hinstead ofmach/gpio.h.
Is this patch OK now, should I sent to the patch system even if Jean-Christophe PLAGNIOL-VILLARD pointed out the defconfig stuff isn't optimal?
Best regards
Uwe
Signature · 2 lines
Pengutronix e.K. | Uwe Kleine-K?nig | Industrial Linux Solutions | http://www.pengutronix.de/ |
PATCH 1/1 at91: support for eco920
hi Uwe Kleine-K?nig,
Quoted 3 lines
Is this patch OK now, should I sent to the patch system even if Jean-Christophe PLAGNIOL-VILLARD pointed out the defconfig stuff isn't optimal?
Fine with me.
Regards,
Andrew Victor
PATCH 1/1 at91: support for eco920
Hello,
Quoted 6 lines · Andrew Victor
Quoted 3 lines
Is this patch OK now, should I sent to the patch system even if Jean-Christophe PLAGNIOL-VILLARD pointed out the defconfig stuff isn't optimal?
Fine with me.
Acked-by Andrew Victor <[email protected]>
Russell, is this enough to send it to the patch system?
Best regards and thanks
Uwe
Signature · 2 lines
Pengutronix e.K. | Uwe Kleine-K?nig | Industrial Linux Solutions | http://www.pengutronix.de/ |
PATCH 1/1 at91: support for eco920
Quoted 10 lines · Uwe Kleine-K?nig
Hello,
Quoted 6 lines · Andrew Victor
Quoted 3 lines
Is this patch OK now, should I sent to the patch system even if Jean-Christophe PLAGNIOL-VILLARD pointed out the defconfig stuff isn't optimal?
Fine with me.
Acked-by Andrew Victor <[email protected]>Russell, is this enough to send it to the patch system?
If everyone else agrees, yes.