Skip to contentSkip to conversation

multipath-tools: Fix dry runs to identify renames

PATCH In review Benjamin Marzinski 2 participants 2 messages Oct 20, 2009 Device mapper

lore
Share & tools
lore

Benjamin Marzinski

author maintainer
#0 lore raw

PATCH 1/1 multipath-tools: Fix dry runs to identify renames

multipath didn't correctly identify renames on a dry run. This fixes it.

---
 libmultipath/configure.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
libmultipath/configure.c +1 -1
Index: multipath-tools-091013/libmultipath/configure.c
===================================================================
@@ -151,7 +151,7 @@ select_action (struct multipath * mpp, v
 	if (!cmpp) {
 		cmpp = find_mp_by_wwid(curmp, mpp->wwid);
 
-		if (cmpp && !conf->dry_run) {
+		if (cmpp) {
 			condlog(2, "%s: rename %s to %s", mpp->wwid,
 				cmpp->alias, mpp->alias);
 			strncpy(mpp->alias_old, cmpp->alias, WWID_SIZE);
#1 lore raw

Hi Ben,
this one was already in (sep 28th).
The 3 others are now merged.

Thanks.

Quoted 25 lines · Benjamin Marzinski

multipath didn't correctly identify renames on a dry run. This fixes it.

---
 libmultipath/configure.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: multipath-tools-091013/libmultipath/configure.c
===================================================================

libmultipath/configure.c +1 -2
@@ -151,7 +151,7 @@ select_action (struct multipath * mpp, v
 	if (!cmpp) {
 		cmpp = find_mp_by_wwid(curmp, mpp->wwid);
 
-		if (cmpp && !conf->dry_run) {
+		if (cmpp) {
 			condlog(2, "%s: rename %s to %s", mpp->wwid,
 				cmpp->alias, mpp->alias);
 			strncpy(mpp->alias_old, cmpp->alias, WWID_SIZE);
 
--

dm-devel mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/dm-devel