Skip to contentSkip to conversation

extras/modem-modeswitch: fix eject of fake CD-ROMs

PATCH In review Herton Ronaldo Krzesinski 3 participants 4 messages Oct 20, 2009 – Oct 21, 2009

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 extras/modem-modeswitch: fix eject of fake CD-ROMs

Fix the udev rule so we make sure it is called when the block device is really added, so eject is called with proper block device for ZTE modems.

---
 extras/modem-modeswitch/61-mobile-action.rules |   11 ++++++++---
 1 files changed, 8 insertions(+), 3 deletions(-)

please CC me if replying, I'm not subscribed to linux-hotplug

extras/modem-modeswitch/61-mobile-action.rules +8 -3
index 9116b25..9d5ca02 100644
@@ -1,4 +1,4 @@
-ACTION!="add", GOTO="mobile_action_end"
+ACTION!="add", GOTO="zerocd_eject_end"
 
 SUBSYSTEM="usb", ATTR{bDeviceClass}="00|ff", ATTR{bDeviceSubClass}="00|ff", ENV{DEVTYPE}="usb_device", GOTO="mobile_action_switch"
 GOTO="mobile_action_end"
@@ -6,9 +6,14 @@ GOTO="mobile_action_end"
 LABEL="mobile_action_switch"
 ATTRS{idVendor}="0df7", ATTRS{idProduct}="0800", RUN+="modem-modeswitch -v 0x%s{idVendor} -p 0x%s{idProduct} -t mobile-action-8280p"
 
+LABEL="mobile_action_end"
+
 # modem-modeswitch does not work with these devices, the fake CD-ROM needs to be ejected
 
-# ZTE MF6xx
+SUBSYSTEM="block", ENV{ID_BUS}="usb", ENV{ID_USB_DRIVER}="usb-storage", ENV{ID_CDROM}="1", GOTO="zerocd_eject"
+GOTO="zerocd_eject_end"
+
+LABEL="zerocd_eject"
 ATTRS{idVendor}="19d2", ATTRS{idProduct}="2000", RUN+="/usr/bin/eject %k"
 
-LABEL="mobile_action_end"
+LABEL="zerocd_eject_end"
Signature · 1 line
1.6.4.4
#1 lore raw

Hello Herton,

Herton Ronaldo Krzesinski [2009-10-20 20:00 -0200]:

Quoted 3 lines

Fix the udev rule so we make sure it is called when the block device is really added, so eject is called with proper block device for ZTE modems.

Heh, nice timing. As it happened, I just proposed fix for this an hour ago in https://launchpad.net/bugs/281335 .

Same idea, but a bit simpler structure:
http://launchpadlibrarian.net/34075603/61-mobile-action.rules

Does this work for you as well?

Thanks,

Martin

Signature · 2 lines
Martin Pitt                        | http://www.piware.de
Ubuntu Developer (www.ubuntu.com)  | Debian Developer  (www.debian.org)
#2 lore raw
In reply to Herton Ronaldo Krzesinski

Em Ter 20 Out 2009, às 20:14:03, Martin Pitt escreveu:

Quoted 7 lines

Hello Herton,

Herton Ronaldo Krzesinski [2009-10-20 20:00 -0200]:

Quoted 3 lines

Fix the udev rule so we make sure it is called when the block device is really added, so eject is called with proper block device for ZTE modems.

Quoted 7 lines

Heh, nice timing. As it happened, I just proposed fix for this an hour ago in https://launchpad.net/bugs/281335 .

Same idea, but a bit simpler structure:
http://launchpadlibrarian.net/34075603/61-mobile-action.rules

Does this work for you as well?

Yes should work too, thanks. Unfortunately I'm not with the zte modem here anymore, had to give back it to the owner, so can't test it again.

Quoted 5 lines

Thanks,

Martin

--
[]'s
Herton