Skip to contentSkip to conversation

m68k allow ioremapping top of memory

PATCH In review Philippe De Muyter 2 participants 3 messages Oct 22, 2009 – Dec 22, 2009 m68k architecture

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 m68k allow ioremapping top of memory

Hi all,

The test in __ioremap to reject memory ranges crossing the 0 boundary rejects also memory ranges at the end of the memory. Fix that.

arch/m68k/mm/kmap.c +1 -1
@@ -116,7 +115,7 @@ void __iomem *__ioremap(unsigned long ph
 	/*
 	 * Don't allow mappings that wrap..
 	 */
-	if (!size || size > physaddr + size)
+	if (!size || physaddr > (unsigned long)(-size))
 		return NULL;
 
 #ifdef CONFIG_AMIGA
#1 lore raw

Re: [PATCH] cleanup remove obsolete comment about map_chunk

Hi all,

Remove the comments referring to a function map_chunk that no longer exists.

arch/h8300/mm/memory.c +2 -2
@@ -44,8 +44,8 @@ void cache_push_v (unsigned long vaddr, 
 {
 }
 
-/* Map some physical address range into the kernel address space. The
- * code is copied and adapted from map_chunk().
+/*
+ * Map some physical address range into the kernel address space.
  */
 
 unsigned long kernel_map(unsigned long paddr, unsigned long size,
arch/m68k/mm/kmap.c +1 -2
@@ -99,8 +99,7 @@ static inline void free_io_area(void *ad
 #endif
 
 /*
- * Map some physical address range into the kernel address space. The
- * code is copied and adapted from map_chunk().
+ * Map some physical address range into the kernel address space.
  */
 /* Rewritten by Andreas Schwab to remove all races. */
 
arch/m68knommu/mm/memory.c +0 -1
@@ -24,7 +24,6 @@
 
 /*
  * Map some physical address range into the kernel address space.
- * The code is copied and adapted from map_chunk().
  */
 
 unsigned long kernel_map(unsigned long paddr, unsigned long size,
#2 lore raw

Re: [PATCH] cleanup remove obsolete comment about map_chunk

Quoted 1 line · Philippe De Muyter

Remove the comments referring to a function map_chunk that no longer exists.

Thanks!

I'll take it through the m68k tree. The h8300 case was copied from m68k anyway.

Quoted 47 lines
arch/h8300/mm/memory.c +2 -2
@@ -44,8 +44,8 @@ void cache_push_v (unsigned long vaddr,
  {
  }
 
-/* Map some physical address range into the kernel address space. The
- * code is copied and adapted from map_chunk().
+/*
+ * Map some physical address range into the kernel address space.
  */
 
  unsigned long kernel_map(unsigned long paddr, unsigned long size,
arch/m68k/mm/kmap.c +1 -2
@@ -99,8 +99,7 @@ static inline void free_io_area(void *ad
  #endif
 
  /*
- * Map some physical address range into the kernel address space. The
- * code is copied and adapted from map_chunk().
+ * Map some physical address range into the kernel address space.
  */
  /* Rewritten by Andreas Schwab to remove all races. */
 
arch/m68knommu/mm/memory.c +0 -2
@@ -24,7 +24,6 @@
 
  /*
  * Map some physical address range into the kernel address space.
- * The code is copied and adapted from map_chunk().
  */
 
  unsigned long kernel_map(unsigned long paddr, unsigned long size,
--

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Signature · 10 lines
Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds