Fix SDP handling when the SDP record is modified on remote device.
PATCH 1/1 Fix SDP handling when the SDP record is modified on remote device.
From: Jaikumar Ganesh <[email protected]>
We invalidate the in-memory SDP records list only when a profile is added or removed. So when a SDP record attribute like the rfcomm channel number is modified on the remote device, we will miss the update.
--- src/device.c | 10 +++++----- 1 files changed, 5 insertions(+), 5 deletions(-)
src/device.c +5 -5
@@ -1313,11 +1313,6 @@ static void search_cb(sdp_list_t *recs, int err, gpointer user_data)update_services (req, recs); -if (!req->profiles_added && !req->profiles_removed) { -debug ("%s: No service update" , device->path); - goto proceed; - } -if (device->tmp_records && req->records) {sdp_list_free (device->tmp_records, (sdp_free_func_t ) sdp_record_free);
@@ -1325,6 +1320,11 @@ static void search_cb(sdp_list_t *recs, int err, gpointer user_data) req->records =NULL ; } +if (!req->profiles_added && !req->profiles_removed) { +debug ("%s: No service update" , device->path); + goto proceed; + } +/* Probe matching drivers for services added */ if (req->profiles_added)device_probe_drivers (device, req->profiles_added);
Signature · 1 line
1.6.2.3
Hi Jaikumar,
Quoted 6 lines · On Thu, Oct 22, 2009, [email protected] wrote:
We invalidate the in-memory SDP records list only when a profile is added or removed. So when a SDP record attribute like the rfcomm channel number is modified on the remote device, we will miss the update.
--- src/device.c | 10 +++++----- 1 files changed, 5 insertions(+), 5 deletions(-)
The patch makes sense and has been pushed upstream. Thanks. However, I'm not aware of any code in the current bluez tree that would actually try to use the cached RFCOMM channels. E.g. the serial plugin as well as the HFP/HSP implementation always do explicit lookups over SDP before attempting to connect. So most likely there's no immediate benefit of the patch but it's still good to have it in case some future code does rely more heavily on the SDP record cache.
Johan