Skip to contentSkip to conversation

e1000e: reset the PHY on 82577/82578 when going to Sx

PATCH Applied Jeff Kirsher 2 participants 2 messages Oct 23, 2009

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 e1000e: reset the PHY on 82577/82578 when going to Sx

From: Bruce Allan <[email protected]>

The PHY on 82577/82578 parts needs a soft reset when transitioning to Sx state in order for the PHY write which disables gigabit speed to take effect. Gigabit speed must be disabled in order for the PHY writes to registers on page 800 (the wakeup control registers) to work as expected otherwise the system might not wake via WoL.

---

 drivers/net/e1000e/ich8lan.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)
drivers/net/e1000e/ich8lan.c +1 -2
index 99df2ab..aa0ab0e 100644
@@ -2843,9 +2843,8 @@ void e1000e_disable_gig_wol_ich8lan(struct e1000_hw *hw)
 		            E1000_PHY_CTRL_GBE_DISABLE;
 		ew32(PHY_CTRL, phy_ctrl);
 
-		/* Workaround SWFLAG unexpectedly set during S0->Sx */
 		if (hw->mac.type == e1000_pchlan)
-			udelay(500);
+			e1000_phy_hw_reset_ich8lan(hw);
 	default:
 		break;
 	}
maintainer Applied
#1 lore raw

From: Jeff Kirsher <[email protected]>
Date: Thu, 22 Oct 2009 19:53:00 -0700

Quoted 10 lines

From: Bruce Allan <[email protected]>

The PHY on 82577/82578 parts needs a soft reset when transitioning to Sx state in order for the PHY write which disables gigabit speed to take effect. Gigabit speed must be disabled in order for the PHY writes to registers on page 800 (the wakeup control registers) to work as expected otherwise the system might not wake via WoL.

Applied.