Skip to contentSkip to conversation

Shadow dirty-VRAM: avoid multiple remove_all_mappings calls.

PATCH New Tim Deegan 1 participant 1 message Oct 23, 2009

lore
Share & tools
lore

Tim Deegan

author
#0 lore raw

PATCH 1/1 Shadow dirty-VRAM: avoid multiple remove_all_mappings calls.

sh_remove_all_mappings() will walk roughly half of the shadow L1 tables for each MFN it's called with; calling it for every MFN in a guest's framebuffer can be _very_ expensive, especially with the shadow lock held across the whole operation. Avoid that by just blowing away all the shadows.

xen/arch/x86/mm/shadow/common.c +3 -6
diff -r 8ca4e32583b6 xen/arch/x86/mm/shadow/common.c
@@ -3637,12 +3637,9 @@
      * no need to be careful. */
     if ( !dirty_vram )
     {
-        /* Just recount from start. */
-        for ( i = begin_pfn; i < end_pfn; i++ ) {
-            mfn_t mfn = gfn_to_mfn(d, i, &t);
-            if (mfn_x(mfn) != INVALID_MFN)
-                flush_tlb |= sh_remove_all_mappings(d->vcpu[0], mfn);
-        }
+        /* Throw away all the shadows rather than walking through them 
+         * up to nr times getting rid of mappings of each pfn */
+        shadow_blow_tables(d);
 
         gdprintk(XENLOG_INFO, "tracking VRAM %lx - %lx\n", begin_pfn, end_pfn);
 

_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xensource.com/xen-devel