Skip to contentSkip to conversation

imx/gpio: Use handle_level_irq

PATCH New Uwe Kleine-König 3 participants 6 messages Oct 19, 2009 – Nov 1, 2009

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 imx/gpio: Use handle_level_irq

According to Russell King handle_edge_irq is only useful for "edge-based inputs where the controller does not remember transitions with the input masked."

So using handle_edge_irq unconditionally for both edge and level irqs is wrong. Testing showed that the controller does remember transitions while the interrupt is masked. So use handle_level_irq unconditionally.

Cc Russell King <[email protected]>
Cc Sascha Hauer <[email protected]>
---
 arch/arm/plat-mxc/gpio.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
arch/arm/plat-mxc/gpio.c +1 -1
index cfc4a8b..d65ebe3 100644
@@ -282,7 +282,7 @@ int __init mxc_gpio_init(struct mxc_gpio_port *port, int cnt)
 		for (j = port[i].virtual_irq_start;
 			j < port[i].virtual_irq_start + 32; j++) {
 			set_irq_chip(j, &gpio_irq_chip);
-			set_irq_handler(j, handle_edge_irq);
+			set_irq_handler(j, handle_level_irq);
 			set_irq_flags(j, IRQF_VALID);
 		}
 
Signature · 1 line
1.6.5
maintainer
#1 lore raw

PATCH 1/1 imx/gpio: Use handle_level_irq

Quoted 7 lines · Uwe Kleine-K?nig

According to Russell King handle_edge_irq is only useful for "edge-based inputs where the controller does not remember transitions with the input masked."

So using handle_edge_irq unconditionally for both edge and level irqs is wrong. Testing showed that the controller does remember transitions while the interrupt is masked. So use handle_level_irq unconditionally.

As this fixes only rt kernels and we have no reports that something is not working on non rt kernels I suggest putting this into the next merge window.

Sascha

Quoted 25 lines
Cc Russell King <[email protected]>
Cc Sascha Hauer <[email protected]>
---
 arch/arm/plat-mxc/gpio.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
arch/arm/plat-mxc/gpio.c +1 -1
index cfc4a8b..d65ebe3 100644
@@ -282,7 +282,7 @@ int __init mxc_gpio_init(struct mxc_gpio_port *port, int cnt)
 		for (j = port[i].virtual_irq_start;
 			j < port[i].virtual_irq_start + 32; j++) {
 			set_irq_chip(j, &gpio_irq_chip);
-			set_irq_handler(j, handle_edge_irq);
+			set_irq_handler(j, handle_level_irq);
 			set_irq_flags(j, IRQF_VALID);
 		}
 
Signature · 1 line
1.6.5
Signature · 4 lines
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
#2 lore raw

PATCH 1/1 imx/gpio: Use handle_level_irq

Hello Sascha,

Quoted 5 lines · Sascha Hauer
Quoted 4 lines · Uwe Kleine-K?nig

According to Russell King handle_edge_irq is only useful for "edge-based inputs where the controller does not remember transitions with the input masked."

Quoted 7 lines
Quoted 3 lines

So using handle_edge_irq unconditionally for both edge and level irqs is wrong. Testing showed that the controller does remember transitions while the interrupt is masked. So use handle_level_irq unconditionally.

As this fixes only rt kernels and we have no reports that something is not working on non rt kernels I suggest putting this into the next merge window.

The PMIC on pcm038 doesn't work anymore with handle_edge_irq since I switched to using threaded irqs in the driver. But as this won't hit mainline before the next merge window that is fine for me, too.

Best regards
Uwe

Signature · 2 lines
Pengutronix e.K.                              | Uwe Kleine-K?nig            |
Industrial Linux Solutions                    | http://www.pengutronix.de/  |
#3 lore raw

PATCH 1/1 imx/gpio: Use handle_level_irq

2009/10/21 Uwe Kleine-K?nig <[email protected]>:

Quoted 22 lines

Hello Sascha,

Quoted 5 lines · Sascha Hauer
Quoted 4 lines · Uwe Kleine-K?nig

According to Russell King handle_edge_irq is only useful for "edge-based inputs where the controller does not remember transitions with the input masked."

Quoted 7 lines
Quoted 3 lines

So using handle_edge_irq unconditionally for both edge and level irqs is wrong. ?Testing showed that the controller does remember transitions while the interrupt is masked. ?So use handle_level_irq unconditionally.

As this fixes only rt kernels and we have no reports that something is not working on non rt kernels I suggest putting this into the next merge window.

The PMIC on pcm038 doesn't work anymore with handle_edge_irq since I switched to using threaded irqs in the driver. ?But as this won't hit mainline before the next merge window that is fine for me, too.

Best regards
Uwe

Quoted 9 lines

--

Pengutronix e.K. ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?| Uwe Kleine-K?nig ? ? ? ? ? ?|
Industrial Linux Solutions ? ? ? ? ? ? ? ? ? ?| http://www.pengutronix.de/ ?|

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

handle_level_irq may lost edge irq request. The controller won't change ISR when irq's masked.
Why not decide to use handle_level_irq or handle_edge_irq in gpio_set_irq_type?

Thanks
Richard

#4 lore raw

PATCH 1/1 imx/gpio: Use handle_level_irq

Hello,

Quoted 16 lines · Richard Zhao

2009/10/21 Uwe Kleine-K?nig <[email protected]>:

Quoted 15 lines

Hello Sascha,

Quoted 12 lines · Sascha Hauer
Quoted 7 lines · Uwe Kleine-K?nig

According to Russell King handle_edge_irq is only useful for "edge-based inputs where the controller does not remember transitions with the input masked."

So using handle_edge_irq unconditionally for both edge and level irqs is wrong. ?Testing showed that the controller does remember transitions while the interrupt is masked. ?So use handle_level_irq unconditionally.

As this fixes only rt kernels and we have no reports that something is not working on non rt kernels I suggest putting this into the next merge window.

Quoted 7 lines
Quoted 3 lines

The PMIC on pcm038 doesn't work anymore with handle_edge_irq since I switched to using threaded irqs in the driver. ?But as this won't hit mainline before the next merge window that is fine for me, too.

handle_level_irq may lost edge irq request. The controller won't change ISR when irq's masked.
Why not decide to use handle_level_irq or handle_edge_irq in gpio_set_irq_type?

Have you read the commit log? If yes, do you know a test case where handle_level_irq fails to detect an edge irq when masked?

I did on a Phytec pcm038:

	set_irq_type(TRIGGER_RISING)
	mask(irq=119)
	provoke a rising edge on gpio55
	unmask(irq=119)

and after that the irq handler was entered.

Best regards
Uwe

Signature · 2 lines
Pengutronix e.K.                              | Uwe Kleine-K?nig            |
Industrial Linux Solutions                    | http://www.pengutronix.de/  |
#5 lore raw

PATCH 1/1 imx/gpio: Use handle_level_irq

In reply to Sascha Hauer
Quoted 5 lines · Sascha Hauer
Quoted 4 lines · Uwe Kleine-K?nig

According to Russell King handle_edge_irq is only useful for "edge-based inputs where the controller does not remember transitions with the input masked."

Quoted 7 lines
Quoted 3 lines

So using handle_edge_irq unconditionally for both edge and level irqs is wrong. Testing showed that the controller does remember transitions while the interrupt is masked. So use handle_level_irq unconditionally.

As this fixes only rt kernels and we have no reports that something is not working on non rt kernels I suggest putting this into the next merge window.

I didn't find my patch in your imx tree. Assuming I don't have overlooked it, what is stopping you?

Best regards
Uwe

Signature · 2 lines
Pengutronix e.K.                              | Uwe Kleine-K?nig            |
Industrial Linux Solutions                    | http://www.pengutronix.de/  |