Skip to contentSkip to conversation

sh: fix kexec by removing check for old kexec-tools

PATCH In review Magnus Damm 2 participants 2 messages Oct 26, 2009 SuperH

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 sh: fix kexec by removing check for old kexec-tools

From: Magnus Damm <[email protected]>

This unbreaks kexec support. Without this fix all cases of kexec fails since __pa() does not behave like PHYSADDR(). The downside is that we also kill the code blocking users running old kexec-tools.

---

 arch/sh/kernel/machine_kexec.c |    6 ------
 1 file changed, 6 deletions(-)
arch/sh/kernel/machine_kexec.c +0 -6
@@ -46,12 +46,6 @@ void machine_crash_shutdown(struct pt_re
  */
 int machine_kexec_prepare(struct kimage *image)
 {
-	/* older versions of kexec-tools are passing
-	 * the zImage entry point as a virtual address.
-	 */
-	if (image->start != __pa(image->start))
-		return -EINVAL; /* upgrade your kexec-tools */
-
 	return 0;
 }
 
#1 lore raw
Quoted 4 lines · Magnus Damm

This unbreaks kexec support. Without this fix all cases of kexec fails since __pa() does not behave like PHYSADDR(). The downside is that we also kill the code blocking users running old kexec-tools.

Quoted 2 lines · Magnus Damm

Add HWBLK_ETHER to the sh_eth platform device to allow Runtime PM of the ethernet hardware.

Quoted 3 lines · Magnus Damm

Convert the ecovec24 board code to pass the mac address to the sh_eth driver using platform data. Also, remove the static clock to allow Runtime PM.

Applied for 2.6.33, thanks.