Skip to contentSkip to conversation

sched: Use root_task_group_empty only with FAIR_GROUP_SCHED

PATCH In review Cyrill Gorcunov 1 participant 2 messages Oct 26, 2009 – Nov 8, 2009

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 sched: Use root_task_group_empty only with FAIR_GROUP_SCHED

Please review. Perhaps there some usage planned in future?

-- Cyrill
---
root_task_group_empty is used only with
FAIR_GROUP_SCHED so if we use other scheduler
we get

kernel/sched.c:314: warning: ‘root_task_group_empty’ defined but not used

So move CONFIG_FAIR_GROUP_SCHED up that it cover
root_task_group_empty.

---
 kernel/sched.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
kernel/sched.c +2 -1
Index: linux-2.6.git/kernel/sched.c
=====================================================================
@@ -309,6 +309,8 @@ static DEFINE_PER_CPU_SHARED_ALIGNED(str
  */
 static DEFINE_SPINLOCK(task_group_lock);
 
+#ifdef CONFIG_FAIR_GROUP_SCHED
+
 #ifdef CONFIG_SMP
 static int root_task_group_empty(void)
 {
@@ -316,7 +318,6 @@ static int root_task_group_empty(void)
 }
 #endif
 
-#ifdef CONFIG_FAIR_GROUP_SCHED
 #ifdef CONFIG_USER_SCHED
 # define INIT_TASK_GROUP_LOAD	(2*NICE_0_LOAD)
 #else /* !CONFIG_USER_SCHED */
#1 lore raw
Commit-ID:  e9036b36eed4d3cdb33fa9cbcdd9888ae516889f
Gitweb:     http://git.kernel.org/tip/e9036b36eed4d3cdb33fa9cbcdd9888ae516889f
Author:     Cyrill Gorcunov <[email protected]>
AuthorDate: Mon, 26 Oct 2009 22:24:14 +0300
Committer:  Ingo Molnar <[email protected]>
CommitDate: Sun, 8 Nov 2009 13:15:48 +0100

sched: Use root_task_group_empty only with FAIR_GROUP_SCHED

root_task_group_empty is used only with FAIR_GROUP_SCHED so if we use other scheduler options we get:

kernel/sched.c:314: warning: 'root_task_group_empty' defined but not used

So move CONFIG_FAIR_GROUP_SCHED up that it covers root_task_group_empty().

LKML-Reference: <20091026192414.GB5321@lenovo>

---
 kernel/sched.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
kernel/sched.c +2 -1
index 7d7d5fc..3c11ae0 100644
@@ -309,6 +309,8 @@ static DEFINE_PER_CPU_SHARED_ALIGNED(struct rt_rq, init_rt_rq);
  */
 static DEFINE_SPINLOCK(task_group_lock);
 
+#ifdef CONFIG_FAIR_GROUP_SCHED
+
 #ifdef CONFIG_SMP
 static int root_task_group_empty(void)
 {
@@ -316,7 +318,6 @@ static int root_task_group_empty(void)
 }
 #endif
 
-#ifdef CONFIG_FAIR_GROUP_SCHED
 #ifdef CONFIG_USER_SCHED
 # define INIT_TASK_GROUP_LOAD	(2*NICE_0_LOAD)
 #else /* !CONFIG_USER_SCHED */