2.6.32-rc5 bug in Palm Tungsten C keyboard
Subsystems (3)
PATCH 1/1 2.6.32-rc5 bug in Palm Tungsten C keyboard
Palm Tungsten C keyboard structure has swapped
rows/cols gpio structures and does not work.
This patch fixes it.
arch/arm/mach-pxa/palmtc.c +4 -4
@@ -292,10 +292,10 @@ const static unsigned int palmtc_keypad_static struct matrix_keypad_platform_data palmtc_keypad_platform_data = { .keymap_data = &palmtc_keymap_data, - .col_gpios = palmtc_keypad_row_gpios, - .num_col_gpios =12 , - .row_gpios = palmtc_keypad_col_gpios, - .num_row_gpios =4 , + .row_gpios = palmtc_keypad_row_gpios, + .num_row_gpios =ARRAY_SIZE (palmtc_keypad_row_gpios), + .col_gpios = palmtc_keypad_col_gpios, + .num_col_gpios =ARRAY_SIZE (palmtc_keypad_col_gpios), .active_low =1 , .debounce_ms =20 ,
Signature · 5 lines
Elen sila lumenn' omentielvo Ondrej 'SanTiago' Zajicek (email: [email protected]) OpenPGP encrypted e-mails preferred (KeyID 0x11DEADC3, wwwkeys.pgp.net) "To err is human -- to blame it on a computer is even more so."
Quoted 5 lines · Ondrej Zajicek
Palm Tungsten C keyboard structure has swapped
rows/cols gpio structures and does not work.
This patch fixes it.Signed-off-by Ondrej Zajicek <[email protected]>
This fix looks obvious to me. Applied to 'fix'.
Quoted 28 lines
diff -uprN
linux-2.6.32-rc5-old/arch/arm/mach-pxa/palmtc.clinux-2.6.32-rc5/arch/arm/mach-pxa/palmtc.carch/arm/mach-pxa/palmtc.c 2009-10-26 20:56:44.000000000 +0100 renamed from arch/arm/mach-pxa/palmtc.c 2009-10-16 02:41:50.000000000 +0200 +4
-5@@ -292,10 +292,10 @@ const static unsigned int palmtc_keypad_ static struct matrix_keypad_platform_data palmtc_keypad_platform_data = { .keymap_data = &palmtc_keymap_data, - .col_gpios = palmtc_keypad_row_gpios, - .num_col_gpios = 12, - .row_gpios = palmtc_keypad_col_gpios, - .num_row_gpios = 4, + .row_gpios = palmtc_keypad_row_gpios, + .num_row_gpios = ARRAY_SIZE(palmtc_keypad_row_gpios), + .col_gpios = palmtc_keypad_col_gpios, + .num_col_gpios = ARRAY_SIZE(palmtc_keypad_col_gpios), .active_low = 1, .debounce_ms = 20, --Elen sila lumenn' omentielvo
Ondrej 'SanTiago' Zajicek (email: [email protected]) OpenPGP encrypted e-mails preferred (KeyID
0x11DEADC3, wwwkeys.pgp.net) "To err is human -- to blame it on a computer is even more so."
Dne Út 27. října 2009 08:43:44 Eric Miao napsal(a):
Quoted 1 line
On Tue, Oct 27, 2009 at 6:59 AM, Ondrej Zajicek <[email protected]>
Quoted 7 lines · wrote:
Quoted 5 lines
Palm Tungsten C keyboard structure has swapped
rows/cols gpio structures and does not work.
This patch fixes it.Signed-off-by Ondrej Zajicek <[email protected]>This fix looks obvious to me. Applied to 'fix'.
Just wondering ... you checked the GPIO directions, right ? I mean, it works in both directions, it just works worse the other one. I can't really check now.
Also, it'll be possibly good to use the following emails for pxa patches:
Eric Miao <[email protected]>
Linux-ARM-Kernel <[email protected]>
Marek Vasut <[email protected]>
Those should be enough.
Cheers!
Quoted 30 lines
Quoted 29 lines
diff -uprN
linux-2.6.32-rc5-old/arch/arm/mach-pxa/palmtc.clinux-2.6.32-rc5/arch/arm/mach-pxa/palmtc.c---linux-2.6.32-rc5-old/arch/arm/mach-pxa/palmtc.c2009-10-16
02:41:50.000000000 +0200 +++linux-2.6.32-rc5/arch/arm/mach-pxa/palmtc.c2009-10-26 20:56:44.000000000 +0100 @@ -292,10 +292,10 @@ const staticunsigned int
palmtc_keypad_static struct
matrix_keypad_platform_datapalmtc_keypad_platform_data=
{ .keymap_data =&palmtc_keymap_data,arch/arm/mach-pxa/palmtc.c +4
-5- .col_gpios = palmtc_keypad_row_gpios, - .num_col_gpios = 12, - .row_gpios = palmtc_keypad_col_gpios, - .num_row_gpios = 4, + .row_gpios = palmtc_keypad_row_gpios, + .num_row_gpios = ARRAY_SIZE(palmtc_keypad_row_gpios), + .col_gpios = palmtc_keypad_col_gpios, + .num_col_gpios = ARRAY_SIZE(palmtc_keypad_col_gpios), .active_low = 1, .debounce_ms = 20, --Elen sila lumenn' omentielvo
Ondrej 'SanTiago' Zajicek (email: [email protected]) OpenPGP encrypted e-mails preferred (KeyID
0x11DEADC3, wwwkeys.pgp.net) "To err is human -- to blame it on a computer is even more so."
Quoted 7 lines · Marek Vasut
Dne Út 27. října 2009 08:43:44 Eric Miao napsal(a):
Quoted 1 line
On Tue, Oct 27, 2009 at 6:59 AM, Ondrej Zajicek <[email protected]>
Quoted 4 lines · wrote:
Quoted 4 lines
Palm Tungsten C keyboard structure has swapped
rows/cols gpio structures and does not work.
This patch fixes it.
Quoted 7 lines
Quoted 3 lines
Quoted 1 line
Signed-off-by Ondrej Zajicek <[email protected]>This fix looks obvious to me. Applied to 'fix'.
Just wondering ... you checked the GPIO directions, right ? I mean, it works in both directions, it just works worse the other one. I can't really check now.
It would be good if you can have it checked and give your Ack please.
Quoted 8 lines
Also, it'll be possibly good to use the following emails for pxa patches:
Eric Miao <[email protected]>
Linux-ARM-Kernel <[email protected]>
Marek Vasut <[email protected]>Those should be enough.
Cheers!