Skip to contentSkip to conversation

ALSA: ASoC: CS4270: export de-emphasis filter as ALSA control

PATCH In review Daniel Mack 3 participants 3 messages Oct 29, 2009

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ALSA: ASoC: CS4270: export de-emphasis filter as ALSA control

The CS4270 codec features an de-emphasis filter for compensation of audio material filtered by an 50/15 uS algorithm. Not sure whether we should always enable it for 44100Hz sampling frequency, but it should at least be configurable by the user.

Cc Timur Tabi <[email protected]>
Cc Mark Brown <[email protected]>
---
 sound/soc/codecs/cs4270.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
sound/soc/codecs/cs4270.c +1 -0
index ca1e24a..8069023 100644
@@ -520,6 +520,7 @@ static const struct snd_kcontrol_new cs4270_snd_controls[] = {
 	SOC_SINGLE("Digital Sidetone Switch", CS4270_FORMAT, 5, 1, 0),
 	SOC_SINGLE("Soft Ramp Switch", CS4270_TRANS, 6, 1, 0),
 	SOC_SINGLE("Zero Cross Switch", CS4270_TRANS, 5, 1, 0),
+	SOC_SINGLE("De-emphasis filter", CS4270_TRANS, 0, 1, 0),
 	SOC_SINGLE("Popguard Switch", CS4270_MODE, 0, 1, 1),
 	SOC_SINGLE("Auto-Mute Switch", CS4270_MUTE, 5, 1, 0),
 	SOC_DOUBLE("Master Capture Switch", CS4270_MUTE, 3, 4, 1, 1),
Signature · 1 line
1.6.5
#2 lore raw
In reply to Daniel Mack
Quoted 4 lines · Daniel Mack

The CS4270 codec features an de-emphasis filter for compensation of audio material filtered by an 50/15 uS algorithm. Not sure whether we should always enable it for 44100Hz sampling frequency, but it should at least be configurable by the user.

It shouldn't be automatically enabled - historically some sources put some preemphasis on the recording in order to compensate for poor playback technologies but it's vanishingly rare to encounter any such sources these days.

I'll apply this.