Skip to contentSkip to conversation

xfstests: add another quotaoff testcase to 220

PATCH In review Christoph Hellwig 2 participants 2 messages Oct 30, 2009 – Nov 2, 2009

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 xfstests: add another quotaoff testcase to 220

Add the quotafile space remove regression test from Ryota Yamauchi to testcase 220.

220 +17 -3
Index: xfstests-dev/220
===================================================================
@@ -1,10 +1,10 @@
 #! /bin/sh
 # FS QA Test No. 220
 #
-# Test that turning quotas off on a mounted filesystem doesn't crash
-# the system.
+# Test quota off handling.
 #
-# Based on a bug report from Utako Kusaka <[email protected]>.
+# Based on bug reports from Utako Kusaka <[email protected]> and
+# Ryota Yamauchi <[email protected]>.
 #
 #-----------------------------------------------------------------------
 # Copyright (c) 2009 Christoph Hellwig.  All Rights Reserved.
@@ -67,5 +67,19 @@ xfs_quota -x -c off $SCRATCH_DEV
 # and unmount (this used to crash)
 umount $SCRATCH_DEV
 
+
+# create scratch filesystem
+_scratch_mkfs_xfs >/dev/null 2>&1
+
+# mount  with quotas enabled
+_scratch_mount -o uquota
+
+# turn off quota and remove space allocated to the quota files
+# (this used to give wrong ENOSYS returns in 2.6.31)
+xfs_quota -x -c off -c remove $SCRATCH_DEV
+
+# and unmount again
+umount $SCRATCH_DEV
+
 status=0
 exit $status

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs

Reviewed-by on v1 1/1
#1 lore raw
Quoted 2 lines · Christoph Hellwig

Add the quotafile space remove regression test from Ryota Yamauchi to testcase 220.

Looks good. This tests the actual problem reported by Ryota Yamauchi.

Quoted 1 line
Quoted 39 lines

Index: xfstests-dev/220
===================================================================

220 +17 -3
@@ -1,10 +1,10 @@
 #! /bin/sh
 # FS QA Test No. 220
 #
-# Test that turning quotas off on a mounted filesystem doesn't crash
-# the system.
+# Test quota off handling.
 #
-# Based on a bug report from Utako Kusaka <[email protected]>.
+# Based on bug reports from Utako Kusaka <[email protected]> and
+# Ryota Yamauchi <[email protected]>.
 #
 #-----------------------------------------------------------------------
 # Copyright (c) 2009 Christoph Hellwig.  All Rights Reserved.
@@ -67,5 +67,19 @@ xfs_quota -x -c off $SCRATCH_DEV
 # and unmount (this used to crash)
 umount $SCRATCH_DEV
 
+
+# create scratch filesystem
+_scratch_mkfs_xfs >/dev/null 2>&1
+
+# mount  with quotas enabled
+_scratch_mount -o uquota
+
+# turn off quota and remove space allocated to the quota files
+# (this used to give wrong ENOSYS returns in 2.6.31)
+xfs_quota -x -c off -c remove $SCRATCH_DEV
+
+# and unmount again
+umount $SCRATCH_DEV
+
 status=0
 exit $status
Quoted 4 lines

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs