Skip to contentSkip to conversation

videobuf-dma-contig.c: add missing #include

PATCH In review Martin Michlmayr 3 participants 6 messages Oct 31, 2009 – Nov 11, 2009 Media (V4L/DVB)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 videobuf-dma-contig.c: add missing #include

media/video/videobuf-dma-contig.c fails to compile on ARM Versatile like this:

 | videobuf-dma-contig.c: In function ‘videobuf_dma_contig_user_get’:
 | videobuf-dma-contig.c:139: error: dereferencing pointer to incomplete type
 | videobuf-dma-contig.c:184: error: dereferencing pointer to incomplete type
 | make[8]: *** [drivers/media/video/videobuf-dma-contig.o] Error 1

Looking at the preprocessed source, I noticed that there was no definition for struct task_struct.

drivers/media/video/videobuf-dma-contig.c +1 -0
@@ -19,6 +19,7 @@
 #include <linux/mm.h>
 #include <linux/pagemap.h>
 #include <linux/dma-mapping.h>
+#include <linux/sched.h>
 #include <media/videobuf-dma-contig.h>
 
 struct videobuf_dma_contig_memory {
Signature · 2 lines
Martin Michlmayr
http://www.cyrius.com/
#1 lore raw

Are there any comments regarding the build fix I submitted? This issue is still there, as you can see at
http://www.xs4all.nl/~hverkuil/logs/Tuesday.log

Quoted 26 lines · Martin Michlmayr

media/video/videobuf-dma-contig.c fails to compile on ARM Versatile like this:

 | videobuf-dma-contig.c: In function ‘videobuf_dma_contig_user_get’:
 | videobuf-dma-contig.c:139: error: dereferencing pointer to incomplete type
 | videobuf-dma-contig.c:184: error: dereferencing pointer to incomplete type
 | make[8]: *** [drivers/media/video/videobuf-dma-contig.o] Error 1

Looking at the preprocessed source, I noticed that there was no definition for struct task_struct.

drivers/media/video/videobuf-dma-contig.c +1 -0
@@ -19,6 +19,7 @@
 #include <linux/mm.h>
 #include <linux/pagemap.h>
 #include <linux/dma-mapping.h>
+#include <linux/sched.h>
 #include <media/videobuf-dma-contig.h>
 
 struct videobuf_dma_contig_memory {
Signature · 3 lines
-- 
Martin Michlmayr
http://www.cyrius.com/
Signature · 2 lines
Martin Michlmayr
http://www.cyrius.com/
#2 lore raw
Quoted 9 lines

-----Original Message-----
From: [email protected] [mailto:linux-media- [email protected]] On Behalf Of Martin Michlmayr
Sent: Wednesday, November 11, 2009 9:24 PM
To: [email protected]
Cc: Mauro Carvalho Chehab
Subject: Re: [PATCH] videobuf-dma-contig.c: add missing #include

Quoted 4 lines

Are there any comments regarding the build fix I submitted? This issue is still there, as you can see at
http://www.xs4all.nl/~hverkuil/logs/Tuesday.log

[Hiremath, Vaibhav] Tested by me, and it is required, since this is breaking the build. Should get merged.

Thanks,
Vaibhav

Quoted 44 lines · Martin Michlmayr
Quoted 1 line

media/video/videobuf-dma-contig.c fails to compile on ARM

Versatile

Quoted 2 lines

like this:
| videobuf-dma-contig.c: In function

'videobuf_dma_contig_user_get':

Quoted 1 line

| videobuf-dma-contig.c:139: error: dereferencing pointer to

incomplete type

Quoted 1 line

| videobuf-dma-contig.c:184: error: dereferencing pointer to

incomplete type

Quoted 1 line

| make[8]: *** [drivers/media/video/videobuf-dma-contig.o] Error

1

Quoted 2 lines

Looking at the preprocessed source, I noticed that there was no

definition

Quoted 5 lines

for struct task_struct.

--- a/drivers/media/video/videobuf-dma-contig.c 2009-10-31

10:22:42.000000000 +0000

Quoted 1 line

+++ b/drivers/media/video/videobuf-dma-contig.c 2009-10-31

10:24:40.000000000 +0000

Quoted 10 lines
drivers/media/video/videobuf-dma-contig.c +1 -1
@@ -19,6 +19,7 @@
 #include <linux/mm.h>
 #include <linux/pagemap.h>
 #include <linux/dma-mapping.h>
+#include <linux/sched.h>
 #include <media/videobuf-dma-contig.h>
 
 struct videobuf_dma_contig_memory {
 
--
Quoted 2 lines

Martin Michlmayr
http://www.cyrius.com/

--
Martin Michlmayr
http://www.cyrius.com/
--
To unsubscribe from this list: send the line "unsubscribe linux- media" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

#3 lore raw
In reply to Martin Michlmayr
Quoted 3 lines · Martin Michlmayr

Are there any comments regarding the build fix I submitted? This issue is still there, as you can see at
http://www.xs4all.nl/~hverkuil/logs/Tuesday.log

Oh, I'm afraid, I've unwillingly stolen your patch:

http://linuxtv.org/hg/~gliakhovetski/v4l-dvb?cmd=changeset;node=d5defdb8768d

Sorry about that. But if your patch landed in patchwork, which it should, thenmaybe yours will be used in the end.

Quoted 23 lines · Martin Michlmayr
Quoted 21 lines

media/video/videobuf-dma-contig.c fails to compile on ARM Versatile like this:

 | videobuf-dma-contig.c: In function ‘videobuf_dma_contig_user_get’:
 | videobuf-dma-contig.c:139: error: dereferencing pointer to incomplete type
 | videobuf-dma-contig.c:184: error: dereferencing pointer to incomplete type
 | make[8]: *** [drivers/media/video/videobuf-dma-contig.o] Error 1

Looking at the preprocessed source, I noticed that there was no definition for struct task_struct.

drivers/media/video/videobuf-dma-contig.c +1 -0
@@ -19,6 +19,7 @@
 #include <linux/mm.h>
 #include <linux/pagemap.h>
 #include <linux/dma-mapping.h>
+#include <linux/sched.h>
 #include <media/videobuf-dma-contig.h>
 
Quoted 1 line

drivers/media/video/videobuf-dma-contig.c line 25

Quoted 1 line
drivers/media/video/videobuf-dma-contig.c +0 -0
 struct videobuf_dma_contig_memory {

Thanks
Guennadi
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/

#4 lore raw
Quoted 10 lines · Guennadi Liakhovetski
Quoted 3 lines

Are there any comments regarding the build fix I submitted? This issue is still there, as you can see at
http://www.xs4all.nl/~hverkuil/logs/Tuesday.log

Oh, I'm afraid, I've unwillingly stolen your patch:

http://linuxtv.org/hg/~gliakhovetski/v4l-dvb?cmd=changeset;node=d5defdb8768d

Sorry about that. But if your patch landed in patchwork, which it should, thenmaybe yours will be used in the end.

Yes, it's here: http://patchwork.kernel.org/patch/56763/

Maybe you can add your acked-by.

Signature · 2 lines
Martin Michlmayr
http://www.cyrius.com/
Acked-by on v1 1/1
#5 lore raw
In reply to Martin Michlmayr
Quoted 11 lines · Martin Michlmayr

media/video/videobuf-dma-contig.c fails to compile on ARM Versatile like this:

 | videobuf-dma-contig.c: In function ‘videobuf_dma_contig_user_get’:
 | videobuf-dma-contig.c:139: error: dereferencing pointer to incomplete type
 | videobuf-dma-contig.c:184: error: dereferencing pointer to incomplete type
 | make[8]: *** [drivers/media/video/videobuf-dma-contig.o] Error 1

Looking at the preprocessed source, I noticed that there was no definition for struct task_struct.

Mauro, if you decide to apply this one and then only take missing parts from
http://linuxtv.org/hg/~gliakhovetski/v4l-dvb?cmd=changeset;node=d5defdb8768d
then you can add my

to this one.

Quoted 20 lines
drivers/media/video/videobuf-dma-contig.c +1 -0
@@ -19,6 +19,7 @@
 #include <linux/mm.h>
 #include <linux/pagemap.h>
 #include <linux/dma-mapping.h>
+#include <linux/sched.h>
 #include <media/videobuf-dma-contig.h>
 
 struct videobuf_dma_contig_memory {
Signature · 7 lines
-- 
Martin Michlmayr
http://www.cyrius.com/
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Thanks
Guennadi
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/