Skip to contentSkip to conversation

asm-generic: Fix typo in asm-generic/unistd.h.

PATCH Applied Chen Liqin 2 participants 7 messages Oct 26, 2009 – Nov 6, 2009 Generic include/asm header files

lore
Share & tools
lore

Chen Liqin

author
#0 lore raw

PATCH 1/1 asm-generic: Fix typo in asm-generic/unistd.h.

From 9741f7928ef35416e49f329a64e623a109de5c2d Mon Sep 17 00:00:00 2001
From: Chen Liqin <[email protected]>
Date: Mon, 26 Oct 2009 10:50:50 +0800
Subject: [PATCH] asm-generic: Fix typo in asm-generic/unistd.h.

Fixed __NR_ftruncate and __NR_ftruncate64 define in asm-generic/unistd.h.

---
 include/asm-generic/unistd.h |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
include/asm-generic/unistd.h +2 -2
index d76b66a..2869650 100644
@@ -802,7 +802,7 @@ __SYSCALL(__NR_fork, sys_ni_syscall)
 #define __NR_statfs __NR3264_statfs
 #define __NR_fstatfs __NR3264_fstatfs
 #define __NR_truncate __NR3264_truncate
-#define __NR_ftruncate __NR3264_truncate
+#define __NR_ftruncate __NR3264_ftruncate
 #define __NR_lseek __NR3264_lseek
 #define __NR_sendfile __NR3264_sendfile
 #define __NR_newfstatat __NR3264_fstatat
@@ -818,7 +818,7 @@ __SYSCALL(__NR_fork, sys_ni_syscall)
 #define __NR_statfs64 __NR3264_statfs
 #define __NR_fstatfs64 __NR3264_fstatfs
 #define __NR_truncate64 __NR3264_truncate
-#define __NR_ftruncate64 __NR3264_truncate
+#define __NR_ftruncate64 __NR3264_ftruncate
 #define __NR_llseek __NR3264_lseek
 #define __NR_sendfile64 __NR3264_sendfile
 #define __NR_fstatat64 __NR3264_fstatat
Signature · 1 line
1.6.2
maintainer Applied
#1 lore raw
Quoted 8 lines · Chen Liqin
Quoted 1 line

From 9741f7928ef35416e49f329a64e623a109de5c2d Mon Sep 17 00:00:00 2001

From: Chen Liqin <[email protected]>
Date: Mon, 26 Oct 2009 10:50:50 +0800
Subject: [PATCH] asm-generic: Fix typo in asm-generic/unistd.h.

Fixed __NR_ftruncate and __NR_ftruncate64 define in asm-generic/unistd.h.

Applied, thanks!

I assume that means you are progressing with getting all bugs fixed that were introduced in the conversion to the asm-generic headers. Do you have a full glibc running again, and passing LTP?

	Arnd <><
#2 lore raw

Arnd Bergmann <[email protected]> 写于 2009-11-02 16:39:14:

Quoted 3 lines

I assume that means you are progressing with getting all bugs fixed that were introduced in the conversion to the asm-generic headers. Do you have a full glibc running again, and passing LTP?

Yes Arnd,

asm-generic headers could run on linux/score platform well, we upgradge libc to glibc-2.5 and passed LTP testsuites. we will gradually release score-linux toolchain on our website.

Best Regards
Liqin

maintainer
#3 lore raw
Quoted 3 lines · On Tuesday 03 November 2009, [email protected] wrote:

asm-generic headers could run on linux/score platform well, we upgradge libc to glibc-2.5 and passed LTP testsuites. we will gradually release score-linux toolchain on our website

Ah, good to hear!

Is there any reason to use glibc-2.5 though? The current release is 2.10.1, and the version you used is over three years old.

Do you have plans to merge your port into eglibc when it's done?

	Arnd <><
#4 lore raw

Arnd Bergmann <[email protected]> 写于 2009-11-03 16:52:17:

Quoted 2 lines

Is there any reason to use glibc-2.5 though? The current release is 2.10.1, and the version you used is over three years old.

We found many stable toolchain use glibc-2.5. so we select it. In fact, what we think first is to could used it in product。 Even linux kernel, in company we still use kernel-2.6.27 version.

Quoted 2 lines

Do you have plans to merge your port into eglibc when it's done?

We have not this plan now.

Liqin

maintainer
#5 lore raw
Quoted 7 lines · On Wednesday 04 November 2009, [email protected] wrote:

Arnd Bergmann <[email protected]> 写于 2009-11-03 16:52:17:

Quoted 2 lines

Is there any reason to use glibc-2.5 though? The current release is 2.10.1, and the version you used is over three years old.

We found many stable toolchain use glibc-2.5. so we select it. In fact, what we think first is to could used it in product。

It is unfortunately a common misunderstanding that older releases that are currently used by others are more stable. The reason you find glibc-2.5 in products today is that it was the current version at the time when the development cycle for the product was started.

In general, when you upgrade to a more recent version, the best idea is to take the latest stable release, and stabilizing on that for a given embedded product. By always using the latest version, you can greatly reduce the amount of work needed for each upgrade, and you get all improvements and bug fixes automatically without having to backport them.

Quoted 1 line

Even linux kernel, in company we still use kernel-2.6.27 version.

Yes, that is good and expected, if that version has proven to be stable for you.

Obviously you will have to do an update at some point and then you can easily move to the latest kernel version since it is now upstream.

I also expect that you have device driver code that is not yet upstream. Getting that in should be a lot easier than the initial architecture code and Greg KH can help you with his drivers/staging infrastructure if you are interested.

Quoted 3 lines
Quoted 1 line

Do you have plans to merge your port into eglibc when it's done?

We have not this plan now.

I would recommend to look into this at some point in the future. Unlike the main glibc project, eglibc[1] is specifically there for supporting embedded architectures and already hosts ports for other platforms that are not in glibc itself, while it closely follows the main glibc development. Contributing there unfortunately requires some paperwork for copyright assignment, but it's probably worth it in the end.

You've done the right thing by merging your kernel code into the official Linux tree, porting your glibc code to the lastest snapshot and submitting it into eglibc is the next big step.

	Arnd <><

--
[1] http://www.eglibc.org/

#6 lore raw

[email protected] 写于 2009-11-04 17:28:11:

Quoted 8 lines

I would recommend to look into this at some point in the future. Unlike the main glibc project, eglibc[1] is specifically there for supporting embedded architectures and already hosts ports for other platforms that are not in glibc itself, while it closely follows the main glibc development. Contributing there unfortunately requires some paperwork for copyright assignment, but it's probably worth it in the end.

Quoted 4 lines

You've done the right thing by merging your kernel code into the official Linux tree, porting your glibc code to the lastest snapshot and submitting it into eglibc is the next big step.

Hi Arnd,

Thank you for the above suggestions and comments, We will evaluate your suggestions and continue upgrading. to make linux/score platform work better.

Best Regards
Liqin