Skip to contentSkip to conversation

CRIS v32: Should index be positive?

PATCH In review Roel Kluin 2 participants 2 messages Nov 1, 2009 – Nov 3, 2009

lore
Share & tools
lore

Roel Kluin

author
#0 lore raw

PATCH 1/1 CRIS v32: Should index be positive?

`port' is used as index for writing to pins during allocation/deallocation. It should be positive.

---
 arch/cris/arch-v32/kernel/pinmux.c  |    4 ++--
 arch/cris/arch-v32/mach-a3/pinmux.c |    2 +-
 arch/cris/arch-v32/mach-fs/pinmux.c |    4 ++--
 3 files changed, 5 insertions(+), 5 deletions(-)

Found by code analysis, is it required?

arch/cris/arch-v32/kernel/pinmux.c +2 -2
index 6eb54ea..f6f3637 100644
@@ -54,7 +54,7 @@ crisv32_pinmux_alloc(int port, int first_pin, int last_pin, enum pin_mode mode)
 
 	crisv32_pinmux_init();
 
-	if (port > PORTS)
+	if (port > PORTS || port < 0)
 		return -EINVAL;
 
 	spin_lock_irqsave(&pinmux_lock, flags);
@@ -197,7 +197,7 @@ crisv32_pinmux_dealloc(int port, int first_pin, int last_pin)
 
 	crisv32_pinmux_init();
 
-	if (port > PORTS)
+	if (port > PORTS || port < 0)
 		return -EINVAL;
 
 	spin_lock_irqsave(&pinmux_lock, flags);
arch/cris/arch-v32/mach-a3/pinmux.c +1 -1
index 0a28c9b..18648ef 100644
@@ -242,7 +242,7 @@ crisv32_pinmux_dealloc(int port, int first_pin, int last_pin)
 
 	crisv32_pinmux_init();
 
-	if (port > PORTS)
+	if (port > PORTS || port < 0)
 		return -EINVAL;
 
 	spin_lock_irqsave(&pinmux_lock, flags);
arch/cris/arch-v32/mach-fs/pinmux.c +2 -2
index d722ad9..38f29ee 100644
@@ -54,7 +54,7 @@ crisv32_pinmux_alloc(int port, int first_pin, int last_pin, enum pin_mode mode)
 
 	crisv32_pinmux_init();
 
-	if (port > PORTS)
+	if (port > PORTS || port < 0)
 		return -EINVAL;
 
 	spin_lock_irqsave(&pinmux_lock, flags);
@@ -195,7 +195,7 @@ int crisv32_pinmux_dealloc(int port, int first_pin, int last_pin)
 
 	crisv32_pinmux_init();
 
-	if (port > PORTS)
+	if (port > PORTS || port < 0)
 		return -EINVAL;
 
 	spin_lock_irqsave(&pinmux_lock, flags);
#1 lore raw
Quoted 2 lines · Roel Kluin

`port' is used as index for writing to pins during allocation/deallocation. It should be positive.

Yup, that's correct. I've added this to the CRIS tree. Thanks!

/^JN - Jesper Nilsson

Signature · 1 line
               Jesper Nilsson -- [email protected]