OMAP: Should cs be positive in gpmc_cs_free()?
Subsystems (5)
PATCH 1/1 OMAP: Should cs be positive in gpmc_cs_free()?
The index `cs' is signed, test whether it is negative before we release gpmc_cs_mem[cs].
Signed-off-by Roel Kluin <[email protected]>
---
Found by code analysis, is it required?
arch/arm/mach-omap2/gpmc.c +1 -1
@@ -378,7 +378,7 @@ EXPORT_SYMBOL(gpmc_cs_request);void gpmc_cs_free (int cs) {spin_lock (&gpmc_mem_lock); -if (cs >=GPMC_CS_NUM || !gpmc_cs_reserved (cs)) { +if (cs >=GPMC_CS_NUM || cs <0 || !gpmc_cs_reserved (cs)) {printk (KERN_ERR "Trying to free non-reserved GPMC CS%d\n" , cs);BUG ();spin_unlock (&gpmc_mem_lock);
Quoted 6 lines · Roel Kluin
The index `cs' is signed, test whether it is negative before we release gpmc_cs_mem[cs].
Signed-off-by Roel Kluin <[email protected]>---
Found by code analysis, is it required?
Looks like a valid check to me.
Acked-by Tony Lindgren <[email protected]>
Quoted 14 lines
arch/arm/mach-omap2/gpmc.c +1
-1@@ -378,7 +378,7 @@ EXPORT_SYMBOL(gpmc_cs_request);void gpmc_cs_free (int cs) {spin_lock (&gpmc_mem_lock); -if (cs >=GPMC_CS_NUM || !gpmc_cs_reserved (cs)) { +if (cs >=GPMC_CS_NUM || cs <0 || !gpmc_cs_reserved (cs)) {printk (KERN_ERR "Trying to free non-reserved GPMC CS%d\n" , cs);BUG ();spin_unlock (&gpmc_mem_lock);