Skip to contentSkip to conversation

sensord: Cleanup of the sensors deamon

PATCH In review Andre Prendel 2 participants 4 messages Nov 3, 2009 – Nov 5, 2009

lore
Share & tools
lore
#0 lore raw

v3 cover sensord: Cleanup of the sensors deamon

Hello Jean,

Another week another patch series :)

There are two new patches. To make you happy I split up the change of the function pointer signature into a separate patch (5/8). Patch 7/8 fixes the unhandled return value of idChip (see your comment in Patch v2 5/8). I've ignored the strcat() issue for now (also from v2 5/8). I hope I don't have missed one of the minor issues. The changes are explained in the patches too.

BTW thanks for your effort to review my patches.

Regards,
Andre

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

#1 lore raw

Re: [lm-sensors] [PATCH v3 0/8] sensord: Cleanup of the sensors

Hi Andre,

Quoted 10 lines · Andre Prendel

Another week another patch series :)

There are two new patches. To make you happy I split up the change of the function pointer signature into a separate patch (5/8). Patch 7/8 fixes the unhandled return value of idChip (see your comment in Patch v2 5/8). I've ignored the strcat() issue for now (also from v2 5/8). I hope I don't have missed one of the minor issues. The changes are explained in the patches too.

BTW thanks for your effort to review my patches.

You're welcome. I've made some more minor comments, but in general I think your patch series is ready to be merged now. Go ahead!

Thanks,

Signature · 6 lines
Jean Delvare

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
#2 lore raw

Re: [lm-sensors] [PATCH v3 0/8] sensord: Cleanup of the sensors

In reply to Andre Prendel

Hi Andre,

Quoted 6 lines · Andre Prendel
Quoted 2 lines · Jean Delvare

You're welcome. I've made some more minor comments, but in general I think your patch series is ready to be merged now. Go ahead!

I've just merged the patches with the minor changes due to your comments.

Great, thanks. Nothing worth mentioning in CHANGES?

Signature · 6 lines
Jean Delvare

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
#3 lore raw

Re: [lm-sensors] [PATCH v3 0/8] sensord: Cleanup of the sensors

In reply to Andre Prendel
Quoted 10 lines · Andre Prendel
Quoted 1 line · Jean Delvare

Hi Andre,

Hi Jean,

Quoted 5 lines · Andre Prendel
Quoted 4 lines · Jean Delvare
Quoted 2 lines

You're welcome. I've made some more minor comments, but in general I think your patch series is ready to be merged now. Go ahead!

Quoted 8 lines
Quoted 4 lines
Quoted 2 lines

I've just merged the patches with the minor changes due to your comments.

Great, thanks. Nothing worth mentioning in CHANGES?

Damn, I forget this every time. Otherwise I think we don't need this refactoring in the CHANGES file. IHMO it is'nt interesting for the user, is it?

You don't need to say too much, indeed. But the log is also for us to a certain extent. Mentioning that cleanups and refactoring happened is a good hint if anything breaks. Useful when writing the freshmeat announcements, too.

Signature · 6 lines
Jean Delvare

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors