Skip to contentSkip to conversation

: Remove duplicate s3c_dma_has_circular() definition for S3C64xx.

PATCH New Maurus Cuelenaere 3 participants 5 messages Nov 3, 2009 – Nov 9, 2009

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 : Remove duplicate s3c_dma_has_circular() definition for S3C64xx.

This patch removes the duplicated s3c_dma_has_circular() definition and so fixes compilation for S3C64xx.

---
 arch/arm/mach-s3c6400/include/mach/dma.h |    8 --------
 1 files changed, 0 insertions(+), 8 deletions(-)
(quoted diff) +0 -0

b/arch/arm/mach-s3c6400/include/mach/dma.h
index 004edab..b7e5494 100644

arch/arm/mach-s3c6400/include/mach/dma.h +0 -8
@@ -58,14 +58,6 @@ enum dma_ch {
 	DMACH_MAX		/* the end */
 };
 
-static __inline__ int s3c_dma_has_circular(void)
-{
-	/* we will be supporting ciruclar buffers as soon as we have DMA
-	 * engine support.
-	 */
-	return 1;
-}
-
 #define S3C2410_DMAF_CIRCULAR		(1 << 0)
 
 static inline bool s3c_dma_has_circular(void)
Signature · 1 line
1.6.3.3
#1 lore raw

PATCH 1/1 : Remove duplicate s3c_dma_has_circular() definition for S3C64xx.

Quoted 2 lines · Maurus Cuelenaere

This patch removes the duplicated s3c_dma_has_circular() definition and so fixes compilation for S3C64xx.

removing the wrong one, we've submitted the necessary circular buffer updates to allow the audio to work without causing it to lose buffers.

Signature · 4 lines
Ben

Q:      What's a light-year?
A:      One-third less calories than a regular year.
#2 lore raw

PATCH 1/1 : Remove duplicate s3c_dma_has_circular() definition for S3C64xx.

Op 03-11-09 23:39, Ben Dooks schreef:

Quoted 8 lines · Maurus Cuelenaere
Quoted 4 lines

This patch removes the duplicated s3c_dma_has_circular() definition and so fixes compilation for S3C64xx.

removing the wrong one, we've submitted the necessary circular buffer updates to allow the audio to work without causing it to lose buffers.

Ah, should I resubmit a patch which removes the other one?

Regards,
Maurus Cuelenaere

#3 lore raw

PATCH 1/1 : Remove duplicate s3c_dma_has_circular() definition for S3C64xx.

Quoted 11 lines · Maurus Cuelenaere

Op 03-11-09 23:39, Ben Dooks schreef:

Quoted 8 lines · Maurus Cuelenaere
Quoted 4 lines

This patch removes the duplicated s3c_dma_has_circular() definition and so fixes compilation for S3C64xx.

removing the wrong one, we've submitted the necessary circular buffer updates to allow the audio to work without causing it to lose buffers.

Ah, should I resubmit a patch which removes the other one?

yes.

Signature · 4 lines
Ben

Q:      What's a light-year?
A:      One-third less calories than a regular year.
#4 lore raw

PATCH 1/1 : Remove duplicate s3c_dma_has_circular() definition for S3C64xx.

Quoted 7 lines · Ben Dooks
Quoted 6 lines · Maurus Cuelenaere

Op 03-11-09 23:39, Ben Dooks schreef:

Quoted 5 lines · Maurus Cuelenaere
Quoted 4 lines

This patch removes the duplicated s3c_dma_has_circular() definition and so fixes compilation for S3C64xx.

Quoted 7 lines
Quoted 5 lines
Quoted 3 lines

removing the wrong one, we've submitted the necessary circular buffer updates to allow the audio to work without causing it to lose buffers.

Ah, should I resubmit a patch which removes the other one?

yes.

but, then we will have 'bool' version for s3c2410 and 'int' type for s3c64xx.