Skip to contentSkip to conversation

Fix example FIT image source files

PATCH New Ira W. Snyder 2 participants 2 messages Nov 4, 2009 – Nov 24, 2009

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Fix example FIT image source files

The example FIT image source files do not compile with the latest dtc and mkimage. The following error message is produced:

DTC: dts->dtb on file "kernel.its"
Error: kernel.its 7:0 - 1:0 syntax error FATAL ERROR: Unable to parse input tree ./mkimage: Can't read kernel.itb.tmp: Invalid argument

The FIT image source files are missing the "/dts-v1/;" directive at the beginning of the file. Add the directive to the examples.

---

Note that to make U-Boot's mkimage utility do anything at all, I had to manually apply Remy's patch from Oct. 28 as well. The patch is titled:
[PATCH] Building of FIT images does not work.

After applying the above patch, then dtc errored with the message reproduced above in the commit text.

 doc/uImage.FIT/kernel.its       |    3 +++
 doc/uImage.FIT/kernel_fdt.its   |    3 +++
 doc/uImage.FIT/multi.its        |    3 +++
 doc/uImage.FIT/update3.its      |    3 +++
 doc/uImage.FIT/update_uboot.its |    3 +++
 5 files changed, 15 insertions(+), 0 deletions(-)
doc/uImage.FIT/kernel.its +3 -0
index d1a5939..ef3ab8f 100644
@@ -1,6 +1,9 @@
 /*
  * Simple U-boot uImage source file containing a single kernel
  */
+
+/dts-v1/;
+
 / {
 	description = "Simple image with single Linux kernel";
 	#address-cells = <1>;
doc/uImage.FIT/kernel_fdt.its +3 -0
index fd6dee2..7e940d2 100644
@@ -1,6 +1,9 @@
 /*
  * Simple U-boot uImage source file containing a single kernel and FDT blob
  */
+
+/dts-v1/;
+
 / {
 	description = "Simple image with single Linux kernel and FDT blob";
 	#address-cells = <1>;
doc/uImage.FIT/multi.its +3 -0
index 1d8c2db..a120da0 100644
@@ -1,6 +1,9 @@
 /*
  * U-boot uImage source file with multiple kernels, ramdisks and FDT blobs
  */
+
+/dts-v1/;
+
 / {
 	description = "Various kernels, ramdisks and FDT blobs";
 	#address-cells = <1>;
doc/uImage.FIT/update3.its +3 -0
index 285cf73..a6eaef6 100644
@@ -1,6 +1,9 @@
 /*
  * Example Automatic software update file.
  */
+
+/dts-v1/;
+
 / {
 	description = "Automatic software updates: kernel, ramdisk, FDT";
 	#address-cells = <1>;
doc/uImage.FIT/update_uboot.its +3 -0
index e0d27ea..846723e 100644
@@ -2,6 +2,9 @@
  * Automatic software update for U-Boot
  * Make sure the flashing addresses ('load' prop) is correct for your board!
  */
+
+/dts-v1/;
+
 / {
 	description = "Automatic U-Boot update";
 	#address-cells = <1>;
Signature · 1 line
1.5.4.3
#1 lore raw

PATCH 1/1 Fix example FIT image source files

Dear "Ira W. Snyder",

Quoted 21 lines · In message <[email protected]> you wrote:

The example FIT image source files do not compile with the latest dtc and mkimage. The following error message is produced:

DTC: dts->dtb on file "kernel.its"
Error: kernel.its 7:0 - 1:0 syntax error FATAL ERROR: Unable to parse input tree ./mkimage: Can't read kernel.itb.tmp: Invalid argument

The FIT image source files are missing the "/dts-v1/;" directive at the beginning of the file. Add the directive to the examples.

---

Note that to make U-Boot's mkimage utility do anything at all, I had to manually apply Remy's patch from Oct. 28 as well. The patch is titled:
[PATCH] Building of FIT images does not work.

After applying the above patch, then dtc errored with the message reproduced above in the commit text.

Quoted 6 lines
 doc/uImage.FIT/kernel.its       |    3 +++
 doc/uImage.FIT/kernel_fdt.its   |    3 +++
 doc/uImage.FIT/multi.its        |    3 +++
 doc/uImage.FIT/update3.its      |    3 +++
 doc/uImage.FIT/update_uboot.its |    3 +++
 5 files changed, 15 insertions(+), 0 deletions(-)

Applied, thanks.

Best regards,

Wolfgang Denk

Signature · 4 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
It is much easier to suggest solutions when you know nothing