Skip to contentSkip to conversation

kernel/irq/chip.c:Modify the code note

PATCH In review Liuweni 2 participants 3 messages Nov 4, 2009 IRQ

lore
Share & tools
lore

Liuweni

author
#0 lore raw

PATCH 1/1 kernel/irq/chip.c:Modify the code note

In the origin, the code notes are not fit for set_irq_msi. The function name is set_irq_data.

And, I change function note "handle_percpu_IRQ" to "handle_percpu_irq".

------------------------------------------

kernel/irq/chip.c +3 -3
index c166019..ba566c2 100644
@@ -166,11 +166,11 @@ int set_irq_data(unsigned int irq, void *data)
 EXPORT_SYMBOL(set_irq_data);
 
 /**
- *	set_irq_data - set irq type data for an irq
+ *	set_irq_msi - set MSI descriptor data for an irq
  *	@irq:	Interrupt number
  *	@entry:	Pointer to MSI descriptor data
  *
- *	Set the hardware irq controller data for an irq
+ *	Set the MSI descriptor entry for an irq
  */
 int set_irq_msi(unsigned int irq, struct msi_desc *entry)
 {
@@ -590,7 +590,7 @@ out_unlock:
 }
 
 /**
- *	handle_percpu_IRQ - Per CPU local irq handler
+ *	handle_percpu_irq - Per CPU local irq handler
  *	@irq:	the interrupt number
  *	@desc:	the interrupt description structure for this irq
  *

--------------
Liuweni
2009-11-04

#1 lore raw
Quoted 15 lines · Liuweni

In the origin, the code notes are not fit for set_irq_msi. The function name is set_irq_data.

And, I change function note "handle_percpu_IRQ" to "handle_percpu_irq".

------------------------------------------

kernel/irq/chip.c +0 -0
index c166019..ba566c2 100644
@@ -166,11 +166,11 @@ int set_irq_data(unsigned int irq, void *data)
 EXPORT_SYMBOL(set_irq_data);

kernel/irq/chip.c int set_irq_data(unsigned int irq, void *data) · line 174

Quoted 10 lines
kernel/irq/chip.c +2 -2
 
 /**
- *	set_irq_data - set irq type data for an irq
+ *	set_irq_msi - set MSI descriptor data for an irq
  *	@irq:	Interrupt number
  *	@entry:	Pointer to MSI descriptor data
  *
- *	Set the hardware irq controller data for an irq
+ *	Set the MSI descriptor entry for an irq
  */

You have submitted this hunk separately before, and I already have it in my queue (and I have sent you a mail informing you about this being merged), so you'd better not include it as part of any further patch submissions.

Signature · 2 lines
Jiri Kosina
SUSE Labs, Novell Inc.
author
#2 lore raw
In reply to Liuweni

Thank you very much.

Someone tell me that my pre-mail's format is incorrect. The correct format is
......
Changlog
......

Signed-off-by yourname <your@mail>

----------------------
patch context

And I have not received your mail. Maybe The gmail play a trick.

Then, I re-submitt this hunk after a week.

But now, I have found your mail in the mail-list.

2009-11-04

Liuweni

发件人: Jiri Kosina
发送时间: 2009-11-04 21:06:24
收件人: Liuweni
抄送: linux-kernel; qingshenlwy; xgr178
主题: Re: [PATCH]kernel/irq/chip.c:Modify the code note

Quoted 15 lines · Liuweni

In the origin, the code notes are not fit for set_irq_msi. The function name is set_irq_data.

And, I change function note "handle_percpu_IRQ" to "handle_percpu_irq".

------------------------------------------

kernel/irq/chip.c +0 -0
index c166019..ba566c2 100644
@@ -166,11 +166,11 @@ int set_irq_data(unsigned int irq, void *data)
 EXPORT_SYMBOL(set_irq_data);

kernel/irq/chip.c int set_irq_data(unsigned int irq, void *data) · line 174

Quoted 10 lines
kernel/irq/chip.c +2 -2
 
 /**
- * set_irq_data - set irq type data for an irq
+ * set_irq_msi - set MSI descriptor data for an irq
  * @irq: Interrupt number
  * @entry: Pointer to MSI descriptor data
  *
- * Set the hardware irq controller data for an irq
+ * Set the MSI descriptor entry for an irq
  */

You have submitted this hunk separately before, and I already have it in my queue (and I have sent you a mail informing you about this being merged), so you'd better not include it as part of any further patch submissions.

Signature · 3 lines
Jiri Kosina
SUSE Labs, Novell Inc.
�翳簕.n�+壏煯壄�+%娝�遍荻w�簕.n�+壏{炳G珴�妠ay�蕠跈�,jf"穐殢飦�戧鐉_璁(殠娸"濟�m���G珴�⒏?櫒璀�&x忈秈O曟瑉窔v豝�m����鹅�⒏?朓�