Skip to contentSkip to conversation

x86/x86-64: Remove unused thread_return label from switch_to()

PATCH In review Masami Hiramatsu 1 participant 2 messages Nov 5, 2009 – Nov 8, 2009 x86

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 x86/x86-64: Remove unused thread_return label from switch_to()

Remove unused thread_return label from switch_to() macro on x86-64. Since this symbol cuts into schedule(), backtrace at the latter half of schedule() was always shown as thread_return().

---

 arch/x86/include/asm/system.h |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)
arch/x86/include/asm/system.h +0 -2
index f08f973..1a953e2 100644
@@ -128,8 +128,6 @@ do {									\
 	     "movq %%rsp,%P[threadrsp](%[prev])\n\t" /* save RSP */	  \
 	     "movq %P[threadrsp](%[next]),%%rsp\n\t" /* restore RSP */	  \
 	     "call __switch_to\n\t"					  \
-	     ".globl thread_return\n"					  \
-	     "thread_return:\n\t"					  \
 	     "movq "__percpu_arg([current_task])",%%rsi\n\t"		  \
 	     __switch_canary						  \
 	     "movq %P[thread_info](%%rsi),%%r8\n\t"			  \
Signature · 7 lines
Masami Hiramatsu

Software Engineer
Hitachi Computer Products (America), Inc.
Software Solutions Division

e-mail: [email protected]
#1 lore raw

[tip:x86/asm] x86: Remove unused thread_return label from switch_to()

Commit-ID:  c12a229bc5971534537a7d0e49e44f9f1f5d0336
Gitweb:     http://git.kernel.org/tip/c12a229bc5971534537a7d0e49e44f9f1f5d0336
Author:     Masami Hiramatsu <[email protected]>
AuthorDate: Thu, 5 Nov 2009 11:03:59 -0500
Committer:  Ingo Molnar <[email protected]>
CommitDate: Sun, 8 Nov 2009 11:57:13 +0100

x86: Remove unused thread_return label from switch_to()

Remove unused thread_return label from switch_to() macro on x86-64. Since this symbol cuts into schedule(), backtrace at the latter half of schedule() was always shown as thread_return().

LKML-Reference: <20091105160359.5181.26225.stgit@harusame>

---
 arch/x86/include/asm/system.h |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)
arch/x86/include/asm/system.h +0 -2
index f08f973..1a953e2 100644
@@ -128,8 +128,6 @@ do {									\
 	     "movq %%rsp,%P[threadrsp](%[prev])\n\t" /* save RSP */	  \
 	     "movq %P[threadrsp](%[next]),%%rsp\n\t" /* restore RSP */	  \
 	     "call __switch_to\n\t"					  \
-	     ".globl thread_return\n"					  \
-	     "thread_return:\n\t"					  \
 	     "movq "__percpu_arg([current_task])",%%rsi\n\t"		  \
 	     __switch_canary						  \
 	     "movq %P[thread_info](%%rsi),%%r8\n\t"			  \