Skip to contentSkip to conversation

libibmad: Add support for PortInfo:McastPkeyTrapSuppressionEnabled

PATCH In review Hal Rosenstock 3 participants 5 messages Nov 6, 2009 – Nov 30, 2009 2 messages not in the archive InfiniBand

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 libibmad: Add support for PortInfo:McastPkeyTrapSuppressionEnabled

Per published MgtWG erratum RefID 4576

---

libibmad/include/infiniband/mad.h +1 -0
index b82b0d5..ed8fd71 100644
@@ -357,6 +357,7 @@ enum MAD_FIELDS {
 	IB_PORT_QKEY_VIOL_F,
 	IB_PORT_GUID_CAP_F,
 	IB_PORT_CLIENT_REREG_F,
+	IB_PORT_MCAST_PKEY_SUPR_ENAB_F,
 	IB_PORT_SUBN_TIMEOUT_F,
 	IB_PORT_RESP_TIME_VAL_F,
 	IB_PORT_LOCAL_PHYS_ERR_F,
libibmad/src/fields.c +1 -0
index 98a0c60..c2f9585 100644
@@ -162,6 +162,7 @@ static const ib_field_t ib_mad_f[] = {
 	{BITSOFFS(384, 16), "QkeyViolations", mad_dump_uint},
 	{BITSOFFS(400, 8), "GuidCap", mad_dump_uint},
 	{BITSOFFS(408, 1), "ClientReregister", mad_dump_uint},
+	{BITSOFFS(409, 1), "McastPkeyTrapSuppressionEnabled", mad_dump_uint},
 	{BITSOFFS(411, 5), "SubnetTimeout", mad_dump_uint},
 	{BITSOFFS(419, 5), "RespTimeVal", mad_dump_uint},
 	{BITSOFFS(424, 4), "LocalPhysErr", mad_dump_uint},

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

A message that is not in the archive (sent off-list or not yet received): [email protected]

#2 lore raw
Quoted 2 lines · Hal Rosenstock

Per published MgtWG erratum RefID 4576

Please describe the change. Reference to private tracker's RefID number is not enough.

Sasha

Quoted 28 lines

---

libibmad/include/infiniband/mad.h +1 -0
index b82b0d5..ed8fd71 100644
@@ -357,6 +357,7 @@ enum MAD_FIELDS {
 	IB_PORT_QKEY_VIOL_F,
 	IB_PORT_GUID_CAP_F,
 	IB_PORT_CLIENT_REREG_F,
+	IB_PORT_MCAST_PKEY_SUPR_ENAB_F,
 	IB_PORT_SUBN_TIMEOUT_F,
 	IB_PORT_RESP_TIME_VAL_F,
 	IB_PORT_LOCAL_PHYS_ERR_F,
libibmad/src/fields.c +1 -1
index 98a0c60..c2f9585 100644
@@ -162,6 +162,7 @@ static const ib_field_t ib_mad_f[] = {
 	{BITSOFFS(384, 16), "QkeyViolations", mad_dump_uint},
 	{BITSOFFS(400, 8), "GuidCap", mad_dump_uint},
 	{BITSOFFS(408, 1), "ClientReregister", mad_dump_uint},
+	{BITSOFFS(409, 1), "McastPkeyTrapSuppressionEnabled", mad_dump_uint},
 	{BITSOFFS(411, 5), "SubnetTimeout", mad_dump_uint},
 	{BITSOFFS(419, 5), "RespTimeVal", mad_dump_uint},
 	{BITSOFFS(424, 4), "LocalPhysErr", mad_dump_uint},
--
Quoted 4 lines

To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

#3 lore raw
Quoted 5 lines · Sasha Khapyorsky
Quoted 2 lines · Hal Rosenstock

Per published MgtWG erratum RefID 4576

Please describe the change.

Not sure what else you are looking for here. Is it a description of the new field or a description of the patch which is trivial:
"Add support for new field to PortInfo"

Quoted 2 lines

Reference to private tracker's RefID number
is not enough.

It's not private as I've tried to explain before.

-- Hal

Quoted 31 lines

Sasha

Quoted 28 lines

---

libibmad/include/infiniband/mad.h +1 -0
index b82b0d5..ed8fd71 100644
@@ -357,6 +357,7 @@ enum MAD_FIELDS {
       IB_PORT_QKEY_VIOL_F,
       IB_PORT_GUID_CAP_F,
       IB_PORT_CLIENT_REREG_F,
+     IB_PORT_MCAST_PKEY_SUPR_ENAB_F,
       IB_PORT_SUBN_TIMEOUT_F,
       IB_PORT_RESP_TIME_VAL_F,
       IB_PORT_LOCAL_PHYS_ERR_F,
libibmad/src/fields.c +1 -1
index 98a0c60..c2f9585 100644
@@ -162,6 +162,7 @@ static const ib_field_t ib_mad_f[] = {
       {BITSOFFS(384, 16), "QkeyViolations", mad_dump_uint},
       {BITSOFFS(400, 8), "GuidCap", mad_dump_uint},
       {BITSOFFS(408, 1), "ClientReregister", mad_dump_uint},
+     {BITSOFFS(409, 1), "McastPkeyTrapSuppressionEnabled", mad_dump_uint},
       {BITSOFFS(411, 5), "SubnetTimeout", mad_dump_uint},
       {BITSOFFS(419, 5), "RespTimeVal", mad_dump_uint},
       {BITSOFFS(424, 4), "LocalPhysErr", mad_dump_uint},
--
Quoted 9 lines
Quoted 4 lines

To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

A message that is not in the archive (sent off-list or not yet received): f0e08f230911061135x4117c1caj311139e1bc8799c2-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org

#5 lore raw
Quoted 8 lines · Hal Rosenstock
Quoted 5 lines · Sasha Khapyorsky
Quoted 2 lines · Hal Rosenstock

Per published MgtWG erratum RefID 4576

Please describe the change.

Not sure what else you are looking for here.

Not just me. Many people may look over change log. And they are not necessary must be a full time IBTA members (and/or even not full time linux-rdma list observers). Likely that for non-IBTA members words "MgtWG" and "RefID 4576" will not say a lot about the change.

And for me it will be required to log into members area of IBTA web site (which is slow) and to search in the tracker for RefID 4576. It is just in order to review a two lines patch.

Quoted 3 lines

Is it a description of
the new field or a description of the patch which is trivial:
"Add support for new field to PortInfo"

What is this field, what should it indicate, what is McastPkeyTrap, what is an issue with it, etc.. Nothing of this is covered.

Quoted 4 lines
Quoted 2 lines

Reference to private tracker's RefID number
is not enough.

It's not private as I've tried to explain before.

You said this, but you never provided any link to where it is published. Could you?

Sasha
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

#6 lore raw
Quoted 19 lines · Sasha Khapyorsky
Quoted 8 lines · Hal Rosenstock
Quoted 5 lines · Sasha Khapyorsky
Quoted 2 lines · Hal Rosenstock

Per published MgtWG erratum RefID 4576

Please describe the change.

Not sure what else you are looking for here.

Not just me. Many people may look over change log. And they are not necessary must be a full time IBTA members (and/or even not full time linux-rdma list observers). Likely that for non-IBTA members words "MgtWG" and "RefID 4576" will not say a lot about the change.

And for me it will be required to log into members area of IBTA web site (which is slow) and to search in the tracker for RefID 4576. It is just in order to review a two lines patch.

Quoted 7 lines
Quoted 3 lines

Is it a description of
the new field or a description of the patch which is trivial:
"Add support for new field to PortInfo"

What is this field, what should it indicate, what is McastPkeyTrap, what is an issue with it, etc.. Nothing of this is covered.

This was addressed in an updated version of the patch sent on 11/6 which has since been incorporated.

Quoted 7 lines
Quoted 4 lines
Quoted 2 lines

Reference to private tracker's RefID number
is not enough.

It's not private as I've tried to explain before.

You said this, but you never provided any link to where it is published. Could you?

It's on the IBTA spec page.

-- Hal

Quoted 3 lines

Sasha

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html