Skip to contentSkip to conversation

Wifi led does not work on Acer Aspire One D250 (ath5k driver)

PATCH In review Carlo Parata 5 participants 9 messages Nov 6, 2009 Atheros ATH5K wireless driver

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Wifi led does not work on Acer Aspire One D250 (ath5k driver)

With this patch, a Acer Aspire One D250 can turn on the wifi led. The array of compatible devices in ath5k driver now includes the hardware present in this computer, as well as the led pin and polarity.

drivers/net/wireless/ath/ath5k/led.c renamed from led.c +2 -0
@@ -73,6 +73,8 @@
 	{ ATH_SDEVICE(PCI_VENDOR_ID_HP, 0x0137b), ATH_LED(3, 1) },
 	/* IBM-specific AR5212 (all others) */
 	{ PCI_VDEVICE(ATHEROS, PCI_DEVICE_ID_ATHEROS_AR5212_IBM), ATH_LED(0, 0) },
+        /* Acer Aspire One D250 AR5007EG */
+	{ PCI_VDEVICE(ATHEROS, 0x001c), ATH_LED(3, 1) },
 	{ }
 };
 
#1 lore raw

drivers/net/wireless/ath/ath5k/led.c      2009-11-06 12:37:44.000000000 +0100 line 77

Quoted 12 lines · Carlo Parata

With this patch, a Acer Aspire One D250 can turn on the wifi led. The array of compatible devices in ath5k driver now includes the hardware present in this computer, as well as the led pin and polarity.

drivers/net/wireless/ath/ath5k/led.c      2009-11-06 12:37:44.000000000 +0100 renamed from led.c    2009-11-06 06:16:39.000000000 +0100 +2 -0
@@ -73,6 +73,8 @@
        { ATH_SDEVICE(PCI_VENDOR_ID_HP, 0x0137b), ATH_LED(3, 1) },
        /* IBM-specific AR5212 (all others) */
        { PCI_VDEVICE(ATHEROS, PCI_DEVICE_ID_ATHEROS_AR5212_IBM), ATH_LED(0, 0) },
+        /* Acer Aspire One D250 AR5007EG */
+       { PCI_VDEVICE(ATHEROS, 0x001c), ATH_LED(3, 1) },

No, this should be based on the subdevice instead (there are lots of ath:001c with different LED settings).

Also, please add your email to the appropriate stanza.

Signature · 1 line
Bob Copeland %% www.bobcopeland.com
#2 lore raw
Quoted 17 lines · Bob Copeland

drivers/net/wireless/ath/ath5k/led.c 2009-11-06 12:37:44.000000000 +0100 line 77

Quoted 12 lines · Carlo Parata

With this patch, a Acer Aspire One D250 can turn on the wifi led. The array of compatible devices in ath5k driver now includes the hardware present in this computer, as well as the led pin and polarity.

drivers/net/wireless/ath/ath5k/led.c 2009-11-06 12:37:44.000000000 +0100 renamed from led.c 2009-11-06 06:16:39.000000000 +0100 +2 -0
@@ -73,6 +73,8 @@
       { ATH_SDEVICE(PCI_VENDOR_ID_HP, 0x0137b), ATH_LED(3, 1) },
       /* IBM-specific AR5212 (all others) */
       { PCI_VDEVICE(ATHEROS, PCI_DEVICE_ID_ATHEROS_AR5212_IBM), ATH_LED(0, 0) },
+        /* Acer Aspire One D250 AR5007EG */
+       { PCI_VDEVICE(ATHEROS, 0x001c), ATH_LED(3, 1) },

No, this should be based on the subdevice instead (there are lots of ath:001c with different LED settings).

Quoted 1 line

Also, please add your email to the appropriate stanza.

It is more than just your E-mail address. Please see Documents/SubmittingPatches.

#3 lore raw
In reply to Carlo Parata
Quoted 17 lines · Carlo Parata

With this patch, a Acer Aspire One D250 can turn on the wifi led. The array of compatible devices in ath5k driver now includes the hardware present in this computer, as well as the led pin and polarity.

drivers/net/wireless/ath/ath5k/led.c renamed from led.c +2 -1
@@ -73,6 +73,8 @@
 	{ ATH_SDEVICE(PCI_VENDOR_ID_HP, 0x0137b), ATH_LED(3, 1) },
 	/* IBM-specific AR5212 (all others) */
 	{ PCI_VDEVICE(ATHEROS, PCI_DEVICE_ID_ATHEROS_AR5212_IBM), ATH_LED(0, 0) },
+        /* Acer Aspire One D250 AR5007EG */
+	{ PCI_VDEVICE(ATHEROS, 0x001c), ATH_LED(3, 1) },
 	{ }
 };
 
--
Quoted 5 lines

To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@...
More majordomo info at http://vger.kernel.org/majordomo-info.html

Excuse me but it is the first post for me in this mailing list. How can I find out the subdevice of my wireless card? The device specifications shown by Windows XP are:

PCI\VEN_168C&DEV_001C&SUBSYS_E00D105B&REV_01\4&192AC53F&0&00E0

Thanks

#5 lore raw
Quoted 2 lines · Holger Schurig

lspci -vvnn gives all the gory details :-)

Yes, also to save you some trouble it looks like this patch should already handle your device:

http://marc.info/?l=linux-wireless&m=125739131923457

(I guess from the XP info that you have 0x105b:e00d too)

Signature · 1 line
Bob Copeland %% www.bobcopeland.com
#6 lore raw
In reply to Carlo Parata
Quoted 7 lines · Carlo Parata

With this patch, a Acer Aspire One D250 can turn on the wifi led. The array of compatible devices in ath5k driver now includes the hardware present in this computer, as well as the led pin and polarity.

drivers/net/wireless/ath/ath5k/led.c line 79

Quoted 7 lines
drivers/net/wireless/ath/ath5k/led.c renamed from led.c +2 -0
@@ -73,6 +73,8 @@
 	{ ATH_SDEVICE(PCI_VENDOR_ID_HP, 0x0137b), ATH_LED(3, 1) },
 	/* IBM-specific AR5212 (all others) */
 	{ PCI_VDEVICE(ATHEROS, PCI_DEVICE_ID_ATHEROS_AR5212_IBM), ATH_LED(0, 0) },
+        /* Acer Aspire One D250 AR5007EG */
+	{ PCI_VDEVICE(ATHEROS, 0x001c), ATH_LED(3, 1) },
 	{ }
 };

FWIW, a similar patch earlier this week drew the following from Bob Copeand:

"... but can you by chance put a contact address in the comment? I've been collecting them in case we one day figure out a better way to do this so it's easy to find the people to retest."

Would you mind complying with his request? Or have I mistakend his applicability?

Thanks,

John

Signature · 2 lines
John W. Linville		Someday the world will need a hero, and you
[email protected]			might be all we have.  Be ready.
#7 lore raw
Quoted 5 lines · John W. Linville

"... but can you by chance put a contact address in the comment?  I've been collecting them in case we one day figure out a better way to do this so it's easy to find the people to retest."

Would you mind complying with his request?  Or have I mistakend his applicability?

It's still applicable in the general case, but I think the new patch is for the same HW as the earlier one posted (Carlo can confirm) so we should be good already.

Signature · 1 line
Bob Copeland %% www.bobcopeland.com
#8 lore raw

Yes I confirm that the earlier patch worked for my hardware. Thank you very much.