Skip to contentSkip to conversation

remove ibnd_update_node

PATCH Applied Al Chu 2 participants 3 messages Nov 2, 2009 – Nov 6, 2009 1 message not in the archive InfiniBand

lore
Share & tools
lore

Al Chu

author
#0 lore raw

PATCH 1/2 remove ibnd_update_node

Hey Sasha,

After talking to Ira about it, we think it's best remove ibnd_update_node.

A) It's not being used.
B) It probably not implemented properly
C) Some of Ira's original plans for its use require more API functions to be added, which of course isn't done right now.

So for now, it seems best to just remove it since it's an additional API function that can lead to confusion.

Al

Signature · 5 lines
Albert Chu
[email protected]
Computer Scientist
High Performance Systems Division
Lawrence Livermore National Laboratory

From: Albert Chu <[email protected]>
Date: Thu, 29 Oct 2009 18:56:32 -0700
Subject: [PATCH] remove ibnd_update_node

---
 .../libibnetdisc/include/infiniband/ibnetdisc.h    |    3 -
 infiniband-diags/libibnetdisc/src/ibnetdisc.c      |   55 --------------------
 2 files changed, 0 insertions(+), 58 deletions(-)
infiniband-diags/libibnetdisc/include/infiniband/ibnetdisc.h +0 -3
index bb5df02..6120453 100644
@@ -172,9 +172,6 @@ MAD_EXPORT void ibnd_destroy_fabric(ibnd_fabric_t * fabric);
 MAD_EXPORT ibnd_node_t *ibnd_find_node_guid(ibnd_fabric_t * fabric,
 					    uint64_t guid);
 MAD_EXPORT ibnd_node_t *ibnd_find_node_dr(ibnd_fabric_t * fabric, char *dr_str);
-MAD_EXPORT ibnd_node_t *ibnd_update_node(struct ibmad_port *ibmad_port,
-					 ibnd_fabric_t * fabric,
-					 ibnd_node_t * node);
 
 typedef void (*ibnd_iter_node_func_t) (ibnd_node_t * node, void *user_data);
 MAD_EXPORT void ibnd_iter_nodes(ibnd_fabric_t * fabric,
infiniband-diags/libibnetdisc/src/ibnetdisc.c +0 -55

61 lines not on this page · raw message

Signature · 1 line
1.5.4.5

A message that is not in the archive (sent off-list or not yet received): [email protected]

#2 lore raw
Quoted 10 lines · Al Chu

Hey Sasha,

After talking to Ira about it, we think it's best remove ibnd_update_node.

A) It's not being used.
B) It probably not implemented properly
C) Some of Ira's original plans for its use require more API functions to be added, which of course isn't done right now.

Quoted 18 lines

So for now, it seems best to just remove it since it's an additional API function that can lead to confusion.

Al

Signature · 12 lines
Albert Chu
[email protected]
Computer Scientist
High Performance Systems Division
Lawrence Livermore National Laboratory

From: Albert Chu <[email protected]>
Date: Thu, 29 Oct 2009 18:56:32 -0700
Subject: [PATCH] remove ibnd_update_node


Signed-off-by: Albert Chu <[email protected]>

Applied. Thanks.

Also removing its man page and libibnetdisc.map entry.

Sasha
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

#3 lore raw

PATCH 1/1 libibnetdisc: remove man page of removed API

In reply to a message not in the archive

Remove man page for removed ibnd_update_node() API. Also removing its entry from library version script.

---
 infiniband-diags/libibnetdisc/Makefile.am          |    3 +--
 .../libibnetdisc/man/ibnd_update_node.3            |   17 -----------------
 infiniband-diags/libibnetdisc/src/libibnetdisc.map |    1 -
 3 files changed, 1 insertions(+), 20 deletions(-)
 delete mode 100644 infiniband-diags/libibnetdisc/man/ibnd_update_node.3
infiniband-diags/libibnetdisc/Makefile.am +1 -2
index 7085f14..636d142 100644
@@ -44,8 +44,7 @@ man_MANS = man/ibnd_debug.3 \
 	man/ibnd_find_node_guid.3 \
 	man/ibnd_iter_nodes.3 \
 	man/ibnd_iter_nodes_type.3 \
-	man/ibnd_show_progress.3 \
-	man/ibnd_update_node.3
+	man/ibnd_show_progress.3
 
 EXTRA_DIST = $(srcdir)/src/libibnetdisc.map libibnetdisc.ver $(man_MANS)
 
infiniband-diags/libibnetdisc/man/ibnd_update_node.3 deleted +0 -17
deleted file mode 100644
index 472f3cd..0000000
@@ -1,17 +0,0 @@
-.TH IBND_UPDATE_NODE 3  "July 25, 2008" "OpenIB" "OpenIB Programmer's Manual"
-.SH "NAME"
-ibnd_update_node \- Update the node specified with new data from the fabric.
-.SH "SYNOPSIS"
-.nf
-.B #include <infiniband/ibnetdisc.h>
-.sp
-.BI "ibnd_node_t *ibnd_update_node(ibnd_node_t *node)"
-.SH "DESCRIPTION"
-.B ibnd_update_node()
-Update the node info, port info, and node description of the node specified.
-.SH "RETURN VALUE"
-.B ibnd_update_node()
-Return NULL on failure, otherwise a valid ibnd_node_t object which is part of the fabric object.
-.SH "AUTHORS"
-.TP
-Ira Weiny <[email protected]>
infiniband-diags/libibnetdisc/src/libibnetdisc.map +0 -1
index bd108ab..13bb65a 100644
@@ -5,7 +5,6 @@ IBNETDISC_1.0 {
 		ibnd_discover_fabric;
 		ibnd_destroy_fabric;
 		ibnd_find_node_guid;
-		ibnd_update_node;
 		ibnd_find_node_dr;
 		ibnd_is_xsigo_guid;
 		ibnd_is_xsigo_tca;
Signature · 6 lines
1.6.5.2

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html