Skip to contentSkip to conversation

rt2x00: Mark rt2800pci as broken.

PATCH In review Gertjan van Wingerde 3 participants 7 messages Nov 8, 2009 Networking drivers (wireless)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 rt2x00: Mark rt2800pci as broken.

The rt2800pci driver is currently only marked as experimental, and only the help text explains that the driver is basically non-functional. Make the driver depend on CONFIG_BROKEN so that users cannot enable this driver without knowing that it is broken.

---
 drivers/net/wireless/rt2x00/Kconfig |    7 ++-----
 1 files changed, 2 insertions(+), 5 deletions(-)
drivers/net/wireless/rt2x00/Kconfig +2 -5
index bf60689..b0f4a2f 100644
@@ -64,8 +64,8 @@ config RT2800PCI_SOC
 	default y
 
 config RT2800PCI
-	tristate "Ralink rt2800 (PCI/PCMCIA) support (VERY EXPERIMENTAL)"
-	depends on (RT2800PCI_PCI || RT2800PCI_SOC) && EXPERIMENTAL
+	tristate "Ralink rt2800 (PCI/PCMCIA) support (BROKEN)"
+	depends on (RT2800PCI_PCI || RT2800PCI_SOC) && EXPERIMENTAL && BROKEN
 	select RT2800_LIB
 	select RT2X00_LIB_PCI if RT2800PCI_PCI
 	select RT2X00_LIB_SOC if RT2800PCI_SOC
@@ -78,9 +78,6 @@ config RT2800PCI
 	  This adds support for rt2800 wireless chipset family.
 	  Supported chips: RT2760, RT2790, RT2860, RT2880, RT2890 & RT3052
 
-	  This driver is non-functional at the moment and is intended for
-	  developers.
-
 	  When compiled as a module, this driver will be called "rt2800pci.ko".
 
 config RT2500USB
Signature · 1 line
1.6.5.2
Acked-by on v1 1/1
#1 lore raw
Quoted 5 lines · Gertjan van Wingerde

The rt2800pci driver is currently only marked as experimental, and only the help text explains that the driver is basically non-functional. Make the driver depend on CONFIG_BROKEN so that users cannot enable this driver without knowing that it is broken.

Quoted 29 lines
---
 drivers/net/wireless/rt2x00/Kconfig |    7 ++-----
 1 files changed, 2 insertions(+), 5 deletions(-)
drivers/net/wireless/rt2x00/Kconfig +2 -5
index bf60689..b0f4a2f 100644
@@ -64,8 +64,8 @@ config RT2800PCI_SOC
 	default y
 
 config RT2800PCI
-	tristate "Ralink rt2800 (PCI/PCMCIA) support (VERY EXPERIMENTAL)"
-	depends on (RT2800PCI_PCI || RT2800PCI_SOC) && EXPERIMENTAL
+	tristate "Ralink rt2800 (PCI/PCMCIA) support (BROKEN)"
+	depends on (RT2800PCI_PCI || RT2800PCI_SOC) && EXPERIMENTAL && BROKEN
 	select RT2800_LIB
 	select RT2X00_LIB_PCI if RT2800PCI_PCI
 	select RT2X00_LIB_SOC if RT2800PCI_SOC
@@ -78,9 +78,6 @@ config RT2800PCI
 	  This adds support for rt2800 wireless chipset family.
 	  Supported chips: RT2760, RT2790, RT2860, RT2880, RT2890 & RT3052
 
-	  This driver is non-functional at the moment and is intended for
-	  developers.
-
 	  When compiled as a module, this driver will be called "rt2800pci.ko".
 
 config RT2500USB
Acked-by on v1 1/1
#2 lore raw
In reply to Gertjan van Wingerde

[ please cc: me on rt2x00 patches if possible, thanks ]

Quoted 7 lines · On Sunday 08 November 2009 12:28:54 Gertjan van Wingerde wrote:

The rt2800pci driver is currently only marked as experimental, and only the help text explains that the driver is basically non-functional. Make the driver depend on CONFIG_BROKEN so that users cannot enable this driver without knowing that it is broken.

drivers/net/wireless/rt2x00/Kconfig config RT2800PCI · line 83

Quoted 9 lines
drivers/net/wireless/rt2x00/Kconfig +0 -3
@@ -78,9 +78,6 @@ config RT2800PCI
 	  This adds support for rt2800 wireless chipset family.
 	  Supported chips: RT2760, RT2790, RT2860, RT2880, RT2890 & RT3052
 
-	  This driver is non-functional at the moment and is intended for
-	  developers.
-
 	  When compiled as a module, this driver will be called "rt2800pci.ko".
 
 config RT2500USB

This help text could have stayed, anyway..

[ This is against rt2800 tree right? Cause I don't see any of my patches
in public rt2x00 tree yet. ]

--
Bartlomiej Zolnierkiewicz

#3 lore raw
Quoted 4 lines · Bartlomiej Zolnierkiewicz

[ This is against rt2800 tree right? Cause I don't see any of my patches
in public rt2x00 tree yet. ]

Actually, it is against wireless-testing.

---
Gertjan

#4 lore raw
Quoted 7 lines · On Sunday 08 November 2009 13:50:05 Gertjan van Wingerde wrote:
Quoted 4 lines · Bartlomiej Zolnierkiewicz

[ This is against rt2800 tree right? Cause I don't see any of my patches
in public rt2x00 tree yet. ]

Actually, it is against wireless-testing.

Interesting. :)

John, you may want to replace what you have with rt2800-v2.1 branch of misc.git tree (more ACKs from Ivo and order is optimized a bit based on feedback from Julian).

Signature · 1 line
Bartlomiej Zolnierkiewicz
#5 lore raw
In reply to Bartlomiej Zolnierkiewicz
Quoted 16 lines · On Sunday 08 November 2009 13:38:34 Bartlomiej Zolnierkiewicz wrote:
Quoted 15 lines · On Sunday 08 November 2009 12:28:54 Gertjan van Wingerde wrote:

The rt2800pci driver is currently only marked as experimental, and only the help text explains that the driver is basically non-functional. Make the driver depend on CONFIG_BROKEN so that users cannot enable this driver without knowing that it is broken.

drivers/net/wireless/rt2x00/Kconfig +0 -3
@@ -78,9 +78,6 @@ config RT2800PCI
 	  This adds support for rt2800 wireless chipset family.
 	  Supported chips: RT2760, RT2790, RT2860, RT2880, RT2890 & RT3052
 
-	  This driver is non-functional at the moment and is intended for
-	  developers.
-
 	  When compiled as a module, this driver will be called "rt2800pci.ko".
 
Quoted 5 lines

drivers/net/wireless/rt2x00/Kconfig config RT2800PCI · line 83

Quoted 1 line
drivers/net/wireless/rt2x00/Kconfig +0 -0
 config RT2500USB

This help text could have stayed, anyway..

It turned out that CONFIG_BROKEN is no longer an user visible option so by applying this change we would lose the advantage of having the upstream build testing and early detection of breakages related to upstream API updates.

[ I've just noticed now that rt2800pci was no longer included in the build
and dropped the patch from rt2800 tree. ]

Signature · 1 line
Bartlomiej Zolnierkiewicz
#6 lore raw
Quoted 22 lines · Bartlomiej Zolnierkiewicz
Quoted 20 lines · On Sunday 08 November 2009 13:38:34 Bartlomiej Zolnierkiewicz wrote:
Quoted 7 lines · On Sunday 08 November 2009 12:28:54 Gertjan van Wingerde wrote:

The rt2800pci driver is currently only marked as experimental, and only the help text explains that the driver is basically non-functional. Make the driver depend on CONFIG_BROKEN so that users cannot enable this driver without knowing that it is broken.

drivers/net/wireless/rt2x00/Kconfig config RT2800PCI · line 83

Quoted 9 lines
drivers/net/wireless/rt2x00/Kconfig +0 -3
@@ -78,9 +78,6 @@ config RT2800PCI
 	  This adds support for rt2800 wireless chipset family.
 	  Supported chips: RT2760, RT2790, RT2860, RT2880, RT2890 & RT3052
 
-	  This driver is non-functional at the moment and is intended for
-	  developers.
-
 	  When compiled as a module, this driver will be called "rt2800pci.ko".
 
 config RT2500USB

This help text could have stayed, anyway..

Quoted 9 lines
Quoted 1 line

It turned out that CONFIG_BROKEN is no longer an user visible option so by applying this change we would lose the advantage of having the upstream build testing and early detection of breakages related to upstream API updates.

[ I've just noticed now that rt2800pci was no longer included in the build
and dropped the patch from rt2800 tree. ]

Yeah, I noticed that too. So I guess it is better not to apply it, as we then loose testing coverage.

---
Gertjan.