trivial: fix checking socket() in net tstamp example
Subsystems (2)
PATCH 1/1 trivial: fix checking socket() in net tstamp example
--- .../networking/timestamping/timestamping.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
Documentation/networking/timestamping/timestamping.c +1 -1
@@ -370,7 +370,7 @@ int main(int argc, char **argv) } sock =socket (PF_INET ,SOCK_DGRAM ,IPPROTO_UDP ); -if (socket <0 ) +if (sock <0 )bail ("socket" );memset (&device,0 ,sizeof (device));
Quoted 10 lines · Ali Gholami Rudi
Signed-off-by Ali Gholami Rudi <[email protected]>--- .../networking/timestamping/timestamping.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)Documentation/networking/timestamping/timestamping.c +0
-0
Documentation/networking/timestamping/timestamping.c int main(int argc, char **argv) · line 373
Quoted 5 lines
Documentation/networking/timestamping/timestamping.c +1
-1@@ -370,7 +370,7 @@ int main(int argc, char **argv) } sock =socket (PF_INET ,SOCK_DGRAM ,IPPROTO_UDP ); -if (socket <0 ) +if (sock <0 )
Argh, of course you are right. FWIW, acknowledged.
Signature · 6 lines
Best Regards, Patrick Ohly The content of this message is my personal opinion only and although I am an employee of Intel, the statements I make here in no way represent Intel's position on the issue, nor am I authorized to speak on behalf of Intel on this matter.
Hi Patrick,
Quoted 10 lines · Patrick Ohly
Documentation/networking/timestamping/timestamping.c int main(int argc, char **argv) · line 373
Quoted 8 lines
Documentation/networking/timestamping/timestamping.c +1
-1@@ -370,7 +370,7 @@ int main(int argc, char **argv) } sock =socket (PF_INET ,SOCK_DGRAM ,IPPROTO_UDP ); -if (socket <0 ) +if (sock <0 )Argh, of course you are right. FWIW, acknowledged.
By the way, I tried igb hardware timestamp but HWTSTAMP_FILTER_ALL works almost like HWTSTAMP_FILTER_PTP_*. Isn't it supposed to timestamp all of the incoming packets? Maybe there is something wrong with my test setup?
Thanks,
Ali
What's the state of the TX timestamping?
In reply to Patrick Ohly[dropped [email protected] since this is not relevant to them]
by the way Patrick,
A few months ago I tried to implement TX timestamping for a card I was working on [1]. I wasn't quite successful (sorry can't be more explicit, I haven't touched it since then) and thought the reason was that the implementation was half-baked because David reverted it--I got to that conclusion after reading this thread in linux-net ("TX time stamping"):
http://thread.gmane.org/gmane.linux.network/121378/
Could you please tell me what the state of TX timestamping is? Did David revert it or not? I can't find a revert commit.
Thanks,
Emilio
[1] http://www.ohwr.org/twiki/bin/view/OHR/WhiteRabbit/WhiteRabbit
Quoted 7 lines · Patrick Ohly
Quoted 7 lines
Documentation/networking/timestamping/timestamping.c +0
-0@@ -370,7 +370,7 @@ int main(int argc, char **argv) }
Quoted 5 lines
Documentation/networking/timestamping/timestamping.c int main(int argc, char **argv) · line 373
Quoted 3 lines
Documentation/networking/timestamping/timestamping.c +1
-1sock =socket (PF_INET ,SOCK_DGRAM ,IPPROTO_UDP ); -if (socket <0 ) +if (sock <0 )Argh, of course you are right. FWIW, acknowledged.
Doesn't seem to be present in 2.6.33-rc1, I have applied it to my tree.
Thanks,
Signature · 2 lines
Jiri Kosina SUSE Labs, Novell Inc.