ksym_tracer: Support read accesses independent of read/write.
PATCH 1/1 ksym_tracer: Support read accesses independent of read/write.
All of the infrastructure already exists to support read accesses for platforms that support a read access independently of read/write (such as in the case of the SuperH UBC). This just trivially hooks up the read case by itself.
---
Applies on top of v6 of the hw-breakpoints perf event rewrite (and tracing/hw-breakpoints in -tip as of this moment).
kernel/trace/trace_ksym.c | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-)
kernel/trace/trace_ksym.c +10 -1
@@ -136,6 +136,7 @@ static int ksym_trace_get_access_type(char *str) access |=HW_BREAKPOINT_X ;switch (access) { +case HW_BREAKPOINT_R :case HW_BREAKPOINT_W :case HW_BREAKPOINT_W |HW_BREAKPOINT_R :return access;
@@ -239,7 +240,9 @@ static ssize_t ksym_trace_filter_read(struct file *filp, char __user *ubuf,hlist_for_each_entry (entry, node, &ksym_filter_head, ksym_hlist) { ret =trace_seq_printf (s,"%pS:" , (void *)entry->ksym_addr); -if (entry->type ==HW_BREAKPOINT_W ) +if (entry->type ==HW_BREAKPOINT_R ) + ret =trace_seq_puts (s,"r--\n" ); +else if (entry->type ==HW_BREAKPOINT_W ) ret =trace_seq_puts (s,"-w-\n" );else if (entry->type == (HW_BREAKPOINT_W |HW_BREAKPOINT_R )) ret =trace_seq_puts (s,"rw-\n" );
@@ -414,6 +417,9 @@ static enum print_line_t ksym_trace_output(struct trace_iterator *iter)return TRACE_TYPE_PARTIAL_LINE ;switch (field->type) { +case HW_BREAKPOINT_R : + ret =trace_seq_printf (s," R " ); +break ;case HW_BREAKPOINT_W : ret =trace_seq_printf (s," W " );break ;
@@ -488,6 +494,9 @@ static int ksym_tracer_stat_show(struct seq_file *m, void *v) access_type = entry->type;switch (access_type) { +case HW_BREAKPOINT_R : +seq_puts (m," R " ); +break ;case HW_BREAKPOINT_W :seq_puts (m," W " );break ;
Frederic Weisbecker
AppliedQuoted 7 lines · Paul Mundt
All of the infrastructure already exists to support read accesses for platforms that support a read access independently of read/write (such as in the case of the SuperH UBC). This just trivially hooks up the read case by itself.
Signed-off-by Paul Mundt <[email protected]>
Queued, thanks Paul.
Commit-ID: 676c0dbe6e514fdd8e434a9e623c781aa9b40b15 Gitweb: http://git.kernel.org/tip/676c0dbe6e514fdd8e434a9e623c781aa9b40b15 Author: Paul Mundt <[email protected]> AuthorDate: Mon, 9 Nov 2009 17:37:34 +0900 Committer: Frederic Weisbecker <[email protected]> CommitDate: Tue, 10 Nov 2009 11:10:08 +0100
ksym_tracer: Support read accesses independent of read/write.
All of the infrastructure already exists to support read accesses for platforms that support a read access independently of read/write (such as in the case of the SuperH UBC). This just trivially hooks up the read case by itself.
LKML-Reference: <[email protected]>
--- kernel/trace/trace_ksym.c | 11 ++++++++++- 1 files changed, 10 insertions(+), 1 deletions(-)
kernel/trace/trace_ksym.c +10 -1
@@ -136,6 +136,7 @@ static int ksym_trace_get_access_type(char *str) access |=HW_BREAKPOINT_X ;switch (access) { +case HW_BREAKPOINT_R :case HW_BREAKPOINT_W :case HW_BREAKPOINT_W |HW_BREAKPOINT_R :return access;
@@ -239,7 +240,9 @@ static ssize_t ksym_trace_filter_read(struct file *filp, char __user *ubuf,hlist_for_each_entry (entry, node, &ksym_filter_head, ksym_hlist) { ret =trace_seq_printf (s,"%pS:" , (void *)entry->ksym_addr); -if (entry->type ==HW_BREAKPOINT_W ) +if (entry->type ==HW_BREAKPOINT_R ) + ret =trace_seq_puts (s,"r--\n" ); +else if (entry->type ==HW_BREAKPOINT_W ) ret =trace_seq_puts (s,"-w-\n" );else if (entry->type == (HW_BREAKPOINT_W |HW_BREAKPOINT_R )) ret =trace_seq_puts (s,"rw-\n" );
@@ -414,6 +417,9 @@ static enum print_line_t ksym_trace_output(struct trace_iterator *iter)return TRACE_TYPE_PARTIAL_LINE ;switch (field->type) { +case HW_BREAKPOINT_R : + ret =trace_seq_printf (s," R " ); +break ;case HW_BREAKPOINT_W : ret =trace_seq_printf (s," W " );break ;
@@ -488,6 +494,9 @@ static int ksym_tracer_stat_show(struct seq_file *m, void *v) access_type = entry->type;switch (access_type) { +case HW_BREAKPOINT_R : +seq_puts (m," R " ); +break ;case HW_BREAKPOINT_W :seq_puts (m," W " );break ;