Skip to contentSkip to conversation

hwmon: (adt7475) Fix temperature fault flags

PATCH In review Jean Delvare 2 participants 6 messages Nov 9, 2009 – Nov 15, 2009

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 hwmon: (adt7475) Fix temperature fault flags

The logic of temperature fault flags is wrong, it shows faults when there are none and vice versa. Fix it.

I can't believe this has been broken since the driver was added, 8 months ago, basically breaking temp1 and temp3, and nobody ever complained.

Cc Hans de Goede <[email protected]>
Cc Jordan Crouse <[email protected]>
---
 drivers/hwmon/adt7475.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/hwmon/adt7475.c +1 -2
@@ -350,8 +350,7 @@ static ssize_t show_temp(struct device *
 
 	case FAULT:
 		/* Note - only for remote1 and remote2 */
-		out = data->alarms & (sattr->index ? 0x8000 : 0x4000);
-		out = out ? 0 : 1;
+		out = !!(data->alarms & (sattr->index ? 0x8000 : 0x4000));
 		break;
 
 	default:
Signature · 6 lines
Jean Delvare

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
#1 lore raw

Re: [lm-sensors] [PATCH] hwmon: (adt7475) Fix temperature fault

Hmm,

I've a adt7475 on my home development machine in the Netherlands (I'm currently in Brno).

I can (and would like to) verify this fix when I'm back home (friday). The adt7475 on my machine is used to control an additional fan, and has no external temperature sensors connected (AFAIK).

I've tested the original adt7475 driver on this machine, but I may have simply out "temp1 ignore" (and temp3) in my sensors.conf missing this.

Regards,

Hans

Quoted 19 lines · Jean Delvare

The logic of temperature fault flags is wrong, it shows faults when there are none and vice versa. Fix it.

I can't believe this has been broken since the driver was added, 8 months ago, basically breaking temp1 and temp3, and nobody ever complained.

Cc Hans de Goede<[email protected]>
Cc Jordan Crouse<[email protected]>
---
  drivers/hwmon/adt7475.c |    3 +--
  1 file changed, 1 insertion(+), 2 deletions(-)

drivers/hwmon/adt7475.c static ssize_t show_temp(struct device * · line 356

Quoted 9 lines
drivers/hwmon/adt7475.c +1 -2
@@ -350,8 +350,7 @@ static ssize_t show_temp(struct device *
 
  	case FAULT:
  		/* Note - only for remote1 and remote2 */
-		out = data->alarms&  (sattr->index ? 0x8000 : 0x4000);
-		out = out ? 0 : 1;
+		out = !!(data->alarms&  (sattr->index ? 0x8000 : 0x4000));
  		break;
 
  	default:

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

#2 lore raw

Re: [lm-sensors] [PATCH] hwmon: (adt7475) Fix temperature fault

In reply to Jean Delvare

Hi Hans,

Quoted 10 lines · Hans de Goede

I've a adt7475 on my home development machine in the Netherlands (I'm currently in Brno).

I can (and would like to) verify this fix when I'm back home (friday). The adt7475 on my machine is used to control an additional fan, and has no external temperature sensors connected (AFAIK).

I've tested the original adt7475 driver on this machine, but I may have simply out "temp1 ignore" (and temp3) in my sensors.conf missing this.

Thanks for the feedback. I have tested on 3 dumps I have here, one ADT7475 and two ADT7473. The ADT7475 reports -64°C for temp1 and temp3 and has both fault bits set to 1. The two ADT7473 reports reasonable values for both temp1 and temp3 and have the fault bits set to 0. Assuming that the ADT7473 and ADT7475 are almost the same chip and should thus behave the same, my change would be correct.

I have also noticed that Jordan's original code did not have the inversion:

http://lists.lm-sensors.org/pipermail/lm-sensors/2008-January/022338.html

	case FAULT:
		/* Note - only for remote1 and remote2 */

		ret = sprintf(buf, "%d\n",
			(data->alarms & (sattr->index ? 0x4000 : 0x8000)));
		break;

but it lacked normalization (output value 0x4000 or 0x8000 instead of 1.) Maybe when normalizing the logic was inverted by accident?

The few ADT7475 data points I have found on the web suggest that on many boards temp1 and temp3 are not connected. This could explain why the bug went unnoticed so far. Why vendors use these chips, which are specifically designed for automatic temperature-based fan speed control, in designs where they don't bother wiring the thermal sensors, is beyond me.

Anyway, I will wait for you to return home and test on your system, before sending the patch to Linus.

Signature · 6 lines
Jean Delvare

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
#3 lore raw

Re: [lm-sensors] [PATCH] hwmon: (adt7475) Fix temperature fault

In reply to Jean Delvare
Quoted 43 lines · Jean Delvare

Hi Hans,

Quoted 10 lines · Hans de Goede

I've a adt7475 on my home development machine in the Netherlands (I'm currently in Brno).

I can (and would like to) verify this fix when I'm back home (friday). The adt7475 on my machine is used to control an additional fan, and has no external temperature sensors connected (AFAIK).

I've tested the original adt7475 driver on this machine, but I may have simply out "temp1 ignore" (and temp3) in my sensors.conf missing this.

Thanks for the feedback. I have tested on 3 dumps I have here, one ADT7475 and two ADT7473. The ADT7475 reports -64°C for temp1 and temp3 and has both fault bits set to 1. The two ADT7473 reports reasonable values for both temp1 and temp3 and have the fault bits set to 0. Assuming that the ADT7473 and ADT7475 are almost the same chip and should thus behave the same, my change would be correct.

I have also noticed that Jordan's original code did not have the inversion:

http://lists.lm-sensors.org/pipermail/lm-sensors/2008-January/022338.html

	case FAULT:
		/* Note - only for remote1 and remote2 */

		ret = sprintf(buf, "%d\n",
			(data->alarms & (sattr->index ? 0x4000 : 0x8000)));
		break;

but it lacked normalization (output value 0x4000 or 0x8000 instead of 1.) Maybe when normalizing the logic was inverted by accident?

The few ADT7475 data points I have found on the web suggest that on many boards temp1 and temp3 are not connected. This could explain why the bug went unnoticed so far. Why vendors use these chips, which are specifically designed for automatic temperature-based fan speed control, in designs where they don't bother wiring the thermal sensors, is beyond me.

Quoted 2 lines

Anyway, I will wait for you to return home and test on your system, before sending the patch to Linus.

Hans, did you have the time to test this patch?

Signature · 6 lines
Jean Delvare

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
#4 lore raw

Re: [lm-sensors] [PATCH] hwmon: (adt7475) Fix temperature fault

In reply to Jean Delvare

Hi,

Quoted 44 lines · Jean Delvare
Quoted 43 lines · Jean Delvare

Hi Hans,

Quoted 10 lines · Hans de Goede

I've a adt7475 on my home development machine in the Netherlands (I'm currently in Brno).

I can (and would like to) verify this fix when I'm back home (friday). The adt7475 on my machine is used to control an additional fan, and has no external temperature sensors connected (AFAIK).

I've tested the original adt7475 driver on this machine, but I may have simply out "temp1 ignore" (and temp3) in my sensors.conf missing this.

Thanks for the feedback. I have tested on 3 dumps I have here, one ADT7475 and two ADT7473. The ADT7475 reports -64°C for temp1 and temp3 and has both fault bits set to 1. The two ADT7473 reports reasonable values for both temp1 and temp3 and have the fault bits set to 0. Assuming that the ADT7473 and ADT7475 are almost the same chip and should thus behave the same, my change would be correct.

I have also noticed that Jordan's original code did not have the inversion:

http://lists.lm-sensors.org/pipermail/lm-sensors/2008-January/022338.html

	case FAULT:
		/* Note - only for remote1 and remote2 */

		ret = sprintf(buf, "%d\n",
			(data->alarms&  (sattr->index ? 0x4000 : 0x8000)));
		break;

but it lacked normalization (output value 0x4000 or 0x8000 instead of 1.) Maybe when normalizing the logic was inverted by accident?

The few ADT7475 data points I have found on the web suggest that on many boards temp1 and temp3 are not connected. This could explain why the bug went unnoticed so far. Why vendors use these chips, which are specifically designed for automatic temperature-based fan speed control, in designs where they don't bother wiring the thermal sensors, is beyond me.

Quoted 5 lines
Quoted 2 lines

Anyway, I will wait for you to return home and test on your system, before sending the patch to Linus.

Hans, did you have the time to test this patch?

I did not get around to it sofar, but I had already planned to do it this evening, so I just have. Your patch seems to be correct when run on real hardware (and the current code in the kernel is thus wrong).

Regards,

Hans

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

#5 lore raw

Re: [lm-sensors] [PATCH] hwmon: (adt7475) Fix temperature fault

In reply to Jean Delvare
Quoted 31 lines · Hans de Goede
Quoted 30 lines · Jean Delvare
Quoted 29 lines · Jean Delvare

Thanks for the feedback. I have tested on 3 dumps I have here, one ADT7475 and two ADT7473. The ADT7475 reports -64°C for temp1 and temp3 and has both fault bits set to 1. The two ADT7473 reports reasonable values for both temp1 and temp3 and have the fault bits set to 0. Assuming that the ADT7473 and ADT7475 are almost the same chip and should thus behave the same, my change would be correct.

I have also noticed that Jordan's original code did not have the inversion:

http://lists.lm-sensors.org/pipermail/lm-sensors/2008-January/022338.html

	case FAULT:
		/* Note - only for remote1 and remote2 */

		ret = sprintf(buf, "%d\n",
			(data->alarms&  (sattr->index ? 0x4000 : 0x8000)));
		break;

but it lacked normalization (output value 0x4000 or 0x8000 instead of 1.) Maybe when normalizing the logic was inverted by accident?

The few ADT7475 data points I have found on the web suggest that on many boards temp1 and temp3 are not connected. This could explain why the bug went unnoticed so far. Why vendors use these chips, which are specifically designed for automatic temperature-based fan speed control, in designs where they don't bother wiring the thermal sensors, is beyond me.

Quoted 8 lines
Quoted 4 lines
Quoted 2 lines

Anyway, I will wait for you to return home and test on your system, before sending the patch to Linus.

Hans, did you have the time to test this patch?

I did not get around to it sofar, but I had already planned to do it this evening, so I just have. Your patch seems to be correct when run on real hardware (and the current code in the kernel is thus wrong).

OK, thanks. I'll send the fix to Linus shortly.

Signature · 6 lines
Jean Delvare

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors