Skip to contentSkip to conversation

smc91111_eeprom: fix compile warning

PATCH New Ben Warren 2 participants 3 messages Nov 9, 2009

lore
Share & tools
lore

Ben Warren

author
#0 lore raw

PATCH 1/1 smc91111_eeprom: fix compile warning

smc91111_eeprom.c:278: warning: suggest parentheses around + or - in operand smc91111_eeprom.c:281: warning: suggest parentheses around + or - in operand

---
 examples/standalone/smc91111_eeprom.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
examples/standalone/smc91111_eeprom.c +2 -2
index 89afc87..345b1ab 100644
@@ -275,10 +275,10 @@ void print_macaddr (struct eth_device *dev)
 	printf ("Current MAC Address in SMSC91111 ");
 	SMC_SELECT_BANK (dev, 1);
 	for (i = 0; i < 5; i++) {
-		printf ("%02x:", SMC_inb (dev, ADDR0_REG + i));
+		printf ("%02x:", SMC_inb (dev, (ADDR0_REG + i)));
 	}
 
-	printf ("%02x\n", SMC_inb (dev, ADDR0_REG + 5));
+	printf ("%02x\n", SMC_inb (dev, (ADDR0_REG + 5)));
 
 	i = 0;
 	for (j = 0x20; j < 0x23; j++) {
Signature · 1 line
1.6.0.4
#1 lore raw

PATCH 1/1 smc91111_eeprom: fix compile warning

examples/standalone/smc91111_eeprom.c void print_macaddr (struct eth_device *dev) · line 279

Quoted 9 lines · On Monday 09 November 2009 16:19:58 Ben Warren wrote:

smc91111_eeprom.c:278: warning: suggest parentheses around + or - in
operand
smc91111_eeprom.c:281: warning: suggest parentheses around + or - in operand

examples/standalone/smc91111_eeprom.c +1 -1
 	for (i = 0; i < 5; i++) {
-		printf ("%02x:", SMC_inb (dev, ADDR0_REG + i));
+		printf ("%02x:", SMC_inb (dev, (ADDR0_REG + i)));
 	}

erm, this says to me that the SMC inb macro is broken. it should be using paren when expanding the second argument. so lets fix that instead.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20091109/e62a8ad3/attachment.pgp

author
#2 lore raw

PATCH 1/1 smc91111_eeprom: fix compile warning

Quoted 7 lines · Mike Frysinger
Quoted 5 lines · On Monday 09 November 2009 16:19:58 Ben Warren wrote:

smc91111_eeprom.c:278: warning: suggest parentheses around + or - in
operand
smc91111_eeprom.c:281: warning: suggest parentheses around + or - in operand

Quoted 10 lines

examples/standalone/smc91111_eeprom.c void print_macaddr (struct eth_device *dev) · line 279

Quoted 5 lines
examples/standalone/smc91111_eeprom.c +1 -1
 	for (i = 0; i < 5; i++) {
-		printf ("%02x:", SMC_inb (dev, ADDR0_REG + i));
+		printf ("%02x:", SMC_inb (dev, (ADDR0_REG + i)));
 	}

erm, this says to me that the SMC inb macro is broken. it should be using paren when expanding the second argument. so lets fix that instead. -mike

Yeah, I see where it is:

#define SMC_inb(a,p)  ({ \
	unsigned int __p = (unsigned int)((a)->iobase + (p<<1)); \
	unsigned int __v = *(volatile unsigned short *)((__p) & ~2); \
	if (__p & 2) __v >>= 8; \
	else __v &= 0xff; \
	__v; })

(p<<1) --> ((p)<<1)

Thanks for pointing this out. Patch coming up.

regards,
Ben