Skip to contentSkip to conversation

serial_cs: oxsemi quirk breaks resume

PATCH Pavel Machek 3 participants 7 messages Nov 10, 2009 – Jan 16, 2010

lore
Share & tools
lore
#0 lore raw

Quirk is applied on all cards with given manfid (is it that correct?). Unfortunately, that quirk breaks resume on zaurus with billionton bluetooth card inserted: c950ctrl is 0 and outb() faults.

drivers/serial/serial_cs.c +2 -1
@@ -158,7 +158,8 @@
 {
 	struct serial_info *info = link->priv;
 
-	outb(12, info->c950ctrl + 1);
+	if (info->c950ctrl)
+		outb(12, info->c950ctrl + 1);
 }
 
 /* request_region? oxsemi branch does no request_region too... */
Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
#1 lore raw
Quoted 4 lines · On Tue, 10 Nov 2009 08:54:11 +0100 Pavel Machek <[email protected]> wrote:

Quirk is applied on all cards with given manfid (is it that correct?). Unfortunately, that quirk breaks resume on zaurus with billionton bluetooth card inserted: c950ctrl is 0 and outb() faults.

So how does it end up as zero, do you have a race between insert/remove somewhere ?

#2 lore raw
Quoted 10 lines · Alan Cox
Quoted 4 lines · On Tue, 10 Nov 2009 08:54:11 +0100 Pavel Machek <[email protected]> wrote:

Quirk is applied on all cards with given manfid (is it that correct?). Unfortunately, that quirk breaks resume on zaurus with billionton bluetooth card inserted: c950ctrl is 0 and outb() faults.

So how does it end up as zero, do you have a race between insert/remove somewhere ?

It does not look like race. I believe it is simply not a multiport card. (info->multi == 1). ... ... confirmed by printks.
Pavel

Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
#3 lore raw
In reply to Pavel Machek
Quoted 6 lines · Pavel Machek

Quirk is applied on all cards with given manfid (is it that correct?). Unfortunately, that quirk breaks resume on zaurus with billionton bluetooth card inserted: c950ctrl is 0 and outb() faults.

I believe this patch got enough acks and is waiting in the tree somewhere (greg?) (possibly with slightly different changelog), but I don't see it in 33-rc4. Could it get pushed? It is quite simple bugfix, and is important for my zaurus... Pavel

Quoted 14 lines
drivers/serial/serial_cs.c +2 -1
@@ -158,7 +158,8 @@
 {
 	struct serial_info *info = link->priv;
 
-	outb(12, info->c950ctrl + 1);
+	if (info->c950ctrl)
+		outb(12, info->c950ctrl + 1);
 }
 
 /* request_region? oxsemi branch does no request_region too... */
Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
#4 lore raw
Quoted 6 lines · Pavel Machek
Quoted 5 lines · Pavel Machek

Quirk is applied on all cards with given manfid (is it that correct?). Unfortunately, that quirk breaks resume on zaurus with billionton bluetooth card inserted: c950ctrl is 0 and outb() faults.

Quoted 6 lines
Quoted 1 line

I believe this patch got enough acks and is waiting in the tree somewhere (greg?) (possibly with slightly different changelog), but I don't see it in 33-rc4. Could it get pushed? It is quite simple bugfix, and is important for my zaurus... Pavel

I thought others complained about it.

If not, care to resend it to me, with the acks added to it, so that I can forward it on?

thanks,

greg k-h

#5 lore raw
Quoted 14 lines · Greg KH
Quoted 6 lines · Pavel Machek
Quoted 5 lines · Pavel Machek

Quirk is applied on all cards with given manfid (is it that correct?). Unfortunately, that quirk breaks resume on zaurus with billionton bluetooth card inserted: c950ctrl is 0 and outb() faults.

Quoted 6 lines
Quoted 1 line

I believe this patch got enough acks and is waiting in the tree somewhere (greg?) (possibly with slightly different changelog), but I don't see it in 33-rc4. Could it get pushed? It is quite simple bugfix, and is important for my zaurus... Pavel

Quoted 4 lines

I thought others complained about it.

If not, care to resend it to me, with the acks added to it, so that I can forward it on?

Oh nevermind, it's in my tree already, I'll include it in the next round of patches to go to Linus (looking like Monday now, too late for today...)

thanks,

greg k-h

#6 lore raw
Quoted 15 lines · Greg KH
Quoted 14 lines · Greg KH
Quoted 12 lines · Pavel Machek
Quoted 6 lines · Pavel Machek

Quirk is applied on all cards with given manfid (is it that correct?). Unfortunately, that quirk breaks resume on zaurus with billionton bluetooth card inserted: c950ctrl is 0 and outb() faults.

I believe this patch got enough acks and is waiting in the tree somewhere (greg?) (possibly with slightly different changelog), but I don't see it in 33-rc4. Could it get pushed? It is quite simple bugfix, and is important for my zaurus... Pavel

Quoted 8 lines
Quoted 4 lines

I thought others complained about it.

If not, care to resend it to me, with the acks added to it, so that I can forward it on?

Oh nevermind, it's in my tree already, I'll include it in the next round of patches to go to Linus (looking like Monday now, too late for today...)

Thanks!

Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html