Skip to contentSkip to conversation

ext3/jdb log_start_commit export symbol issue

PATCH In review Livio Soares 2 participants 2 messages Nov 12, 2009

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ext3/jdb log_start_commit export symbol issue

Hi Jan and all,

It seems like the below patch is necessary when trying to compile ext3 as
a module. I don't know if this is the correct fix (that's up to you), but without ext3 does not link. The following commit caused the problem:

http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=fe8bc91c4c30122b357d197117705cfd4fabaf28

Cheers,

Livio

fs/jbd/journal.c +1 -0
index 49d5cd6..4160afa 100644
@@ -73,6 +73,7 @@ EXPORT_SYMBOL(journal_errno);
 EXPORT_SYMBOL(journal_ack_err);
 EXPORT_SYMBOL(journal_clear_err);
 EXPORT_SYMBOL(log_wait_commit);
+EXPORT_SYMBOL(log_start_commit);
 EXPORT_SYMBOL(journal_start_commit);
 EXPORT_SYMBOL(journal_force_commit_nested);
 EXPORT_SYMBOL(journal_wipe);
#1 lore raw
Quoted 8 lines · Livio Soares

Hi Jan and all,

It seems like the below patch is necessary when trying to compile ext3 as
a module. I don't know if this is the correct fix (that's up to you), but without ext3 does not link. The following commit caused the problem:

http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=fe8bc91c4c30122b357d197117705cfd4fabaf28

Thanks for notifying me, I've already merged the fix.

Honza

Quoted 19 lines

Cheers,

Livio

fs/jbd/journal.c +1 -0
index 49d5cd6..4160afa 100644
@@ -73,6 +73,7 @@ EXPORT_SYMBOL(journal_errno);
 EXPORT_SYMBOL(journal_ack_err);
 EXPORT_SYMBOL(journal_clear_err);
 EXPORT_SYMBOL(log_wait_commit);
+EXPORT_SYMBOL(log_start_commit);
 EXPORT_SYMBOL(journal_start_commit);
 EXPORT_SYMBOL(journal_force_commit_nested);
 EXPORT_SYMBOL(journal_wipe);
Signature · 2 lines
Jan Kara <[email protected]>
SUSE Labs, CR