fs/qnx4: decrement sizeof size in strncmp
Subsystems (2)
Anders Larsen
maintainerFrom: Julia Lawall <[email protected]>
As an identical match is wanted in this case, strcmp can be used instead.
The semantic match that lead to detecting this problem is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@@
expression foo;
constant char *abc;
@@
*strncmp(foo, abc, sizeof(abc))
// </smpl>
Signed-off-by Julia Lawall <[email protected]>
Signed-off-by Anders Larsen <[email protected]>
--- fs/qnx4/inode.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-)
fs/qnx4/inode.c +2 -1
@@ -221,7 +221,8 @@ static const char *qnx4_checkroot(struct super_block *sb) rootdir = (struct qnx4_inode_entry *) (bh->b_data + i *QNX4_DIR_ENTRY_SIZE );if (rootdir->di_fname !=NULL ) {QNX4DEBUG ((KERN_INFO "rootdir entry found : [%s]\n" , rootdir->di_fname)); -if (!strncmp (rootdir->di_fname,QNX4_BMNAME ,sizeof QNX4_BMNAME )) { +if (!strcmp (rootdir->di_fname, +QNX4_BMNAME )) { found =1 ;qnx4_sb (sb)->BitMap =kmalloc (sizeof (struct qnx4_inode_entry ),GFP_KERNEL );if (!qnx4_sb (sb)->BitMap) {
Jiri Kosina
AppliedQuoted 28 lines · Anders Larsen
From: Julia Lawall <[email protected]>
As an identical match is wanted in this case, strcmp can be used instead.
The semantic match that lead to detecting this problem is as follows:
(http://coccinelle.lip6.fr/)// <smpl>
@@
expression foo;
constant char *abc;
@@*strncmp(foo, abc, sizeof(abc))
// </smpl>Signed-off-by Julia Lawall <[email protected]>Signed-off-by Anders Larsen <[email protected]>--- fs/qnx4/inode.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-)fs/qnx4/inode.c +0
-0
fs/qnx4/inode.c static const char *qnx4_checkroot(struct super_block *sb) · line 228
Quoted 9 lines
fs/qnx4/inode.c +2
-1@@ -221,7 +221,8 @@ static const char *qnx4_checkroot(struct super_block *sb) rootdir = (struct qnx4_inode_entry *) (bh->b_data + i *QNX4_DIR_ENTRY_SIZE );if (rootdir->di_fname !=NULL ) {QNX4DEBUG ((KERN_INFO "rootdir entry found : [%s]\n" , rootdir->di_fname)); -if (!strncmp (rootdir->di_fname,QNX4_BMNAME ,sizeof QNX4_BMNAME )) { +if (!strcmp (rootdir->di_fname, +QNX4_BMNAME )) { found =1 ;qnx4_sb (sb)->BitMap =kmalloc (sizeof (struct qnx4_inode_entry ),GFP_KERNEL );if (!qnx4_sb (sb)->BitMap) {
Doesn't seem to be present in 2.6.33-rc1.
Applied to my queue, thanks.
Signature · 2 lines
Jiri Kosina SUSE Labs, Novell Inc.