Skip to contentSkip to conversation

eLBC NAND: give more verbose output on error

PATCH In review Scott Wood 1 participant 1 message Nov 13, 2009

Subsystems (2)
lore
Share & tools
lore

Scott Wood

author
#0 lore raw

PATCH 3/3 eLBC NAND: give more verbose output on error

We want error information even if the kernel hasn't been built for verbose debugging.

---
 drivers/mtd/nand/fsl_elbc_nand.c |   13 ++++++++-----
 1 files changed, 8 insertions(+), 5 deletions(-)
drivers/mtd/nand/fsl_elbc_nand.c +8 -5
index 5b51ed3..ae30fb6 100644
@@ -237,12 +237,15 @@ static int fsl_elbc_run_command(struct mtd_info *mtd)
 
 	ctrl->use_mdr = 0;
 
-	dev_vdbg(ctrl->dev,
-	         "fsl_elbc_run_command: stat=%08x mdr=%08x fmr=%08x\n",
-	         ctrl->status, ctrl->mdr, in_be32(&lbc->fmr));
+	if (ctrl->status != LTESR_CC) {
+		dev_info(ctrl->dev,
+		         "command failed: fir %x fcr %x status %x mdr %x\n",
+		         in_be32(&lbc->fir), in_be32(&lbc->fcr),
+		         ctrl->status, ctrl->mdr);
+		return -EIO;
+	}
 
-	/* returns 0 on success otherwise non-zero) */
-	return ctrl->status == LTESR_CC ? 0 : -EIO;
+	return 0;
 }
 
 static void fsl_elbc_do_read(struct nand_chip *chip, int oob)
Signature · 1 line
1.6.4.4