Skip to contentSkip to conversation

input: atkbd - add forced release kays quirk for Samsung N130

PATCH In review Johannes Stezenbach 2 participants 4 messages Nov 16, 2009 – Nov 18, 2009

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 input: atkbd - add forced release kays quirk for Samsung N130

Samsung N130 has the same function key quirks as the NC10.

---
It would be nice if this could go into 2.6.32. It might also be suitable for stable.

drivers/input/keyboard/atkbd.c +9 -0
index 4452eab..ad2dc7d 100644
@@ -1646,6 +1646,15 @@ static struct dmi_system_id atkbd_dmi_quirk_table[] __initdata = {
 		.driver_data = atkbd_samsung_forced_release_keys,
 	},
 	{
+		.ident = "Samsung N130",
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "SAMSUNG ELECTRONICS CO., LTD."),
+			DMI_MATCH(DMI_PRODUCT_NAME, "N130"),
+		},
+		.callback = atkbd_setup_forced_release,
+		.driver_data = atkbd_samsung_forced_release_keys,
+	},
+	{
 		.ident = "Samsung SQ45S70S",
 		.matches = {
 			DMI_MATCH(DMI_SYS_VENDOR, "SAMSUNG ELECTRONICS CO., LTD."),
maintainer
#1 lore raw

Hi Johannes,

Quoted 6 lines · Johannes Stezenbach

Samsung N130 has the same function key quirks as the NC10.

---
It would be nice if this could go into 2.6.32. It might also be suitable for stable.

2.6.32 will allow manipulating force release quirk from userspace (sysfs) so I stopped accepting in-kernel quirks like this one.

Thanks.

Signature · 1 line
Dmitry
#2 lore raw

Hi Dmitry,

Quoted 10 lines · Dmitry Torokhov
Quoted 6 lines · Johannes Stezenbach

Samsung N130 has the same function key quirks as the NC10.

---
It would be nice if this could go into 2.6.32. It might also be suitable for stable.

2.6.32 will allow manipulating force release quirk from userspace (sysfs) so I stopped accepting in-kernel quirks like this one.

OK, makes sense. Will this be put in udev along with the keymap setup for the function keys? If yes, is there already an example how to do it correctly so I can submit a patch to add the N130 support there?

Thanks
Johannes

maintainer
#3 lore raw
Quoted 11 lines · Johannes Stezenbach

Hi Dmitry,

Quoted 8 lines · Dmitry Torokhov
Quoted 6 lines · Johannes Stezenbach

Samsung N130 has the same function key quirks as the NC10.

---
It would be nice if this could go into 2.6.32. It might also be suitable for stable.

Quoted 5 lines
Quoted 2 lines

2.6.32 will allow manipulating force release quirk from userspace (sysfs) so I stopped accepting in-kernel quirks like this one.

OK, makes sense. Will this be put in udev along with the keymap setup for the function keys?

I think that is the best place to put it, yes.

Quoted 3 lines

If yes, is
there already an example how to do it correctly so I can submit a patch to add the N130 support there?

No, but you can be the first and pave the road ;)

Signature · 1 line
Dmitry