Skip to contentSkip to conversation

mac80211: Do not queue Probe Request frames for station MLME

PATCH In review Jouni Malinen 2 participants 2 messages Nov 16, 2009 mac80211

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mac80211: Do not queue Probe Request frames for station MLME

Cooked monitor interfaces cannot currently receive Probe Request frames when the interface is in station mode. However, we do not process Probe Request frames internally in the station MLME, so there is no point in queueing the frame here. Remove Probe Request frames from the queued frame list to allow cooked monitor interfaces to receive these frames.

---
 net/mac80211/mlme.c |    1 -
 1 file changed, 1 deletion(-)
net/mac80211/mlme.c +0 -1
@@ -1898,7 +1898,6 @@ ieee80211_rx_result ieee80211_sta_rx_mgm
 	fc = le16_to_cpu(mgmt->frame_control);
 
 	switch (fc & IEEE80211_FCTL_STYPE) {
-	case IEEE80211_STYPE_PROBE_REQ:
 	case IEEE80211_STYPE_PROBE_RESP:
 	case IEEE80211_STYPE_BEACON:
 	case IEEE80211_STYPE_AUTH:
Signature · 1 line
Jouni Malinen                                            PGP id EFC895FA
maintainer Reviewed-by on v1 1/1
#1 lore raw
Quoted 8 lines · Jouni Malinen

Cooked monitor interfaces cannot currently receive Probe Request frames when the interface is in station mode. However, we do not process Probe Request frames internally in the station MLME, so there is no point in queueing the frame here. Remove Probe Request frames from the queued frame list to allow cooked monitor interfaces to receive these frames.

It's also just unnecessary overhead to put them on the list and process them by freeing :)

Quoted 16 lines
---
 net/mac80211/mlme.c |    1 -
 1 file changed, 1 deletion(-)
net/mac80211/mlme.c +0 -1
@@ -1898,7 +1898,6 @@ ieee80211_rx_result ieee80211_sta_rx_mgm
 	fc = le16_to_cpu(mgmt->frame_control);
 
 	switch (fc & IEEE80211_FCTL_STYPE) {
-	case IEEE80211_STYPE_PROBE_REQ:
 	case IEEE80211_STYPE_PROBE_RESP:
 	case IEEE80211_STYPE_BEACON:
 	case IEEE80211_STYPE_AUTH: