Skip to contentSkip to conversation

ep93xx: add missing parentheses in IOMEM macro

PATCH New Hubert Feurstein 3 participants 3 messages Nov 17, 2009 – Nov 19, 2009

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ep93xx: add missing parentheses in IOMEM macro

---
 arch/arm/mach-ep93xx/include/mach/io.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
arch/arm/mach-ep93xx/include/mach/io.h +1 -1
index 594b77f..ddb6e32 100644
@@ -14,7 +14,7 @@
  * A typesafe __io() variation for variable initialisers
  */
 #ifdef __ASSEMBLER__
-#define IOMEM(p)		p
+#define IOMEM(p)		(p)
 #else
 #define IOMEM(p)		((void __iomem __force *)(p))
 #endif
Signature · 1 line
1.6.4.4
#1 lore raw

PATCH 1/1 ep93xx: add missing parentheses in IOMEM macro

Quoted 11 lines · Hubert Feurstein
---
 arch/arm/mach-ep93xx/include/mach/io.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
arch/arm/mach-ep93xx/include/mach/io.h +0 -0
index 594b77f..ddb6e32 100644

arch/arm/mach-ep93xx/include/mach/io.h line 20

Quoted 8 lines
arch/arm/mach-ep93xx/include/mach/io.h +1 -1
@@ -14,7 +14,7 @@
  * A typesafe __io() variation for variable initialisers
  */
 #ifdef __ASSEMBLER__
-#define IOMEM(p)		p
+#define IOMEM(p)		(p)
 #else
 #define IOMEM(p)		((void __iomem __force *)(p))
 #endif

I think the __ASSEMBLER__ version of the IOMEM macro is missing the parentheses on purpose.

Maybe Russell can shed some light on this.

Regards,
Hartley

#2 lore raw

PATCH 1/1 ep93xx: add missing parentheses in IOMEM macro

Quoted 24 lines · H Hartley Sweeten
Quoted 11 lines · Hubert Feurstein
---
 arch/arm/mach-ep93xx/include/mach/io.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
arch/arm/mach-ep93xx/include/mach/io.h +0 -0
index 594b77f..ddb6e32 100644

arch/arm/mach-ep93xx/include/mach/io.h line 20

Quoted 8 lines
arch/arm/mach-ep93xx/include/mach/io.h +1 -1
@@ -14,7 +14,7 @@
  * A typesafe __io() variation for variable initialisers
  */
 #ifdef __ASSEMBLER__
-#define IOMEM(p)		p
+#define IOMEM(p)		(p)
 #else
 #define IOMEM(p)		((void __iomem __force *)(p))
 #endif

I think the __ASSEMBLER__ version of the IOMEM macro is missing the parentheses on purpose.

Quoted 1 line

Maybe Russell can shed some light on this.

Well, parens shouldn't hurt assembly, so it should be safe to add them.