Skip to contentSkip to conversation

drivers: MMC: enable SDHCI-S3C on S5PC1XX platform

PATCH New Marek Szyprowski 3 participants 3 messages Nov 17, 2009

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drivers: MMC: enable SDHCI-S3C on S5PC1XX platform

From: Kyungmin Park <[email protected]>

Samsung S5PC100 SoC has SDHCI controller compatible to the one known from S3C64xx SoCs. Enable support for sdhci-s3c driver also on S5PC1xx platform.

---
 drivers/mmc/host/Kconfig |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/mmc/host/Kconfig +1 -1
index 432ae83..faddf82 100644
@@ -96,7 +96,7 @@ config MMC_SDHCI_PLTFM
 
 config MMC_SDHCI_S3C
 	tristate "SDHCI support on Samsung S3C SoC"
-	depends on MMC_SDHCI && (PLAT_S3C24XX || PLAT_S3C64XX)
+	depends on MMC_SDHCI && (PLAT_S3C24XX || PLAT_S3C64XX || PLAT_S5PC1XX)
 	help
 	  This selects the Secure Digital Host Controller Interface (SDHCI)
 	  often referrered to as the HSMMC block in some of the Samsung S3C
Signature · 1 line
1.6.4
#1 lore raw

PATCH 1/1 drivers: MMC: enable SDHCI-S3C on S5PC1XX platform

Quoted 23 lines · On Tue, 17 Nov 2009 08:52:54 +0100 Marek Szyprowski <[email protected]>…

From: Kyungmin Park <[email protected]>

Samsung S5PC100 SoC has SDHCI controller compatible to the one known from S3C64xx SoCs. Enable support for sdhci-s3c driver also on S5PC1xx platform.

---
 drivers/mmc/host/Kconfig |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/mmc/host/Kconfig +1 -1
index 432ae83..faddf82 100644
@@ -96,7 +96,7 @@ config MMC_SDHCI_PLTFM
 
 config MMC_SDHCI_S3C
 	tristate "SDHCI support on Samsung S3C SoC"
-	depends on MMC_SDHCI && (PLAT_S3C24XX || PLAT_S3C64XX)
+	depends on MMC_SDHCI && (PLAT_S3C24XX || PLAT_S3C64XX ||
Quoted 4 lines

PLAT_S5PC1XX) help
This selects the Secure Digital Host Controller Interface
(SDHCI) often referrered to as the HSMMC block in some of the Samsung S3C

I think it was Ben that suggested once to introduce a HAVE_SDHCI_S3C symbol, selected by interested parties (S3C, S5P, S5PC...).

Given the way Samsung SoCs are assembled (from an IP point of view), it would make sense for one SoC to describe its features in "HAVE_FEATURE_FOO" terms rather than each subsystem depending an ever growing list of SoC.

	M.
Signature · 1 line
Fast. Cheap. Reliable. Pick two.
#2 lore raw

PATCH 1/1 drivers: MMC: enable SDHCI-S3C on S5PC1XX platform

Quoted 5 lines · Marc Zyngier

On Tue, 17 Nov 2009 08:52:54 +0100
Marek Szyprowski <[email protected]> wrote:

I think it was Ben that suggested once to introduce a HAVE_SDHCI_S3C symbol, selected by interested parties (S3C, S5P, S5PC...).

Yes, I did mention this and it is an option to either replace the patch now or to do at a later date to tidy things up. I'm not going to reject this patch now (or force a rewrite at this late stage)

I'll try and look at acking the last set of SDHCI patches Thomas sent and see if akpm will pick them up for linux-mmc.

Quoted 4 lines

Given the way Samsung SoCs are assembled (from an IP point of view), it would make sense for one SoC to describe its features in "HAVE_FEATURE_FOO" terms rather than each subsystem depending an ever growing list of SoC.

Yes, I was feeling that this is something that we should probably discuss either on linux-arm-kernel or to a wide audience. It might not suit everyone's taste, etc.

Signature · 4 lines
Ben

Q:      What's a light-year?
A:      One-third less calories than a regular year.