Skip to contentSkip to conversation

Add param ops struct for hvc_iucv driver.

PATCH Applied Sachin Sant 3 participants 4 messages Nov 17, 2009 – Nov 18, 2009

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Add param ops struct for hvc_iucv driver.

Today's next 20091117 build failed on s390 with

drivers/char/hvc_iucv.c:1331: error: 'param_ops_vmidfilter' undeclared here (not in a function) make[2]: *** [drivers/char/hvc_iucv.o] Error 1

Most probably caused by commit 684a6d340b8a5767db4670031b0f39455346018a (param:param_ops) which introduced a param_ops structure.

The following compile tested patch adds a param_ops structure for hvc_iucv.

---

drivers/char/hvc_iucv.c +7 -2
diff -Naurp a/drivers/char/hvc_iucv.c b/drivers/char/hvc_iucv.c
@@ -1146,7 +1146,7 @@ out_err:
  * Note: If it is called early in the boot process, @val is stored and
  *	 parsed later in hvc_iucv_init().
  */
-static int param_set_vmidfilter(const char *val, struct kernel_param *kp)
+static int param_set_vmidfilter(const char *val, const struct kernel_param *kp)
 {
 	int rc;
 
@@ -1173,7 +1173,7 @@ static int param_set_vmidfilter(const ch
  * The function stores the filter as a comma-separated list of z/VM user IDs
  * in @buffer. Typically, sysfs routines call this function for attr show.
  */
-static int param_get_vmidfilter(char *buffer, struct kernel_param *kp)
+static int param_get_vmidfilter(char *buffer, const struct kernel_param *kp)
 {
 	int rc;
 	size_t index, len;
@@ -1200,6 +1200,11 @@ static int param_get_vmidfilter(char *bu
 
 #define param_check_vmidfilter(name, p) __param_check(name, p, void)
 
+static struct kernel_param_ops param_ops_vmidfilter = {
+        .set = param_set_vmidfilter,
+        .get = param_get_vmidfilter,
+};
+
 /**
  * hvc_iucv_init() - z/VM IUCV HVC device driver initialization
  */
Acked-by on v1 1/1
#1 lore raw
Quoted 5 lines · Sachin Sant

Today's next 20091117 build failed on s390 with

drivers/char/hvc_iucv.c:1331: error: 'param_ops_vmidfilter' undeclared here (not in a function) make[2]: *** [drivers/char/hvc_iucv.o] Error 1

Quoted 7 lines

Most probably caused by commit 684a6d340b8a5767db4670031b0f39455346018a (param:param_ops) which introduced a param_ops structure.

The following compile tested patch adds a param_ops structure for hvc_iucv.

---

Yep, thanks. I just did the same.

Rusty, could you pick this one up?

#2 lore raw
Quoted 3 lines · Heiko Carstens
Quoted 2 lines · Sachin Sant

The following compile tested patch adds a param_ops structure for hvc_iucv.

...

Quoted 3 lines

Rusty, could you pick this one up?

Thanks, applied, fixed spaces which should have been tabs.

Cheers,
Rusty.

#3 lore raw
Quoted 1 line · Rusty Russell

Thanks, applied, fixed spaces which should have been tabs.

Sorry about that. Would be more careful.

Thanks
-Sachin

Signature · 6 lines
---------------------------------
Sachin Sant
IBM Linux Technology Center
India Systems and Technology Labs
Bangalore, India
---------------------------------